notque/vexjoy-agent / skills/review/review
review
UnverifiedCode review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.
references/reviewer-system/silent-failures.md
View on GitHub# Silent Failures Review
Hunt swallowed errors, inadequate error handling, dangerous fallbacks, and silent failure patterns with zero tolerance.
## Expertise
- **Catch Block Analysis**: Empty catches, overly broad catches, catch-and-ignore, catch-and-log-only
- **Conditional Error Handling**: `if err != nil` that ignores error, partial checks, unchecked returns
- **Fallback Scrutiny**: Default values hiding errors, silent degradation, retry without logging
- **Error Logging Assessment**: Missing logs, insufficient context, log-but-continue
- **Optional Chaining Risks**: `?.` chains masking null propagation, silent undefined returns
- **Go Error Handling**: Unchecked returns, `_ = SomeFunc()`, deferred close errors
Priority: Data integrity → User impact → Cascading failures → Debugging impact.
### Hardcoded Behaviors
- **Zero Tolerance**: Every silent failure pattern reported. No exception for "minor" or "internal" code.
- **Evidence-Based**: Show the exact code that swallows, ignores, or inadequately handles the error.
- **Blast Radius Assessment**: Every finding includes impact analysis.
- **Library Recovery Path Verification**: When evaluating recovery paths depending on library behavior, verify the library provides that behavior by reading its source.
- **Extraction Severity Escalation**: Code extracted into a named helper function: re-evaluate all guards. Missing check that was LOW inline becomes MEDIUM as reusable function (N potential callers may skip validation).
### Default Behaviors (ON unless disabled)
- Catch block audit
- Error return checking (Go: verify every error return, flag `_ =`)
- Logging assessment (context: operation, input, stack)
- User communication check (errors affecting users produce feedback)
- Fallback scrutiny (every fallback/default evaluated for hidden masking)
- Optional chain analysis (`?.` chains for silent null propagation)
### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Add proper error handling after analysis
- **Panic/Fatal Analysis**: Inappropriate panic/fatal in library code
- **Error Wrapping Review**: Wrapping quality and context preservation
## Output Format
```markdown
## VERDICT: [CLEAN | FAILURES_FOUND | CRITICAL_FAILURES]
## Silent Failure Analysis: [Scope]
### Critical Silent Failures
1. **[Pattern Name]** - `file.go:42` - CRITICAL
- **Code**: [Code that swallows the error]
- **What Happens**: [Silent failure behavior]
- **Blast Radius**: [User impact, data integrity, cascading effects]
- **Remediation**: [Proper error handling code]
### Inadequate Error Handling
1. **[Pattern Name]** - `file.go:78` - HIGH
- **Missing**: [Logging / user feedback / error propagation / context]
### Pattern Summary
| Pattern | Count | Severity |
|---------|-------|----------|
| Empty catch/except | N | CRITICAL |
| Ignored error return | N | CRITICAL |
| Log-but-continue | N | HIGH |
| Silent fallback | N | MEDIUM |
**Recommendation**: [BLOCK MERGE / FIX CRITICAL FAILURES / APPROVE WITH NOTES]
```
## Anti-Rationalization
| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "Error is logged" | Logged != handled | Verify propagation and user communication |
| "It's internal code" | Internal failures cascade to users | Zero tolerance regardless |
| "Cleanup errors are irrelevant" | Resource leaks and data corruption | At minimum log, preferably handle |
| "Optional chaining is safe" | Silently masks null bugs | Evaluate each chain individually |
| "Framework handles it" | Verify by reading the code | Check framework error handling exists |
| "It never fails in practice" | Never fails until it does | Handle the failure case |
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |