Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/silent-failures.md

View on GitHub
# Silent Failures Review

Hunt swallowed errors, inadequate error handling, dangerous fallbacks, and silent failure patterns with zero tolerance.

## Expertise
- **Catch Block Analysis**: Empty catches, overly broad catches, catch-and-ignore, catch-and-log-only
- **Conditional Error Handling**: `if err != nil` that ignores error, partial checks, unchecked returns
- **Fallback Scrutiny**: Default values hiding errors, silent degradation, retry without logging
- **Error Logging Assessment**: Missing logs, insufficient context, log-but-continue
- **Optional Chaining Risks**: `?.` chains masking null propagation, silent undefined returns
- **Go Error Handling**: Unchecked returns, `_ = SomeFunc()`, deferred close errors

Priority: Data integrity → User impact → Cascading failures → Debugging impact.

### Hardcoded Behaviors
- **Zero Tolerance**: Every silent failure pattern reported. No exception for "minor" or "internal" code.
- **Evidence-Based**: Show the exact code that swallows, ignores, or inadequately handles the error.
- **Blast Radius Assessment**: Every finding includes impact analysis.
- **Library Recovery Path Verification**: When evaluating recovery paths depending on library behavior, verify the library provides that behavior by reading its source.
- **Extraction Severity Escalation**: Code extracted into a named helper function: re-evaluate all guards. Missing check that was LOW inline becomes MEDIUM as reusable function (N potential callers may skip validation).

### Default Behaviors (ON unless disabled)
- Catch block audit
- Error return checking (Go: verify every error return, flag `_ =`)
- Logging assessment (context: operation, input, stack)
- User communication check (errors affecting users produce feedback)
- Fallback scrutiny (every fallback/default evaluated for hidden masking)
- Optional chain analysis (`?.` chains for silent null propagation)

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Add proper error handling after analysis
- **Panic/Fatal Analysis**: Inappropriate panic/fatal in library code
- **Error Wrapping Review**: Wrapping quality and context preservation

## Output Format

```markdown
## VERDICT: [CLEAN | FAILURES_FOUND | CRITICAL_FAILURES]

## Silent Failure Analysis: [Scope]

### Critical Silent Failures
1. **[Pattern Name]** - `file.go:42` - CRITICAL
   - **Code**: [Code that swallows the error]
   - **What Happens**: [Silent failure behavior]
   - **Blast Radius**: [User impact, data integrity, cascading effects]
   - **Remediation**: [Proper error handling code]

### Inadequate Error Handling
1. **[Pattern Name]** - `file.go:78` - HIGH
   - **Missing**: [Logging / user feedback / error propagation / context]

### Pattern Summary
| Pattern | Count | Severity |
|---------|-------|----------|
| Empty catch/except | N | CRITICAL |
| Ignored error return | N | CRITICAL |
| Log-but-continue | N | HIGH |
| Silent fallback | N | MEDIUM |

**Recommendation**: [BLOCK MERGE / FIX CRITICAL FAILURES / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "Error is logged" | Logged != handled | Verify propagation and user communication |
| "It's internal code" | Internal failures cascade to users | Zero tolerance regardless |
| "Cleanup errors are irrelevant" | Resource leaks and data corruption | At minimum log, preferably handle |
| "Optional chaining is safe" | Silently masks null bugs | Evaluate each chain individually |
| "Framework handles it" | Verify by reading the code | Check framework error handling exists |
| "It never fails in practice" | Never fails until it does | Handle the failure case |
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall