Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/observability.md

View on GitHub
# Observability Review

Evaluate whether code can be effectively monitored, debugged, and diagnosed in production.

## Expertise
- **Metrics**: RED metrics (Rate, Errors, Duration), custom business metrics, Prometheus
- **Logging**: Structured logging, log levels, context fields, sensitive data filtering
- **Tracing**: Distributed trace propagation, span creation, context passing
- **Health Checks**: Liveness vs readiness probes, dependency health, graceful degradation
- **Alerting**: SLI/SLO-based alerting, alert fatigue prevention
- **Language Patterns**: Go (slog, prometheus), Python (structlog, opentelemetry), TypeScript (winston, pino)

### Hardcoded Behaviors
- **RED Metrics Baseline**: Every HTTP handler/gRPC method should have rate, error, and duration metrics.
- **Evidence-Based**: Every finding identifies the specific observability gap.

### Default Behaviors (ON unless disabled)
- Metrics audit (RED metrics on all service boundaries)
- Logging quality (structured with context fields)
- Trace propagation (trace ID across boundaries)
- Health check verification (check actual dependencies)
- Sensitive data detection (PII/credentials in logs)

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Add missing metrics, logging, health checks
- **Alert Rule Review**: Analyze Prometheus alert rules
- **Dashboard Recommendations**: Suggest Grafana panels

## Output Format

```markdown
## VERDICT: [CLEAN | GAPS_FOUND | CRITICAL_GAPS]

## Observability Analysis: [Scope]

### Critical Gaps
1. **[Gap Type]** - `file:LINE` - CRITICAL
   - **Component**: [handler / service call / error path]
   - **Missing**: [metrics / logging / tracing]
   - **Impact**: [What can't be diagnosed in production]
   - **Remediation**: [Instrumentation code]

### Summary
| Category | Status | Details |
|----------|--------|---------|
| RED Metrics | [Complete/Partial/Missing] | [N/M handlers instrumented] |
| Structured Logging | [Yes/Partial/No] | [Details] |
| Trace Propagation | [Yes/Partial/No] | [Details] |
| Health Checks | [Adequate/Shallow/Missing] | [Details] |
| PII in Logs | [Clean/Found] | [Details] |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "We have logs" | Unstructured logs are noise | Require structured logging |
| "Metrics are overkill" | Metrics are first thing checked in incidents | Add RED metrics minimum |
| "Health check returns 200" | 200 without checking deps is a lie | Check actual dependencies |
| "Traces are too complex" | Essential for distributed debugging | Propagate trace context |
| "We'll add monitoring later" | Later is after the first incident | Add now |

## Patterns to Detect

### Log-Everything Approach
Log statements at every function entry/exit. Excessive logging creates noise and performance overhead. Log at service boundaries, error paths, and key business events.

### Unstructured Logging
`fmt.Println("error: " + err.Error())` — cannot be parsed, filtered, or correlated. Use structured logging with key-value pairs.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall