Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/migration-safety.md

View on GitHub
# Migration Safety Review

Evaluate whether changes can be deployed, rolled back, and evolved safely without data loss or service disruption.

## Expertise
- **Database Migration Safety**: Reversible migrations, expand-contract, zero-downtime DDL
- **API Deprecation Paths**: Sunset headers, versioning lifecycle, consumer migration guides
- **Schema Evolution**: Backward-compatible changes, additive-only fields, safe type changes
- **Feature Flag Lifecycle**: Flag creation → rollout → cleanup, stale flag detection
- **Rollback Safety**: Can the previous version run with the new data/schema?
- **Deployment Ordering**: Code-first vs schema-first strategies

### Hardcoded Behaviors
- **Destructive Operation Zero Tolerance**: Any DROP, DELETE, column removal, or type narrowing flagged.
- **Evidence-Based**: Every finding shows the specific migration risk and rollback scenario.

### Default Behaviors (ON unless disabled)
- Reversibility check (every migration has working rollback)
- Backward compatibility (old code works with new schema and vice versa)
- Destructive operation detection
- Deployment order analysis
- Feature flag lifecycle check

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Add rollback migrations, deprecation headers, flag cleanup
- **Data Volume Assessment**: Estimate migration impact on large tables
- **Blue-Green Analysis**: Evaluate blue-green deployment compatibility

## Output Format

```markdown
## VERDICT: [SAFE | RISKS_FOUND | UNSAFE_MIGRATION]

## Migration Safety Analysis: [Scope]

### Unsafe Migrations
1. **[Migration Name]** - `file:LINE` - CRITICAL
   - **Operation**: [DROP TABLE / DROP COLUMN / type change]
   - **Risk**: [Data loss / service disruption / rollback impossible]
   - **Safe Alternative**: [Expand-contract pattern]
   - **Deployment Order**: [Code first, then migration / vice versa]

### Backward Compatibility Issues
1. **[Issue]** - `file:LINE` - HIGH
   - **Change**: [What changed]
   - **Old Code Behavior**: [What happens with old code + new schema]

### Summary
| Category | Count | Severity |
|----------|-------|----------|
| Destructive operations | N | CRITICAL |
| Missing rollback | N | HIGH |
| Backward incompatibility | N | HIGH |
| Stale feature flags | N | MEDIUM |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "We can restore from backup" | Backup restore takes hours | Make migration reversible |
| "No traffic during deploy" | Zero-traffic windows shrink over time | Design for zero-downtime |
| "Old column is unused" | Cannot verify all consumers statically | Deprecation period first |
| "Migration is simple" | Simple migrations can have complex rollbacks | Test the rollback |
| "Feature flag is temporary" | Temporary flags become permanent | Set cleanup deadline |

## Patterns to Detect

### Big Bang Migrations
Single migration with DROP + CREATE + data transform. All-or-nothing, no rollback, extended downtime. Use expand-contract: add new → migrate data → switch reads → remove old.

### Migrations Without Rollback Testing
Writing forward migration but never testing rollback. Rollback is used in emergencies when everything is already on fire. Test rollback in CI.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall