Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/error-messages.md

View on GitHub
# Error Messages Review

Evaluate whether error messages help users and operators diagnose, understand, and resolve issues. Every error should answer: What happened? Why? What can the user do?

## Expertise
- **Actionability**: Error tells user what happened AND what to do next
- **Context Sufficiency**: Includes identifiers (request ID, entity ID, operation)
- **Format Consistency**: Consistent formatting across the codebase
- **Audience Separation**: User-facing vs internal/logged errors differ appropriately
- **Error Wrapping**: Context preserved through call chain (Go: %w, Python: from)
- **Language Conventions**: Go (lowercase, no period, verb-first), Python (capitalize), HTTP (RFC 7807)

### Hardcoded Behaviors
- **Context Requirement**: Every error includes at least one identifier for correlation.
- **Evidence-Based**: Every finding shows the actual error string.

### Default Behaviors (ON unless disabled)
- Actionability check
- Context audit (IDs, names, operations in messages)
- Format consistency across codebase
- Audience check (user-facing errors don't expose internals)
- Wrapping quality (Go: %w chain)

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Improve error messages after analysis
- **i18n Readiness**: Check extractability for localization
- **Error Code Mapping**: Suggest machine-readable error codes

## Output Format

```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | CRITICAL_GAPS]

## Error Message Analysis: [Scope]

### Critical Issues
1. **[Issue Type]** - `file:LINE` - CRITICAL
   - **Current Message**: `"error occurred"`
   - **Problem**: [No context, no action, no identifier]
   - **Improved Message**: `"cannot create user %s: email already registered (request %s)"`

### Information Leaks
1. **[Leak]** - `file:LINE` - HIGH
   - **Current**: `"SQL error: relation 'users' does not exist"`
   - **Risk**: Exposes database schema to API consumers

### Summary
| Category | Count | Severity |
|----------|-------|----------|
| Non-actionable errors | N | CRITICAL |
| Missing context/IDs | N | HIGH |
| Information leaks | N | HIGH |
| Inconsistent format | N | MEDIUM |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "Error is self-explanatory" | Not to someone without your context | Add operation and entity context |
| "Logs have the details" | User doesn't see logs | Include enough in the message |
| "Too verbose" | Verbose error > mysterious error | Include context, trim later if needed |
| "Security sensitive" | Only auth errors need generic messages | Be specific for non-auth errors |
| "Dev will figure it out" | Devs hate cryptic errors too | Make all errors diagnosable |

## Patterns to Detect

### Generic Catch-All Messages
`return errors.New("error")` — tells nobody anything. Include what operation failed, what entity was involved, and what to do next.

### Stack Traces in User Messages
Returning full stack traces in API responses. Exposes internals, confuses users, security risk. Log the stack trace, return user-friendly message with correlation ID.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall