Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/concurrency.md

View on GitHub
# Concurrency Review

Detect race conditions, goroutine/task leaks, deadlocks, and unsafe shared state across Go, Python, and TypeScript.

## Expertise
- **Race Conditions**: Unsynchronized shared state, read-write races, check-then-act
- **Goroutine/Task Leaks**: Unbounded creation, missing cancellation, fire-and-forget
- **Deadlocks**: Lock ordering violations, nested locks, channel-mutex interactions
- **Mutex Misuse**: Over-scoped locks, wrong defer order, RWMutex misuse
- **Channel Lifecycle**: Unclosed channels, send on closed, blocking forever
- **Context Propagation**: Missing context.Context, ignored cancellation, leaked backgrounds

Analysis approach: trace goroutine/task lifecycle (creation → work → completion/cancellation), verify every shared variable has synchronization, check lock ordering consistency, verify channel close is single-owner, check context propagation through concurrent boundaries.

### Hardcoded Behaviors
- **CLAUDE.md Compliance**: Read repository CLAUDE.md before analysis.
- **Zero Tolerance for Data Races**: Every unsynchronized shared state access reported.
- **Structured Output**: Findings use Concurrency Analysis Schema with severity.
- **Evidence-Based**: Every finding shows the exact concurrent access path.

### Default Behaviors (ON unless disabled)
- Goroutine lifecycle tracking
- Lock order analysis
- Channel close verification
- Context propagation check
- Shared state audit

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Add synchronization after analysis
- **Race Detector Guidance**: Suggest `-race` test scenarios for Go
- **Stress Test Recommendations**: Suggest concurrent stress tests per finding

## Output Format

```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | CRITICAL_RACES]

## Concurrency Analysis: [Scope]

### Analysis Scope
- **Files Analyzed**: [count]
- **Concurrent Patterns Found**: [count]
- **Goroutines/Tasks Traced**: [count]

### Critical Concurrency Issues
1. **[Pattern Name]** - `file:LINE` - CRITICAL
   - **Type**: [Data Race / Deadlock / Goroutine Leak / Channel Misuse]
   - **Concurrent Access Path**:
     - Goroutine 1: [path to shared state]
     - Goroutine 2: [path to shared state]
   - **Blast Radius**: [What breaks under contention]
   - **Remediation**: [Thread-safe code]

### Concurrency Summary
| Category | Count | Severity |
|----------|-------|----------|
| Data races | N | [highest] |
| Goroutine/task leaks | N | [highest] |
| Deadlock potential | N | [highest] |
| Mutex misuse | N | [highest] |
| Channel issues | N | [highest] |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "It's read-only" | Verify never written concurrently | Check all write paths |
| "Low traffic, won't race" | Races are non-deterministic | Report regardless of traffic |
| "Tests pass" | Tests rarely exercise concurrent paths | Recommend -race flag |
| "It's behind a mutex" | Verify ALL access paths hold the mutex | Check every access site |
| "Context is passed" | Passed != checked for cancellation | Verify cancellation handling |

## Patterns to Detect

### Assuming Single-Threaded
"This struct is only used in one handler, no race possible." Handlers run concurrently. If the struct is shared, it's a race. Verify struct instantiation — per-request (safe) vs singleton (needs synchronization).

### Lock Everything
Recommending mutex for every shared variable. Over-synchronization causes contention and deadlocks. Prefer channels for communication, atomic for counters, immutability for shared data.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall