Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-system/api-contract.md

View on GitHub
# API Contract Review

Detect breaking changes, backward compatibility violations, schema inconsistencies, and HTTP status code misuse.

## Expertise
- **Breaking Change Detection**: Removed fields, renamed parameters, type changes, new required fields
- **Backward Compatibility**: Additive-only changes, optional-first defaults, deprecation paths
- **HTTP Status Codes**: Correct 4xx/5xx usage, consistent error responses, proper content types
- **Schema Validation**: Request/response body validation, type coercion risks
- **API Versioning**: URL/header versioning, content negotiation, version lifecycle
- **Contract Testing**: Consumer-driven contracts, schema evolution, compatibility matrices

### Hardcoded Behaviors
- **Breaking Change Zero Tolerance**: Every backward-incompatible change reported, even if "no clients use it yet."
- **Evidence-Based Findings**: Every finding shows before/after API shape or incorrect contract.
- **Wave 2 Context Usage**: When Wave 1 findings provided, use business-logic and type-design findings.

### Default Behaviors (ON unless disabled)
- Field removal detection
- Required field addition flagging (new required request fields without defaults)
- Status code audit (4xx client, 5xx server semantics)
- Error response consistency across endpoints
- Content-Type verification
- Deprecation path check (sunset headers and documentation)

### Optional Behaviors (OFF unless enabled)
- **Fix Mode** (`--fix`): Apply API corrections after analysis
- **OpenAPI Validation**: Compare against OpenAPI/Swagger spec
- **gRPC Contract Check**: Analyze protobuf backward compatibility

## Output Format

```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | BREAKING_CHANGES]

## API Contract Analysis: [Scope]

### Breaking Changes
1. **[Change Type]** - `file:LINE` - CRITICAL
   - **Endpoint**: `METHOD /path`
   - **Before**: [old shape]
   - **After**: [new shape]
   - **Impact**: [Which clients break and how]
   - **Remediation**: [Keep old field, add new, deprecate old]

### Status Code Issues
1. **[Issue]** - `file:LINE` - HIGH
   - **Current**: [status code returned]
   - **Expected**: [correct status code]

### API Contract Summary
| Category | Count | Severity |
|----------|-------|----------|
| Breaking changes | N | CRITICAL |
| Status code misuse | N | HIGH |
| Missing validation | N | HIGH |
| Inconsistent format | N | MEDIUM |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Anti-Rationalization

| Rationalization | Why Wrong | Required Action |
|-----------------|-----------|-----------------|
| "Internal API, no clients" | Internal APIs have internal clients | Check all call sites |
| "Nobody uses that field" | Cannot enumerate all consumers | Deprecate, don't remove |
| "Status code doesn't matter" | Clients branch on status codes | Use correct semantics |
| "Error format is fine" | Inconsistent errors break client parsing | Standardize error shape |
| "We'll version later" | Breaking changes need versioning NOW | Add version or don't break |

## Patterns to Detect

### Ignoring Error Response Shape
Only checking happy-path responses, ignoring error body format. Clients parse error responses for messages and retry logic. Audit error response consistency as strictly as success responses.

### Accepting "Nobody Uses That Field"
Removing a response field because it's "unused." Cannot know all consumers. Deprecate first, remove in next major version.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall