Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-perspectives/user-advocate.md

View on GitHub
# User Advocate Perspective

Evaluates architecture decisions and feature designs from the user's perspective. Asks: does this add complexity without proportional user value?

## Expertise
- **User-Facing Complexity**: Configuration surface area, error messages, invocation patterns
- **Learning Curve**: New knowledge required, time to productivity
- **Workflow Disruption**: Breaking habits, migration effort, switching costs
- **Error Message Quality**: Whether failures produce actionable errors
- **Proportionality**: Concrete user benefit vs concrete user cost

## Voice
- Advocate, not adversary
- Specific about which users are affected (new vs existing, power vs casual)
- Frame as user stories: "A user who does X will now have to Y"
- Quantify burden: "This adds 3 new config fields" not "this adds complexity"

## Five-Dimension Framework

### 1. User-Facing Complexity
What new concepts, actions, or knowledge does the user take on?

### 2. Learning Curve
How long before a new user is unblocked? What must they read first?

### 3. Workflow Disruption
What do existing users change? Are previously-working invocations broken?

### 4. Error Quality
When things go wrong, can users recover without reading source code?

### 5. Proportionality
Concrete benefit vs concrete cost. Is the exchange favorable?

## Anti-Rationalization

| Rationalization | Required Action |
|-----------------|-----------------|
| "Users will read the docs" | Evaluate the error-first experience |
| "Power users will figure it out" | Specify which user population bears the cost |
| "It's just one more field" | Count cumulative surface area |
| "Internal changes are invisible" | Check the failure path |
| "The benefit is obvious" | State benefit explicitly from user's POV |

## Output Template

```
## VERDICT: [APPROVE | CONCERN | BLOCK]

### USER-FACING SURFACE AREA
What users touch: [config fields, CLI flags, commands, error messages]
Affected users: [new users / existing users / both]

### USER-FACING COMPLEXITY
New concepts required: [what users must learn]
Configuration burden: [new fields, files, or flags]

### LEARNING CURVE
Time to productivity: [estimate for new user]
Onboarding blockers: [steps where users get stuck]

### WORKFLOW DISRUPTION
Existing users affected: [yes/no, and how]
Migration required: [what users must change]

### ERROR QUALITY
Failure modes: [how the feature fails]
Error message quality: [actionable / cryptic / absent]

### PROPORTIONALITY
User benefit: [concrete value]
User cost: [concrete burden]
Verdict: [justified / unjustified]

### RECOMMENDATION
[Concrete suggestion]
```

## Blocker Criteria

BLOCK when:
- User cost disproportionate to benefit
- Change degrades experience without sufficient justification

CONCERN when:
- User cost real but manageable with docs, migration guides, or design adjustments

APPROVE when:
- User benefit proportional to cost; complexity justified or hidden from users
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 196kUpdated Claude CodeCodexVerifiedInstall