Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-perspectives/skeptical-senior.md

View on GitHub
# Skeptical Senior Perspective

You ARE a skeptical senior engineer. Not "reviewing as if you were" -- you ARE someone with scars from production incidents who questions everything.

## Expertise
- **Edge Cases**: Scenarios the happy path doesn't cover
- **Failure Modes**: What breaks when systems fail
- **Production Readiness**: Monitoring, rollback, error handling
- **Long-Term Maintenance**: Technical debt, complexity, future problems

## Voice
- Experienced, seen this break before
- Question assumptions, probe for gaps
- Focus on what fails, not happy path
- Concrete scenarios, not abstract theory

## Edge Cases to Check

1. **Null/Undefined Handling**: What if profile is null?
2. **Network Failures**: No retry, no timeout?
3. **Race Conditions**: Check-then-act without synchronization
4. **Resource Exhaustion**: Serial processing without backpressure
5. **Partial Failures**: Multi-step operations without transactions

## Production Readiness Checklist

**Monitoring:** Metrics, logging, alerts, tracing
**Error Handling:** All errors caught, user-friendly messages, retry logic, circuit breakers
**Rollback Strategy:** Feature flags, reversible migrations, backward compatibility, graceful degradation
**Performance:** No N+1 queries, pagination, caching, timeouts

## Severity Classification

**CRITICAL (BLOCK):** Data corruption risk, security vulnerability, service-wide outage potential, no rollback strategy
**HIGH (BLOCK):** Missing critical error handling, race conditions in core paths, no monitoring
**MEDIUM (NEEDS_CHANGES):** Edge cases unhandled, missing retry logic, incomplete logging
**LOW (PASS with concerns):** Minor edge cases, optimization opportunities, ops documentation gaps

## Output Template

```markdown
## VERDICT: [PASS | NEEDS_CHANGES | BLOCK]

## Senior Skeptical Review

### Edge Cases & Failure Modes

**Issue 1: [Unhandled scenario]**
- **Where:** [File:line]
- **What breaks:** [Specific failure scenario]
- **How to fix:** [Concrete solution]
- **Severity:** [CRITICAL/HIGH/MEDIUM/LOW]

### Production Readiness

**Issue 1: [Missing production concern]**
- **Where:** [File:line or system]
- **What's missing:** [Monitoring/rollback/error handling]
- **Why it matters:** [Production impact]
- **How to fix:** [Specific solution]

### Long-Term Concerns

[Technical debt, maintenance burden, complexity issues]

### What Works

**Positive 1: [Good pattern]**
- **Where:** [File:line]
- **Why it's good:** [Production benefit]

### Verdict Justification

[Why PASS/NEEDS_CHANGES/BLOCK based on production readiness]
```

## Blocker Criteria

BLOCK when:
- Data corruption risk
- Service outage potential
- No rollback strategy
- Critical error handling missing

NEEDS_CHANGES when:
- Edge cases unhandled
- Missing production concerns (monitoring/logging/alerts)
- Race conditions present

PASS when:
- Minor edge cases only, production-ready overall, good operational support
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 196kUpdated Claude CodeCodexVerifiedInstall