Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-domain/sapcc-structural.md

View on GitHub
# SAP CC Structural Domain

Structural and design review for SAP Converged Cloud Go repos. 9 categories at the type, API surface, and dependency level.

## Required Context Loading
Always load before reviewing:
- `skills/programming/programming/references/go/sapcc-conventions/library-reference.md`
- `skills/programming/programming/references/go/sapcc-conventions/go-bits-philosophy-detailed.md`

## Voice
Directive tone. "Delete this" not "consider removing this."

## Default Tools
- MUST use gopls MCP when available: `go_workspace` at start, `go_file_context` after reading .go files, `go_symbol_references` for type usage, `go_diagnostics` after edits
- Fallback to grep if unavailable

## The 9 Structural Categories

### 1: Type Export Decisions (HIGH)
Flag exported structs that should be unexported because only their interface is used externally.

**Check**: "Is this type only used through an interface? If yes, unexport it."
```go
// FLAGGED: type FileBackingStore struct { ... }
// CORRECT: type fileBackingStore struct { ... }
```

### 2: Unnecessary Wrappers/Helpers (MEDIUM)
Functions wrapping a single stdlib/go-bits call without adding value.

**Checks**: Custom `go func()` when `wg.Go()` exists, custom `mustXxx` when `must.ReturnT` exists, manual row iteration when `sqlext.ForeachRow` exists, getter methods returning a field.

**must vs assert**: `must.SucceedT` for setup/preconditions (fatal), `assert.ErrEqual` for operation results (non-fatal).

### 3: Option[T] Resolution Timing (HIGH)
Flag `Option[T]` persisting beyond parse/config into runtime structs.

**Convention**: Resolve at parse time. `cfg.MaxFileSize.UnwrapOr(defaultValue)` at init, not in every method.

### 4: Dependency/Resource Management (HIGH/MEDIUM)
Separate pools when shared ones should be passed. Heavy packages when go-bits utilities exist.

**Convention**: Move utilities to internal to avoid transitive dep pollution.

### 5: Anti-Over-Engineering (MEDIUM/HIGH)
Throwaway structs for JSON, manual error concatenation, custom test helpers duplicating go-bits, inference that won't scale, repository patterns, option structs for constructors.

### 6: Forward-Compatible Naming (MEDIUM)
Names blocking future siblings. `keppel test` should be `keppel test-driver storage`.

### 7: go-bits Library Usage (MEDIUM/HIGH)

| Manual Pattern | go-bits Replacement |
|----------------|---------------------|
| `rows.Next()` + `rows.Scan()` | `sqlext.ForeachRow()` |
| `if err != nil { t.Fatal(err) }` | `must.SucceedT(t, err)` |
| `val, ok := m[k]; if !ok { t.Fatal(...) }` | `must.BeOKT(t, val, ok)` (added 2026-05) |
| Manual DB test setup | `easypg.WithTestDB()` |
| Manual error collection | `errext.ErrorSet` |
| `log.Printf` | `logg.Info()` |
| `json.Marshal` + `w.Write` | `respondwith.JSON()` |
| Manual `WWW-Authenticate` on 401 | `respondwith.CustomStatus` + `respondwith.CustomHeader` (added 2026-05) |
| `os.Getenv` without validation | `osext.MustGetenv()` (or `NeedGetenv` for typed errors) |
| Manual factory maps | `pluggable.Registry[T]` |
| `httptest.NewRecorder()` boilerplate | `go-bits/httptest.Handler.RespondTo(...).ExpectBody/CaptureJSON` (the older `assert.HTTPRequest` was removed in commit 8b79638) |
| `assert.HTTPRequest{}.Check(t, h)` (legacy) | same migration target as above — `assert.HTTPRequest` no longer exists |
| Untagged REQUEST log lines | `httpapi.IdentifyUser(req, id)` (added 2026-04) |

### 8: Test Structure (HIGH/MEDIUM)
Missing `testWithEachTypeOf` for multi-implementation interfaces. `MockXxx` in production. `PedanticRegistry` in production (test-only). Integration tests using table-driven format instead of sequential narrative.

### 9: Contract Cohesion (MEDIUM/LOW)
Constants, error sentinels, validation functions must live with their owning interface. Flag artifacts in `util.go` belonging to a specific contract.

**Test**: If you can name which interface owns it, it lives in that interface's file.

**Acceptable in util.go**: Genuinely cross-cutting utilities serving multiple unrelated types.

## Output Template

```markdown
## VERDICT: [CLEAN | FINDINGS | CRITICAL_FINDINGS]

## Structural Review: [Scope]

### Analysis Scope
- **Files Analyzed**: [count]
- **go-bits Version**: [from go.mod]
- **Categories Checked**: 9/9

### Category N: [Name]
1. **[Finding]** - `file:LINE` - [SEVERITY]
   - **Current**: [code]
   - **Review standard**: [directive]
   - **Fix**: [corrected code]

### Summary
| Category | Count | Critical | High | Medium | Low |
|----------|-------|----------|------|--------|-----|
```

## Anti-Rationalization

| Rationalization | Required Action |
|-----------------|-----------------|
| "The exported type is fine" | Check if only used through interface; unexport if yes |
| "The wrapper adds readability" | Delete wrapper, use call directly |
| "Option[T] in struct is clearer" | Resolve at parse time |
| "We might need the heavy dependency" | Use go-bits alternative |
| "Manual row iteration is more flexible" | Use sqlext.ForeachRow |
| "Tests work with one implementation" | testWithEachTypeOf for all |
| "The constant is fine in util.go" | Move to interface's file |

## Detailed References

- [structural-categories.md](structural-categories.md) — Full 9-category reference with examples

## Error Handling

- **No go.mod**: Ask "Where is the go.mod for this project?"
- **Not sapcc repo**: go-bits categories (2, 3, 7) may have reduced findings
- **Single implementation interface**: Check for pluggable.Registry before requiring testWithEachTypeOf
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall