Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-domain/production-gaps.md

View on GitHub
# Production Gaps Catalog

Common production readiness gaps with solutions.

## Deployment and Rollback

### No Documented Rollback
**Symptoms**: No rollback docs, team assumes "revert commit," no automated triggers.

**Solution**:
```bash
deploy() {
    echo "To rollback: ./rollback.sh $(git rev-parse HEAD)"
}
rollback_to_commit() {
    git checkout $1 && docker-compose down && docker-compose up -d && ./health_check.sh
}
```
**Prevention**: Write rollback before deploy script. Test in staging. Automate triggers on health check failure.

### Missing Health Checks
**Symptoms**: Deployments complete but app broken. Load balancer sends traffic to unhealthy instances.

**Solution**:
```python
@app.route('/health')
def health_check():
    return {"status": "healthy", "timestamp": time.time()}
# Deploy: ./deploy.sh && curl http://localhost:8000/health || ./rollback.sh
```
**Prevention**: /health and /ready endpoints. Verify DB, cache, external APIs. Integrate with load balancers.

---

## Error Handling

### No Retry for External Calls
**Symptoms**: Transient failures cause complete request failure. No backoff or jitter.

**Solution**:
```python
def retry_with_backoff(func, max_retries=3, base_delay=1):
    for attempt in range(max_retries):
        try:
            return func()
        except TransientError as e:
            if attempt == max_retries - 1:
                raise
            delay = base_delay * (2 ** attempt) + random.uniform(0, 1)
            time.sleep(delay)
```
**Prevention**: Wrap all external calls. Exponential backoff with jitter. Circuit breakers. Log retries.

### Silent Background Failures
**Symptoms**: Background tasks fail without notification. Data processing silently stops.

**Solution**:
```python
def process_job(job_id):
    try:
        # job logic
        metrics.increment('jobs.success')
    except Exception as e:
        metrics.increment('jobs.failure')
        logger.error(f"Job {job_id} failed", exc_info=True)
        alert_on_call(f"Critical job failure: {job_id}")
        raise
```
**Prevention**: Emit success/failure metrics. Alert on failure rates. Dead letter queues.

---

## Observability

### No Structured Logging
**Symptoms**: Free-form strings, can't filter by correlation ID, grep through unstructured text.

**Solution**:
```python
# Before: logging.info(f"User {user_id} purchased item {item_id}")
# After:
logging.info("user_purchase", extra={
    'event_type': 'purchase', 'user_id': user_id,
    'item_id': item_id, 'correlation_id': request.correlation_id
})
```
**Prevention**: Structured logging libraries. Correlation IDs everywhere. Standard log fields. Queryable backend.

### Missing Critical Metrics
**Symptoms**: Cannot answer "how many requests failing?" No latency visibility.

**Solution**:
```python
request_count = Counter('api_requests_total', 'Total', ['endpoint', 'status'])
request_duration = Histogram('api_request_duration_seconds', 'Duration', ['endpoint'])
```
**Prevention**: Instrument all endpoints. Track resource usage. Monitor queues. Dashboards before production.

---

## Edge Cases

### No Input Validation
**Symptoms**: Crashes on empty/null/extreme input. Injection vulnerabilities.

**Solution**:
```python
def create_user(username, age):
    if not username or len(username) < 3:
        raise ValueError("Username must be at least 3 characters")
    if age < 0 or age > 150:
        raise ValueError("Invalid age")
```
**Prevention**: Validate at API boundaries. Schema validation (Pydantic, JSON Schema). Test edge cases. Sanitize input.

### Race Conditions
**Symptoms**: Occasional data corruption under load. Duplicate records.

**Solution**:
```python
class SafeCounter:
    def __init__(self):
        self._value = 0
        self._lock = threading.Lock()
    def increment(self):
        with self._lock:
            self._value += 1
        return self._value
```
**Prevention**: Identify shared mutable state. Locks or atomic ops. Test under load. DB constraints.

---

## Scalability

### No Query Optimization
**Symptoms**: Slow pages as data grows. DB CPU at 100%. N+1 queries.

**Solution**:
```sql
CREATE INDEX idx_users_email ON users(email);
-- N+1 fix: JOIN instead of separate queries
SELECT users.*, orders.* FROM users
JOIN orders ON users.id = orders.user_id WHERE users.id IN (1, 2, 3);
```
**Prevention**: Index frequently queried columns. EXPLAIN. Slow query logs. select_related/prefetch_related. Load test with production data.

### No Caching
**Symptoms**: Expensive computations repeated. DB overloaded with identical queries.

**Solution**:
```python
@lru_cache(maxsize=128)
def get_user_profile(user_id):
    return expensive_db_query(user_id)
```
**Prevention**: Cache with TTL. Invalidation strategy. Monitor hit rates. Distributed cache for multi-instance.

---

## Resource Management

### Resource Leaks
**Symptoms**: "Too many open files." Connection pool exhausted. Memory grows.

**Solution**:
```python
# Always use context managers
with open(filepath) as f:
    data = f.read()
```
**Prevention**: Context managers. Connection pool limits. Monitor file descriptors. finally blocks.

### No Rate Limiting
**Symptoms**: Single user overloads API. No DDoS protection.

**Solution**:
```python
@limiter.limit("10 per minute")
def expensive_operation():
    pass
```
**Prevention**: Per-user and per-IP limits. Rate limit expensive ops. 429 with Retry-After. Monitor hit counts.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 196kUpdated Claude CodeCodexVerifiedInstall