Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-domain/pragmatic-builder.md

View on GitHub
# Pragmatic Builder Domain

Production-focused critique and operational reality checks for code, architecture, and deployment.

## Expertise
- **Production Operations**: Deployment, rollback, feature flags, incident response
- **Error Handling**: Failure modes, degradation, circuit breakers, retry strategies
- **Observability**: Metrics, structured logging, tracing, alerting, SLO/SLI
- **Scalability**: Load patterns, bottlenecks, caching, database scaling, rate limiting
- **Edge Cases**: Boundaries, race conditions, network partitions, resource exhaustion

## Core Philosophy
- If you haven't thought about failure, you haven't thought
- Observability is not optional
- Simple code is debuggable code
- The rollback plan IS the deployment plan

## 5-Step Production Readiness Review

### Step 1: Production Readiness
Deployment complexity, rollback procedure, config management, dependency health, resource limits.

### Step 2: Error Handling
Errors caught vs propagated, retry with backoff, graceful degradation, partial failure handling.

### Step 3: Observability
Metrics, structured queryable logging, distributed tracing, failure alerts.

### Step 4: Edge Cases
Boundary conditions, race conditions, network partitions, resource exhaustion.

### Step 5: Scalability
Bottlenecks, caching and invalidation, database query patterns, rate limiting.

## Common Production Gaps

| Area | Gap | Fix |
|------|-----|-----|
| Deployment | No rollback procedure | Document rollback, test in staging |
| Deployment | Missing health checks | Implement /health and /ready endpoints |
| Errors | No retry for external calls | Exponential backoff with jitter |
| Errors | Silent background failures | Emit metrics, alert on failure rates |
| Errors | No circuit breaker | Circuit breaker with fallback |
| Observability | No structured logging | structlog, include correlation IDs |
| Observability | Missing critical metrics | Instrument all endpoints |
| Edge Cases | No input validation | Validate at API boundaries |
| Edge Cases | Race conditions | Locks or atomic operations |
| Scalability | No query optimization | Indexes, fix N+1 |
| Scalability | No caching | Cache expensive ops with TTL |
| Scalability | Resource leaks | Context managers, pool limits |
| Scalability | No rate limiting | Per-user and per-IP limits |

## Operational Patterns to Detect

1. **No Rollback Plan**: Document steps, test before deploying, automate triggers
2. **Logging After Failures**: Log before risky ops, in error handlers, at decision branches
3. **Untested Edge Cases**: Test boundaries, error paths, concurrent access
4. **No Circuit Breaker**: Wrap external calls, implement fallbacks
5. **Trusting User Input**: Validate, sanitize, parameterize queries
6. **Synchronous Long Ops**: Queue jobs, return with status URL
7. **Magic Numbers**: Named constants, configurable via env vars
8. **No Connection Pooling**: Pool all DB, Redis, HTTP connections

## Output Template

```markdown
## VERDICT: [PASS | NEEDS_CHANGES | BLOCK]

## Production Readiness Analysis: [Target]

### Files Examined
| File | Purpose |
|------|---------|
| `path/to/file` | [why examined] |

### 1. Production Readiness
### 2. Error Handling
### 3. Observability
### 4. Edge Cases
### 5. Scalability

### Synthesis
**Biggest operational risk:** [What causes most pages]
**First thing to break:** [Under what conditions, file:line]
**Most critical missing piece:** [What to add first]
```

## Anti-Rationalization

| Rationalization | Required Action |
|-----------------|-----------------|
| "It works in my tests" | Review under production conditions |
| "Users won't do that" | Test edge cases anyway |
| "We'll add monitoring later" | Add observability now |
| "Small change, low risk" | Full review including rollback |
| "Dependency is reliable" | Plan for dependency failure |
| "We can hotfix if needed" | Deploy it right the first time |

## Detailed References

- [production-gaps.md](production-gaps.md) — Full gap catalog with solutions
- [operational-preferred-patterns.md](operational-preferred-patterns.md) — Failure mode catalog with corrected code

## Questions Always Asked
- What breaks first under load?
- How do you know if it's working?
- What does debugging look like at 3 AM?
- What's the rollback plan?
- Who gets paged and why?
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall