Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-domain/edge-case-tables.md

View on GitHub
# Edge Case Tables

Systematic edge cases by data type for business logic review.

## Numeric Types

| Data Type | Edge Cases |
|-----------|-----------|
| Integers | 0, 1, -1, MAX_INT, MIN_INT, overflow, underflow |
| Floats | 0.0, -0.0, NaN, Infinity, -Infinity, precision loss, rounding |
| Decimals (money) | 0.00, negative, MAX_DECIMAL, rounding at 2 decimals |
| Percentages | 0%, 100%, >100%, negative, fractional |
| Counts | 0, 1, negative, fractional (if invalid) |

**Common Bugs**: Division by zero, integer truncation needing float, overflow unchecked, rounding compounding in loops, off-by-one in range checks.

## String Types

| Data Type | Edge Cases |
|-----------|-----------|
| Text | empty "", null, whitespace "   ", very long (>1MB), special chars, unicode |
| Names | empty, single char, unicode, trailing spaces, hyphens, apostrophes |
| Email | empty, invalid format, very long, unicode domains |
| URLs | empty, invalid scheme, localhost, very long, unicode |
| Passwords | empty, min/max length, special char requirements |

**Common Bugs**: Empty vs null conflation, whitespace not trimmed, length limits unenforced, unicode mishandled, SQL injection.

## Array/Collection Types

| Data Type | Edge Cases |
|-----------|-----------|
| Arrays | empty [], single [x], null elements, duplicates, very large (>10k) |
| Maps | empty, null keys, null values, key collisions |

**Common Bugs**: Index out of bounds on empty, null pointer on element access, loop assumes non-empty, O(n^2) on large sets, duplicate handling wrong.

## Date/Time Types

| Data Type | Edge Cases |
|-----------|-----------|
| Dates | null, epoch (1970-01-01), year 2038, leap years, Feb 29 |
| Times | midnight (00:00), null, DST transitions |
| Timestamps | null, epoch, future, past, timezone handling |
| Durations | 0 seconds, negative, overflow |
| Ranges | start = end, start > end, null start/end |

**Common Bugs**: DST 1-hour shifts, leap year logic wrong (2000 leap, 1900 not), timezone unspecified, date arithmetic wrong near boundaries, year 2038 overflow.

## Object/Struct Types

| Data Type | Edge Cases |
|-----------|-----------|
| Objects | null, empty {}, missing required fields, extra fields |
| Nested objects | null at any level, deeply nested (>10), circular references |
| Optional fields | null, undefined, missing entirely |
| Polymorphic types | all possible types, invalid type |

**Common Bugs**: Null pointer deref, missing field unhandled, extra fields failing validation, nested null unchecked, type assertion fails.

## File/Upload Types

| Data Type | Edge Cases |
|-----------|-----------|
| Files | missing, empty (0 bytes), very large (>100MB), wrong format, corrupt |
| Uploads | timeout mid-upload, duplicate filename, path traversal, malicious content |
| Paths | empty, null, relative, absolute, non-existent, symlinks |

**Common Bugs**: Missing file unchecked, large file not streamed, path traversal escape, permissions unchecked, temp files not cleaned.

## Boolean Types

| Data Type | Edge Cases |
|-----------|-----------|
| Booleans | true, false, null (tri-state), default value |
| Flags | unset (null) vs false, bitwise operations |

**Common Bugs**: Null treated as false (or true), default incorrect, bitwise logic inverted.

## State Machine Edge Cases

| State Type | Edge Cases |
|-----------|-----------|
| Status enum | all valid, invalid, null, case sensitivity |
| Transitions | all valid FROM->TO, invalid, concurrent changes |
| Terminal states | can't exit, proper cleanup |
| Error states | recovery path, retry, timeout |

**Common Bugs**: Invalid transition allowed, terminal escapable, concurrent race, error unrecoverable, state persisted before validation.

## Calculation Edge Cases

| Type | Edge Cases |
|------|-----------|
| Tax | 0%, 100%, fractional rates, compound, rounding |
| Discounts | 0%, 100%, >100% (invalid), stacking |
| Totals | sum of zeros, negatives, overflow, precision loss |
| Averages | divide by zero, all zeros, single value, rounding |

**Common Bugs**: Division by zero, wrong order of operations, rounding at wrong step, overflow unchecked, negative amounts unvalidated.

## Concurrent Access Edge Cases

| Pattern | Edge Cases |
|---------|-----------|
| Read-modify-write | race, lost update, stale read |
| Increment/decrement | race on counter, overflow |
| Check-then-act | state changed between check and act |
| Resource allocation | double-spend, over-allocation, deadlock |

**Common Bugs**: Check-then-act race, lost update, deadlock from lock ordering, double-spend, stale read after concurrent update.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall