Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-domain/adr-compliance.md

View on GitHub
# ADR Compliance Domain

Verify implementations match Architecture Decision Records: decision mapping, contradiction detection, scope creep analysis.

## Expertise
- **ADR Discovery**: Auto-discover from `adr/` and `.adr-session.json`
- **Decision Mapping**: Map each ADR decision point to implementation artifacts
- **Contradiction Detection**: Code contradicting ADR decisions
- **Scope Creep**: Implementation beyond ADR-authorized scope
- **Compliance Verification**: Systematic pass/fail ADR adherence

## Review Methodology

### Step 1: ADR Discovery
Scan `adr/` and `.adr-session.json`. Build decision registry mapping ADRs to decision points and scope boundaries.

### Step 2: Decision-to-Implementation Mapping
For each decision point: search for implementation evidence. Mark IMPLEMENTED / NOT IMPLEMENTED / PARTIALLY IMPLEMENTED / CONTRADICTED.

### Step 3: Contradiction Detection
Verify implementation matches ADR intent, not just keywords. Check subtle and partial contradictions.

### Step 4: Scope Creep Detection
Map every change to an authorizing ADR decision. Flag changes without ADR traceability.

### Step 5: Compile Verdict
Aggregate into ADR COMPLIANT / NOT ADR COMPLIANT.

## Severity Classification

- **CRITICAL**: ADR contradiction — implementation opposes a decision
- **HIGH**: Missing implementation — ADR decision has no corresponding code
- **MEDIUM**: Scope creep — changes outside ADR-authorized scope
- **LOW**: Minor drift — small deviations from ADR intent

## Output Template

```markdown
## VERDICT: [ADR COMPLIANT | NOT ADR COMPLIANT]

### ADRs Discovered

| ADR | Title | Decisions | Status |
|-----|-------|-----------|--------|
| ADR-NNN | [title] | [N decision points] | [COMPLIANT / VIOLATIONS FOUND] |

### Decision Coverage

| ADR | Decision Point | Implementation | Status |
|-----|---------------|----------------|--------|
| ADR-NNN | [decision text] | `path/to/file:LINE` | IMPLEMENTED |

### CRITICAL (ADR contradiction)
1. **[Finding]** - `file:42` contradicts ADR-NNN
   - **ADR Decision**: [Exact text]
   - **Implementation**: [What code does]
   - **Recommendation**: [How to align]

### HIGH (missing implementation)
### MEDIUM (scope creep)

### Scope Analysis

| Category | Count |
|----------|-------|
| ADR decisions mapped | N |
| Decisions implemented | N |
| Decisions contradicted | N |
| Changes outside ADR scope | N |
```

## Anti-Rationalization

| Rationalization | Required Action |
|-----------------|-----------------|
| "ADR is outdated" | Check compliance or flag for update |
| "Close enough to the ADR" | Report specific deviation |
| "ADR didn't anticipate this" | Flag as scope creep, recommend ADR update |
| "Everyone agreed to this change" | Report as unauthorized until ADR amended |
| "The spirit of the ADR is met" | Report gap, recommend clarification |

## Error Handling

- **No ADRs Found**: Report "No ADRs discovered." VERDICT: N/A
- **Ambiguous ADR Language**: Flag with both interpretations
- **ADR Conflicts**: Report as HIGH with both conflicting references
- **Superseded ADRs**: Check only against latest active ADR
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 196kUpdated Claude CodeCodexVerifiedInstall