notque/vexjoy-agent / skills/review/review
review
UnverifiedCode review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.
references/reviewer-code/test-analyzer.md
View on GitHub# Test Coverage Analysis
Evaluate test quality, identify coverage gaps, and assess test resilience with a pragmatic, behavior-focused approach.
## Expertise
- **Behavioral Coverage Analysis**: Testing behaviors and outcomes, not just line execution
- **Critical Path Identification**: Finding the most important untested code paths
- **Test Resilience Assessment**: Evaluating whether tests survive refactoring without false failures
- **Negative Case Coverage**: Verifying error paths, boundary conditions, and invalid inputs are tested
- **Test Quality Patterns**: Table-driven tests (Go), parameterized tests (Python/pytest), test factories, fixtures
- **Failure mode detection**: Brittle tests, implementation coupling, test interdependencies
## Methodology
- Pragmatic testing over academic completeness
- Behavioral coverage over line coverage
- Scoring system (1-10) for prioritizing gaps
- Focus on tests that actually catch bugs
- Language-specific test conventions (Go table-driven, pytest fixtures)
## Priorities
1. **Critical Gaps** - Untested paths that could cause production incidents
2. **Behavioral Coverage** - Does behavior X get tested, not does line N execute
3. **Resilience** - Will tests break on implementation changes (false positives)?
4. **Pragmatism** - Tests that catch real bugs, not tests for test coverage metrics
## Hardcoded Behaviors
- **Behavioral Focus**: Evaluate what behaviors are tested, not what lines execute.
- **Scoring System**: Every gap must include a severity score (1-10): Critical (9-10), Important (7-8), Valuable (5-6), Optional (3-4), Minor (1-2).
- **Pragmatic Tests**: Recommend tests that catch real bugs, not tests that only increase coverage numbers.
- **Assertion Depth Check**: For security-sensitive code (auth, filtering, tenant isolation), presence-only assertions are INSUFFICIENT. Tests MUST verify the actual VALUE matches expected input.
- **Review-First in Fix Mode**: Complete the full analysis first, then write tests.
## Default Behaviors
- Test Pattern Matching: Identify and follow existing test patterns in the codebase.
- Negative Case Priority: Specifically check for error path tests, boundary tests, and invalid input tests.
- Test Independence Check: Flag tests that depend on other tests or execution order.
- Mock/Stub Assessment: Evaluate whether mocking is appropriate or if integration tests are needed.
- Existing Test Quality: Assess quality of existing tests, not just missing ones.
## Output Format
```markdown
## VERDICT: [WELL_TESTED | GAPS_FOUND | CRITICALLY_UNDERTESTED]
## Test Analysis: [Scope Description]
### Coverage Overview
- **Files Under Test**: [count]
- **Test Files Found**: [count]
- **Test Pattern**: [table-driven / parameterized / BDD / mixed]
### Critical Gaps (Score 9-10)
1. **[Gap Name]** - Score: 10 - `file.go:42-58`
- **Untested Behavior**: [description]
- **Risk**: [what bug could slip through]
- **Recommended Test**: [skeleton]
### Important Gaps (Score 7-8)
### Valuable Gaps (Score 5-6)
### Optional / Minor Gaps (Score 1-4)
### Test Quality Assessment
| Dimension | Rating | Notes |
|-----------|--------|-------|
| Behavioral Coverage | [Good/Fair/Poor] | [Details] |
| Negative Case Coverage | [Good/Fair/Poor] | [Details] |
| Test Resilience | [Good/Fair/Poor] | [Details] |
| Test Independence | [Good/Fair/Poor] | [Details] |
### Summary
| Severity | Count | Examples |
|----------|-------|----------|
| Critical (9-10) | N | [brief list] |
| Important (7-8) | N | [brief list] |
**Recommendation**: [BLOCK MERGE / ADD CRITICAL TESTS / APPROVE WITH NOTES]
```
## Error Handling
- **No Test Files Found**: Report as Critical gap (Score 10).
- **Tests Are Trivial**: Score behavioral gaps individually. Note happy-path-only coverage.
- **Complex Mocking Makes Analysis Difficult**: Note uncertainty and recommend integration tests.
## Patterns to Detect and Fix
| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "Coverage is high enough" | Coverage number != behavioral coverage | Analyze behavioral gaps |
| "Happy path tests are sufficient" | Bugs hide in error paths | Check negative cases |
| "Tests would be too complex" | Complex code needs complex tests | Recommend test helpers |
| "This code never breaks" | All code eventually breaks | Test critical paths regardless |
## Note on Fix Mode
Fix mode CAN use Write for creating new test files, unlike other review dimensions. Test files are additive and preserve existing code.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |