notque/vexjoy-agent / skills/review/review
review
UnverifiedCode review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.
references/reviewer-code/simplifier.md
View on GitHub# Code Simplification
Reduce complexity and improve code clarity while preserving exact functionality. Unlike read-only reviewers, this dimension actively modifies code as simplification is inherently a modification task.
## Expertise
- **Complexity Reduction**: Cyclomatic complexity, nesting depth, cognitive load analysis
- **Clarity Patterns**: Explicit control flow, clear naming, readable structure
- **Refactoring Techniques**: Extract function, flatten conditionals, simplify expressions, guard clauses
- **Language Idioms**: Go, Python, TypeScript, JavaScript idiomatic simplification
- **Behavior Preservation**: Ensuring refactored code produces identical results
## Methodology
- Clarity over brevity: readable code beats clever code
- No nested ternaries: use explicit if/else
- Guard clauses over deep nesting
- Early returns to reduce indentation
- CLAUDE.md standards as simplification guide
- One simplification at a time with verification
## Priorities
1. **Preserve Behavior** - Exact same functionality after simplification
2. **Reduce Cognitive Load** - Lower nesting, clearer flow, better names
3. **Follow Conventions** - CLAUDE.md and language idioms guide structure
4. **Verify** - Run tests after each simplification to confirm correctness
## Hardcoded Behaviors
- **Behavior Preservation**: Every simplification must preserve exact functionality. No behavioral changes allowed.
- **Test Verification**: Run existing tests after simplification. If tests fail, revert the change.
- **Default Scope**: When no files are specified, simplify recently modified code (files in `git diff --name-only`).
- **No Nested Ternaries**: Replace all nested ternary expressions with explicit if/else.
- **Explicit Over Implicit**: Prefer explicit control flow over clever constructs.
- **One Change at a Time**: Apply simplifications incrementally, verifying each before proceeding.
## Default Behaviors
- Show before/after code comparisons
- Guard Clauses: Convert deep nesting to early returns
- Extract Functions: Extract complex inline logic into named functions when it improves readability
- Flatten Conditionals: Reduce nesting depth by inverting conditions and returning early
- Naming Improvements: Suggest better variable/function names when current names obscure intent
- Remove Dead Code: Remove unreachable code, unused variables, commented-out code blocks
## Output Format
```markdown
## Code Simplification: [Scope Description]
### Scope
- **Source**: [git diff / specific files]
- **Files Analyzed**: [count]
### Simplifications Applied
#### 1. [Simplification Name] - `file.go:42-58`
**Before**: [code]
**After**: [code]
**Why**: [Explanation of clarity improvement]
**Complexity Change**: [metric]
### Summary
| Metric | Before | After |
|--------|--------|-------|
| Files Modified | - | N |
| Simplifications Applied | - | N |
| Max Nesting Depth | N | M |
### Verification
- **Tests Run**: [yes/no]
- **Tests Passed**: [yes/no]
- **Behavior Changed**: NO (verified)
```
## Error Handling
- **Tests Fail After Simplification**: Immediately revert. Report the simplification caused test failure.
- **Complex Code Is Complex for a Reason**: Report complexity but note business rules resist simplification.
- **No Recent Changes**: Ask user which files to simplify.
## Patterns to Detect and Fix
| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "Shorter is simpler" | Brevity != clarity | Optimize for readability |
| "Tests still pass" | Tests may not cover changed behavior | Verify test coverage of modified paths |
| "It's just a refactor" | Refactors can change behavior | Run tests after every change |
| "The original was bad" | Bad doesn't justify risky changes | Incremental improvement with verification |
## Blocker Criteria
- No tests exist for target code
- Complex business logic encoding
- Multiple valid simplification approaches (pick one, record why in the finding, and ask Jev only when genuinely unsure)
- Simplification changes public API
## Abstraction Boundary Patterns
Patterns where unnecessary complexity can be removed while preserving behavior. See `skills/programming/programming/references/go/preferred-patterns/code-examples.md` AP-8 for full before/after examples.
### Detection Signals
| Signal | Grep / Structural Check | Simplification |
|--------|------------------------|----------------|
| Defensive copy on fresh slice | `make([]T, len(x)+N)` + `copy(result, x)` where x is freshly allocated | Replace with `append(x, element)` |
| Coupling comment | `grep -rn "must be called after\|must always follow\|INVARIANT.*call" --include="*.go"` | Merge the "always follows" logic into the prerequisite function |
| Same-pair call pattern | `helperB(result)` appears after every `result := functionA()` call site | Move `helperB` logic inside `functionA` |
### Coupling Comment Fix
When a comment says "must be called after X", the fix is to move that logic inside X. The comment documents a coupling that code structure should eliminate.
```go
// Before: Comment documents what code should enforce
labelKey, vals := scopeToLabel(req, ks)
vals = appendSentinel(vals) // forget this = silent bug
// After: Coupling eliminated — impossible to forget
labelKey, vals := scopeToLabel(req, ks) // sentinel included automatically
```
**Origin**: PR #220 — Stefan Majewsky.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |