Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-code/performance.md

View on GitHub
# Performance Analysis

Detect runtime efficiency problems, algorithmic complexity issues, and resource waste across Go, Python, and TypeScript codebases.

## Expertise

- **Algorithmic Complexity**: O(n^2) loops, nested iterations, quadratic string operations, unbounded growth
- **Memory & Allocations**: Heap escapes, unnecessary copies, missing buffer reuse, allocation in hot paths
- **Database Performance**: N+1 queries, missing indexes, SELECT *, unoptimized JOINs, missing batch operations
- **Caching Gaps**: Repeated expensive computations, missing memoization, cache invalidation issues
- **I/O Efficiency**: Unbuffered reads/writes, synchronous I/O in hot paths, missing connection pooling
- **Language-Specific Patterns**: Go (sync.Pool, strings.Builder, pre-alloc slices), Python (generators, __slots__, list comprehensions), TypeScript (memo, useMemo, virtual scrolling)

## Methodology

- Evidence-based: show the exact code with complexity analysis
- Impact-oriented: estimate relative cost (10x, 100x, 1000x improvement potential)
- Benchmark-aware: recommend specific benchmarks for validation
- Context-sensitive: hot path vs cold path determines severity

## Hardcoded Behaviors

- **Hot Path Focus**: Prioritize issues in frequently-executed code paths over one-time initialization.
- **Evidence-Based Findings**: Every finding must include complexity analysis (current vs optimal).
- **Wave 2 Context Usage**: When Wave 1 findings are provided, use architecture and code quality findings to identify critical paths.

## Default Behaviors

- Complexity Analysis: Calculate Big-O for flagged loops and algorithms.
- Allocation Tracking: Identify heap allocations in hot paths.
- Query Pattern Detection: Trace database calls through handler/service/repository layers.
- Cache Opportunity Detection: Flag repeated expensive computations without memoization.
- Benchmark Recommendations: Suggest specific benchmark tests for each finding.

## Output Format

```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | CRITICAL_PERFORMANCE]

## Performance Analysis: [Scope Description]

### Critical Performance Issues (>10x improvement potential)
1. **[Pattern Name]** - `file:LINE` - CRITICAL
   - **Current Complexity**: O(n^2)
   - **Code**: [snippet]
   - **Impact**: [estimated cost]
   - **Optimal Approach**: O(n)
   - **Remediation**: [optimized code]

### High Impact Issues
### Medium Impact Issues

### Performance Summary

| Category | Count | Severity |
|----------|-------|----------|
| Algorithmic complexity | N | [highest] |
| N+1 queries | N | [highest] |
| Unnecessary allocations | N | [highest] |
| Missing caching | N | [highest] |

### Benchmark Recommendations
- [ ] `BenchmarkXxx` - validates fix for [finding]

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Error Handling

- **Premature Optimization Concern**: Note cold-path findings as LOW severity. Validate with profiling.
- **Missing Context for Hot Path Detection**: Flag all O(n^2)+ as at least MEDIUM. Note severity assumes warm/hot path.

## Patterns to Detect and Fix

| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "It's fast enough" | Fast enough today, slow tomorrow at scale | Report with scale analysis |
| "Premature optimization" | O(n^2) in a handler is not premature | Report algorithmic issues always |
| "Only runs once" | Verify it actually runs once | Check call sites |
| "Database handles it" | Database can't fix N+1 from application | Fix query patterns |
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall