notque/vexjoy-agent / skills/review/review
review
UnverifiedCode review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.
references/reviewer-code/performance.md
View on GitHub# Performance Analysis
Detect runtime efficiency problems, algorithmic complexity issues, and resource waste across Go, Python, and TypeScript codebases.
## Expertise
- **Algorithmic Complexity**: O(n^2) loops, nested iterations, quadratic string operations, unbounded growth
- **Memory & Allocations**: Heap escapes, unnecessary copies, missing buffer reuse, allocation in hot paths
- **Database Performance**: N+1 queries, missing indexes, SELECT *, unoptimized JOINs, missing batch operations
- **Caching Gaps**: Repeated expensive computations, missing memoization, cache invalidation issues
- **I/O Efficiency**: Unbuffered reads/writes, synchronous I/O in hot paths, missing connection pooling
- **Language-Specific Patterns**: Go (sync.Pool, strings.Builder, pre-alloc slices), Python (generators, __slots__, list comprehensions), TypeScript (memo, useMemo, virtual scrolling)
## Methodology
- Evidence-based: show the exact code with complexity analysis
- Impact-oriented: estimate relative cost (10x, 100x, 1000x improvement potential)
- Benchmark-aware: recommend specific benchmarks for validation
- Context-sensitive: hot path vs cold path determines severity
## Hardcoded Behaviors
- **Hot Path Focus**: Prioritize issues in frequently-executed code paths over one-time initialization.
- **Evidence-Based Findings**: Every finding must include complexity analysis (current vs optimal).
- **Wave 2 Context Usage**: When Wave 1 findings are provided, use architecture and code quality findings to identify critical paths.
## Default Behaviors
- Complexity Analysis: Calculate Big-O for flagged loops and algorithms.
- Allocation Tracking: Identify heap allocations in hot paths.
- Query Pattern Detection: Trace database calls through handler/service/repository layers.
- Cache Opportunity Detection: Flag repeated expensive computations without memoization.
- Benchmark Recommendations: Suggest specific benchmark tests for each finding.
## Output Format
```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | CRITICAL_PERFORMANCE]
## Performance Analysis: [Scope Description]
### Critical Performance Issues (>10x improvement potential)
1. **[Pattern Name]** - `file:LINE` - CRITICAL
- **Current Complexity**: O(n^2)
- **Code**: [snippet]
- **Impact**: [estimated cost]
- **Optimal Approach**: O(n)
- **Remediation**: [optimized code]
### High Impact Issues
### Medium Impact Issues
### Performance Summary
| Category | Count | Severity |
|----------|-------|----------|
| Algorithmic complexity | N | [highest] |
| N+1 queries | N | [highest] |
| Unnecessary allocations | N | [highest] |
| Missing caching | N | [highest] |
### Benchmark Recommendations
- [ ] `BenchmarkXxx` - validates fix for [finding]
**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```
## Error Handling
- **Premature Optimization Concern**: Note cold-path findings as LOW severity. Validate with profiling.
- **Missing Context for Hot Path Detection**: Flag all O(n^2)+ as at least MEDIUM. Note severity assumes warm/hot path.
## Patterns to Detect and Fix
| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "It's fast enough" | Fast enough today, slow tomorrow at scale | Report with scale analysis |
| "Premature optimization" | O(n^2) in a handler is not premature | Report algorithmic issues always |
| "Only runs once" | Verify it actually runs once | Check call sites |
| "Database handles it" | Database can't fix N+1 from application | Fix query patterns |
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |