notque/vexjoy-agent / skills/review/review
review
UnverifiedCode review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.
references/reviewer-code/naming.md
View on GitHub# Naming Consistency
Detect naming convention drift, inconsistent identifier casing, and terminology misalignment across codebases.
## Expertise
- **Identifier Casing**: camelCase, PascalCase, snake_case, SCREAMING_SNAKE_CASE consistency
- **Acronym Casing**: ID vs Id, HTTP vs Http, URL vs Url, API vs Api
- **Verb Consistency**: Get vs Fetch vs Retrieve, Create vs Add vs New, Delete vs Remove
- **Package/Module Naming**: Go (lowercase, single word), Python (snake_case), TypeScript (kebab-case)
- **File Naming**: Consistent patterns within a project (snake_case.go, kebab-case.ts)
- **Domain Term Consistency**: Same concept = same name everywhere (user vs account vs member)
## Methodology
- Establish the dominant convention first, then flag deviations
- Language conventions take precedence over personal preference
- Consistency within a codebase matters more than any specific convention
- Acronyms follow language-specific rules (Go: ID, HTTP; TypeScript: id, http depends on context)
- Same concept should have same name everywhere in the codebase
## Hardcoded Behaviors
- **Convention Discovery**: Establish dominant conventions BEFORE flagging deviations.
- **Structured Output**: All findings must use the Naming Consistency Schema.
- **Evidence-Based Findings**: Every finding must show the inconsistent name AND the established convention.
- **Wave 2 Context Usage**: When Wave 1 findings are provided, use code-quality and language-specialist findings for baselines.
## Default Behaviors
- Convention Discovery: Scan codebase to determine dominant naming patterns.
- Acronym Audit: Check all acronyms for consistent casing.
- Verb Alignment: Check CRUD operation verbs for consistency.
- Package Naming: Verify package names follow language conventions.
- File Naming: Check file names for consistent patterns.
- Domain Term Audit: Verify same concepts use same terminology.
## Output Format
```markdown
## VERDICT: [CONSISTENT | DRIFT_FOUND | SIGNIFICANT_DRIFT]
## Naming Consistency Analysis: [Scope Description]
### Established Conventions
| Category | Convention | Examples | Adherence |
|----------|-----------|----------|-----------|
| Variables | camelCase | `userEmail`, `orderCount` | 95% |
| Types | PascalCase | `UserService`, `OrderHandler` | 98% |
| Acronyms | [ID/Http/URL] | `userID`, `httpClient` | 85% |
### Naming Inconsistencies
1. **Acronym Casing Drift** - MEDIUM
- **Convention**: `ID` (uppercase, 47 occurrences)
- **Violations**: [list with file:line]
### Naming Summary
| Category | Violations | Total Scanned | Adherence |
|----------|-----------|---------------|-----------|
**Recommendation**: [FIX BEFORE MERGE / APPROVE WITH CLEANUP / APPROVE]
```
## Error Handling
- **Multiple Valid Conventions**: Note intentional context differences (DB columns vs Go fields).
- **Generated Code**: Skip generated files (protobuf, openapi) in naming audit.
## Patterns to Detect and Fix
| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "Both are valid" | Valid != consistent | Pick one, flag deviations |
| "Nobody notices" | Inconsistency causes subtle bugs | Report for consistency |
| "Too many to fix" | Fix incrementally | Report all, fix in scope |
| "It's just style" | Inconsistent style is cognitive load | Reduce load with consistency |
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |