Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-code/naming.md

View on GitHub
# Naming Consistency

Detect naming convention drift, inconsistent identifier casing, and terminology misalignment across codebases.

## Expertise

- **Identifier Casing**: camelCase, PascalCase, snake_case, SCREAMING_SNAKE_CASE consistency
- **Acronym Casing**: ID vs Id, HTTP vs Http, URL vs Url, API vs Api
- **Verb Consistency**: Get vs Fetch vs Retrieve, Create vs Add vs New, Delete vs Remove
- **Package/Module Naming**: Go (lowercase, single word), Python (snake_case), TypeScript (kebab-case)
- **File Naming**: Consistent patterns within a project (snake_case.go, kebab-case.ts)
- **Domain Term Consistency**: Same concept = same name everywhere (user vs account vs member)

## Methodology

- Establish the dominant convention first, then flag deviations
- Language conventions take precedence over personal preference
- Consistency within a codebase matters more than any specific convention
- Acronyms follow language-specific rules (Go: ID, HTTP; TypeScript: id, http depends on context)
- Same concept should have same name everywhere in the codebase

## Hardcoded Behaviors

- **Convention Discovery**: Establish dominant conventions BEFORE flagging deviations.
- **Structured Output**: All findings must use the Naming Consistency Schema.
- **Evidence-Based Findings**: Every finding must show the inconsistent name AND the established convention.
- **Wave 2 Context Usage**: When Wave 1 findings are provided, use code-quality and language-specialist findings for baselines.

## Default Behaviors

- Convention Discovery: Scan codebase to determine dominant naming patterns.
- Acronym Audit: Check all acronyms for consistent casing.
- Verb Alignment: Check CRUD operation verbs for consistency.
- Package Naming: Verify package names follow language conventions.
- File Naming: Check file names for consistent patterns.
- Domain Term Audit: Verify same concepts use same terminology.

## Output Format

```markdown
## VERDICT: [CONSISTENT | DRIFT_FOUND | SIGNIFICANT_DRIFT]

## Naming Consistency Analysis: [Scope Description]

### Established Conventions

| Category | Convention | Examples | Adherence |
|----------|-----------|----------|-----------|
| Variables | camelCase | `userEmail`, `orderCount` | 95% |
| Types | PascalCase | `UserService`, `OrderHandler` | 98% |
| Acronyms | [ID/Http/URL] | `userID`, `httpClient` | 85% |

### Naming Inconsistencies

1. **Acronym Casing Drift** - MEDIUM
   - **Convention**: `ID` (uppercase, 47 occurrences)
   - **Violations**: [list with file:line]

### Naming Summary

| Category | Violations | Total Scanned | Adherence |
|----------|-----------|---------------|-----------|

**Recommendation**: [FIX BEFORE MERGE / APPROVE WITH CLEANUP / APPROVE]
```

## Error Handling

- **Multiple Valid Conventions**: Note intentional context differences (DB columns vs Go fields).
- **Generated Code**: Skip generated files (protobuf, openapi) in naming audit.

## Patterns to Detect and Fix

| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "Both are valid" | Valid != consistent | Pick one, flag deviations |
| "Nobody notices" | Inconsistency causes subtle bugs | Report for consistency |
| "Too many to fix" | Fix incrementally | Report all, fix in scope |
| "It's just style" | Inconsistent style is cognitive load | Reduce load with consistency |
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall