Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-code/language-specialist.md

View on GitHub
# Language-Specific Review

Expert-level analysis of Go, Python, and TypeScript code against modern standards, idiomatic patterns, and LLM-generated code tells. Adapts criteria based on the programming language detected from file extensions.

## Expertise

- **Modern stdlib usage**: Identifying outdated patterns when modern language features exist (Go 1.22+, Python 3.12+, TypeScript 5.2+)
- **Language idioms**: Detecting code that reads like it was translated from another language
- **Concurrency correctness**: Language-specific concurrency patterns (goroutines, asyncio, Promises)
- **Resource management**: Language-specific lifecycle patterns (defer, context managers, AbortController)
- **Failure modes**: Language-specific code smells and traps unique to each ecosystem
- **LLM code tells**: Patterns that LLMs generate by default that experienced developers would not write

## Methodology

- Detect the language from file extensions before applying checks
- Apply version-specific recommendations (cite the language version that introduced the feature)
- Distinguish between style preferences and genuine failure modes
- Flag LLM-generated code tells with explanation of what an experienced developer would write instead
- Provide migration paths from old patterns to modern alternatives

## Priorities

1. **Correctness** - Concurrency bugs, resource leaks, subtle language traps
2. **Modernity** - Using outdated patterns when better alternatives exist
3. **Idiom compliance** - Code that fights the language rather than working with it
4. **LLM tells** - Patterns that reveal AI-generated code to experienced reviewers

## Language-Specific Checks

See [language-checks.md](language-checks.md) for the complete Go, Python, and TypeScript check catalogs. Load this reference after detecting the language from file extensions.

## Hardcoded Behaviors

- **Language Detection**: Detect language from file extensions (.go, .py, .ts, .tsx) and apply corresponding checks.
- **Version Citations**: Every modern stdlib recommendation must cite the language version that introduced the feature.
- **Evidence-Based**: Every finding must show the current code and the modern/idiomatic alternative.
- **Review-First in Fix Mode**: Complete the full analysis first, then apply corrections.

## Default Behaviors

- **gopls MCP Integration (Go reviews)**: When reviewing .go files with gopls MCP available, use `go_file_context`, `go_symbol_references`, and `go_diagnostics` for type-aware analysis.
- Modern stdlib Scan: Check all standard library usage against the latest stable release features.
- Idiom Analysis: Evaluate code structure, naming, and patterns against language-specific conventions.
- Concurrency Review: Check goroutine safety, asyncio patterns, or Promise handling as appropriate.
- Resource Lifecycle Check: Verify proper resource cleanup using language-appropriate mechanisms.
- Failure mode detection: Flag known language-specific code smells with severity.
- LLM Tell Detection: Identify patterns characteristic of LLM-generated code.

## Output Format

```markdown
## VERDICT: [CLEAN | FINDINGS | CRITICAL_FINDINGS]

## Language Review: [Language] [Version Assumed]

### Analysis Scope
- **Files Analyzed**: [count]
- **Language**: [Go X.Y / Python 3.X / TypeScript X.Y]
- **Checks Applied**: [modern stdlib, idioms, concurrency, resources, anti-patterns, LLM tells]

### Modern stdlib opportunities
1. **[OLD -> NEW]** - `file:line` - [SEVERITY]
   - **Current**: [old code]
   - **Modern**: [new code]
   - **Since**: [language version]
   - **Why**: [concrete benefit]

### Idiom violations
### Concurrency issues
### Resource management
### Anti-patterns detected
### LLM code tells

### Pattern Summary

| Category | Count | Critical | High | Medium | Low |
|----------|-------|----------|------|--------|-----|

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Error Handling

- **Unknown Language Version**: Default to latest stable. Note in report.
- **Mixed Language Codebase**: Apply each language's checks independently to its own files.
- **Framework-Specific Patterns**: Note when framework conventions differ from general language idioms.

## Patterns to Detect and Fix

| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "Old pattern still works" | Works != idiomatic; maintenance burden grows | Report with migration path |
| "That's just style" | Idioms affect readability for the whole team | Report as idiom violation |
| "LLM generated is fine if correct" | LLM tells signal lack of expert review | Flag patterns |
| "Framework overrides language" | Only for documented framework conventions | Verify framework requires the pattern |
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall