Skip to content

notque/vexjoy-agent / skills/review/review

Code review: systematic single-file, parallel multi-reviewer, full-repo audit, PR diff review.

FileKindSize
SKILL.mdskill md11.7 KB
references/architecture-smell-baseline.mdmarkdown6.8 KB
references/audit-playbook.mdmarkdown10.2 KB
references/disprove-pass.mdmarkdown2.3 KB
references/go-review-patterns.mdmarkdown4.0 KB
references/receiving-feedback.mdmarkdown3.0 KB
references/report-template.mdmarkdown1.9 KB
references/reviewer-code.mdmarkdown6.2 KB
references/reviewer-code/code-quality.mdmarkdown4.6 KB
references/reviewer-code/comments.mdmarkdown3.6 KB
references/reviewer-code/config-safety.mdmarkdown3.7 KB
references/reviewer-code/dead-code.mdmarkdown3.2 KB
references/reviewer-code/language-checks.mdmarkdown6.7 KB
references/reviewer-code/language-specialist.mdmarkdown4.7 KB
references/reviewer-code/naming.mdmarkdown3.3 KB
references/reviewer-code/performance.mdmarkdown3.5 KB
references/reviewer-code/simplifier.mdmarkdown5.3 KB
references/reviewer-code/test-analyzer.mdmarkdown4.5 KB
references/reviewer-code/type-design.mdmarkdown4.0 KB
references/reviewer-domain.mdmarkdown9.1 KB
references/reviewer-domain/adr-compliance.mdmarkdown3.0 KB
references/reviewer-domain/business-logic.mdmarkdown4.6 KB
references/reviewer-domain/common-bugs.mdmarkdown6.7 KB
references/reviewer-domain/edge-case-tables.mdmarkdown4.5 KB
references/reviewer-domain/operational-preferred-patterns.mdmarkdown7.2 KB
references/reviewer-domain/pragmatic-builder.mdmarkdown4.2 KB
references/reviewer-domain/production-gaps.mdmarkdown5.3 KB
references/reviewer-domain/sapcc-structural.mdmarkdown5.4 KB
references/reviewer-domain/state-machine-verification.mdmarkdown5.2 KB
references/reviewer-domain/structural-categories.mdmarkdown5.8 KB
references/reviewer-perspectives.mdmarkdown8.0 KB
references/reviewer-perspectives/clarity-and-assumption-detection.mdmarkdown4.8 KB
references/reviewer-perspectives/code-review-detection.mdmarkdown4.4 KB
references/reviewer-perspectives/contrarian.mdmarkdown2.3 KB
references/reviewer-perspectives/meta-process.mdmarkdown2.7 KB
references/reviewer-perspectives/newcomer.mdmarkdown2.0 KB
references/reviewer-perspectives/pedant.mdmarkdown3.3 KB
references/reviewer-perspectives/review-detection-commands.mdmarkdown8.7 KB
references/reviewer-perspectives/skeptical-senior.mdmarkdown2.9 KB
references/reviewer-perspectives/user-advocate.mdmarkdown2.9 KB
references/reviewer-system.mdmarkdown14.0 KB
references/reviewer-system/api-contract.mdmarkdown3.4 KB
references/reviewer-system/compliance-checklists.mdmarkdown5.1 KB
references/reviewer-system/concurrency.mdmarkdown3.6 KB
references/reviewer-system/dependency-audit.mdmarkdown3.3 KB
references/reviewer-system/docs-validator.mdmarkdown4.0 KB
references/reviewer-system/error-messages.mdmarkdown3.1 KB
references/reviewer-system/financial-resilience-de-eu.mdmarkdown5.3 KB
references/reviewer-system/german-it-security.mdmarkdown10.7 KB
references/reviewer-system/industry-specific-compliance.mdmarkdown3.5 KB
references/reviewer-system/migration-safety.mdmarkdown3.3 KB
references/reviewer-system/observability.mdmarkdown3.1 KB
references/reviewer-system/security-authz.mdmarkdown9.0 KB
references/reviewer-system/security-ci-cd.mdmarkdown7.6 KB
references/reviewer-system/security-data-exfil.mdmarkdown9.5 KB
references/reviewer-system/security-finding-template.mdmarkdown3.0 KB
references/reviewer-system/security-injection.mdmarkdown6.3 KB
references/reviewer-system/security-pii.mdmarkdown7.3 KB
references/reviewer-system/security.mdmarkdown3.6 KB
references/reviewer-system/silent-failures.mdmarkdown3.6 KB
references/reviewer-system/sovereign-cloud-data-residency.mdmarkdown6.6 KB
references/reviewer-system/stride-threat-model.mdmarkdown3.2 KB

references/reviewer-code/config-safety.md

View on GitHub
# Configuration Safety

Detect hardcoded secrets, missing environment variable validation, unsafe defaults, and configuration management gaps.

## Expertise

- **Secret Detection**: API keys, passwords, tokens, connection strings, certificates in source code
- **Environment Variable Hygiene**: Missing validation, empty string defaults, runtime vs startup validation
- **Unsafe Defaults**: Debug mode enabled, TLS disabled, localhost as production default, verbose logging
- **Configuration Management**: Environment-specific config, 12-factor app compliance, secret management
- **Fail-Fast Validation**: Required config validated at startup, not at first use
- **Language-Specific Patterns**: Go (os.Getenv, envconfig), Python (os.environ, pydantic-settings), TypeScript (process.env, dotenv)

## Methodology

- Never store secrets in source code
- Validate all environment variables at startup, fail fast for required ones
- Defaults must be production-safe (no localhost, no debug mode, TLS enabled)
- Configuration should be documented (which vars, what they do, what's required)
- Sensitive config must not appear in logs or error messages

## Hardcoded Behaviors

- **Secret Detection Zero Tolerance**: Any secret, key, or credential in source code is CRITICAL.
- **Evidence-Based Findings**: Every finding must show the exact hardcoded value or missing validation.
- **Wave 2 Context Usage**: When Wave 1 findings are provided, use security and docs findings.

## Default Behaviors

- Secret Scanning: Scan for API keys, passwords, tokens, connection strings in source.
- Env Var Validation: Check all env var reads for validation and safe defaults.
- Unsafe Default Detection: Flag debug mode, TLS disabled, localhost defaults.
- Fail-Fast Check: Verify required config is validated at startup.
- Log Exposure Check: Verify secrets don't appear in log statements.

## Output Format

```markdown
## VERDICT: [CLEAN | ISSUES_FOUND | SECRETS_EXPOSED]

## Configuration Safety Analysis: [Scope Description]

### Secrets in Source Code
1. **[Secret Type]** - `file:LINE` - CRITICAL
   - **Pattern**: `apiKey = "sk-..."` (redacted)
   - **Risk**: [what an attacker could do]
   - **Remediation**: Move to environment variable, rotate the exposed secret

### Missing Validation
1. **[Env Var]** - `file:LINE` - HIGH
   - **Current**: [code with no validation]
   - **Risk**: Empty string causes runtime failure
   - **Remediation**: [code with validation]

### Unsafe Defaults
1. **[Default]** - `file:LINE` - HIGH
   - **Current**: [unsafe default]
   - **Risk**: [production impact]
   - **Remediation**: [safe default]

### Configuration Documentation Gaps

### Config Safety Summary

| Category | Count | Severity |
|----------|-------|----------|
| Secrets in source | N | CRITICAL |
| Missing validation | N | HIGH |
| Unsafe defaults | N | HIGH |
| Log exposure | N | HIGH |

**Recommendation**: [BLOCK MERGE / FIX BEFORE MERGE / APPROVE WITH NOTES]
```

## Error Handling

- **Test/Example Files**: Note if value is in test file. Add `// test-only` comment if fixture.
- **Constants vs Configuration**: Only flag values that vary between environments. Constants like `maxRetries = 3` are acceptable.

## Patterns to Detect and Fix

| Rationalization | Why It's Wrong | Required Action |
|-----------------|----------------|-----------------|
| "It's just a test key" | Test keys in source teach bad habits | Use env vars even for test |
| "We'll rotate it" | Rotation doesn't erase git history | Remove now, rotate immediately |
| "Default is fine for dev" | Dev defaults in prod cause incidents | Production-safe defaults |
| "We validate later" | Later = after user sees error | Validate at startup |
| "It's internal, not sensitive" | Internal credentials are still credentials | Treat all creds as sensitive |
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall