Skip to content

notque/vexjoy-agent / skills/programming/programming

programming

Flagged

Language rules, workflows, and tooling: Go, Python, Rust, Kotlin, Swift, PHP, TypeScript type checks and debugging, OpenStack Python, MCP local-docs servers, Node.js backend APIs.

FileKindSize
SKILL.mdskill md19.3 KB
references/go/code-review.mdmarkdown12.0 KB
references/go/code-review/common-review-comments.mdmarkdown6.6 KB
references/go/concurrency.mdmarkdown11.5 KB
references/go/concurrency/concurrency-patterns.mdmarkdown5.7 KB
references/go/error-handling.mdmarkdown10.8 KB
references/go/error-handling/patterns.mdmarkdown4.2 KB
references/go/google-style-guide/SHA256SUMSother313 B
references/go/google-style-guide/UPSTREAM_REVISIONother41 B
references/go/google-style-guide/best-practices/part-01.mdmarkdown10.0 KB
references/go/google-style-guide/best-practices/part-02.mdmarkdown15.0 KB
references/go/google-style-guide/best-practices/part-03.mdmarkdown14.1 KB
references/go/google-style-guide/best-practices/part-04.mdmarkdown13.5 KB
references/go/google-style-guide/best-practices/part-05.mdmarkdown10.5 KB
references/go/google-style-guide/best-practices/part-06.mdmarkdown14.4 KB
references/go/google-style-guide/best-practices/part-07.mdmarkdown16.1 KB
references/go/google-style-guide/best-practices/part-08.mdmarkdown11.4 KB
references/go/google-style-guide/best-practices/part-09.mdmarkdown13.7 KB
references/go/google-style-guide/best-practices/part-10.mdmarkdown16.9 KB
references/go/google-style-guide/decisions/part-01.mdmarkdown15.0 KB
references/go/google-style-guide/decisions/part-02.mdmarkdown12.5 KB
references/go/google-style-guide/decisions/part-03.mdmarkdown11.5 KB
references/go/google-style-guide/decisions/part-04.mdmarkdown8.4 KB
references/go/google-style-guide/decisions/part-05.mdmarkdown9.8 KB
references/go/google-style-guide/decisions/part-06.mdmarkdown14.7 KB
references/go/google-style-guide/decisions/part-07.mdmarkdown13.3 KB
references/go/google-style-guide/decisions/part-08.mdmarkdown14.3 KB
references/go/google-style-guide/decisions/part-09.mdmarkdown15.3 KB
references/go/google-style-guide/decisions/part-10.mdmarkdown8.3 KB
references/go/google-style-guide/guide/part-01.mdmarkdown16.3 KB
references/go/google-style-guide/guide/part-02.mdmarkdown3.0 KB
references/go/google-style-guide/index.mdmarkdown8.4 KB
references/go/preferred-patterns.mdmarkdown12.5 KB
references/go/preferred-patterns/code-examples.mdmarkdown11.6 KB
references/go/quality-gate.mdmarkdown7.3 KB
references/go/quality-gate/common-lint-errors.jsonconfig7.6 KB
references/go/quality-gate/examples.mdmarkdown11.0 KB
references/go/quality-gate/makefile-targets.jsonconfig5.1 KB
references/go/sapcc-conventions.mdmarkdown34.6 KB
references/go/sapcc-conventions/api-design-detailed.mdmarkdown22.7 KB
references/go/sapcc-conventions/architecture-patterns.mdmarkdown18.6 KB
references/go/sapcc-conventions/build-ci-detailed.mdmarkdown18.7 KB
references/go/sapcc-conventions/error-handling-detailed.mdmarkdown20.1 KB
references/go/sapcc-conventions/extended-patterns.mdmarkdown7.1 KB
references/go/sapcc-conventions/go-bits-philosophy-detailed.mdmarkdown24.5 KB
references/go/sapcc-conventions/library-reference.mdmarkdown14.0 KB
references/go/sapcc-conventions/pr-mining-insights.mdmarkdown17.5 KB
references/go/sapcc-conventions/review-standards.mdmarkdown10.5 KB
references/go/sapcc-conventions/sapcc-code-patterns.mdmarkdown46.2 KB
references/go/testing.mdmarkdown9.7 KB
references/go/testing/go-benchmark-and-concurrency.mdmarkdown5.6 KB
references/go/testing/go-test-patterns.mdmarkdown9.0 KB
references/golang-general.mdmarkdown8.9 KB
references/golang-general/go-modern-code.mdmarkdown17.2 KB
references/golang-general/go-verification-workflow.mdmarkdown5.0 KB
references/golang-general/go-version-idioms.mdmarkdown6.8 KB
references/kotlin-general.mdmarkdown7.5 KB
references/kotlin-general/kotlin-patterns.mdmarkdown7.9 KB
references/kotlin-general/kotlin-security-testing.mdmarkdown4.4 KB
references/kotlin-general/kotlin-security.mdmarkdown11.1 KB
references/kotlin/concurrency-patterns.mdmarkdown5.4 KB
references/kotlin/kotlin-testing.mdmarkdown7.9 KB
references/mcp-local-docs.mdmarkdown6.9 KB
references/mcp-local-docs/mcp-patterns.mdmarkdown9.6 KB
references/mcp-local-docs/mcp-preferred-patterns.mdmarkdown6.9 KB
references/mcp-local-docs/server-templates.mdmarkdown4.4 KB
references/mcp-local-docs/typescript-async-patterns.mdmarkdown8.9 KB
references/nodejs-api.mdmarkdown7.3 KB
references/nodejs-api/auth-patterns.mdmarkdown10.0 KB
references/nodejs-api/middleware-patterns.mdmarkdown10.5 KB
references/nodejs-api/nodejs-security.mdmarkdown12.3 KB
references/nodejs-api/webhook-patterns.mdmarkdown9.9 KB
references/php-general.mdmarkdown4.7 KB
references/php-general/php-behaviors.mdmarkdown5.2 KB
references/php-general/php-conventions.mdmarkdown5.8 KB
references/php/modern-php-features.mdmarkdown4.4 KB
references/php/testing-patterns.mdmarkdown7.5 KB
references/python-general.mdmarkdown7.7 KB
references/python-general/flask-jinja-webapp.mdmarkdown5.7 KB
references/python-general/python-local-gates.mdmarkdown4.4 KB
references/python-general/python-modern-code.mdmarkdown23.1 KB
references/python-openstack.mdmarkdown5.2 KB
references/python-openstack/error-handling.mdmarkdown658 B
references/python-openstack/hacking-rules.mdmarkdown4.1 KB
references/python-openstack/openstack-patterns.mdmarkdown1.2 KB
references/python-openstack/oslo-patterns.mdmarkdown6.4 KB
references/python-openstack/output-format.mdmarkdown2.4 KB
references/python-openstack/preferred-patterns.mdmarkdown1.9 KB
references/python-openstack/rpc-versioning.mdmarkdown5.3 KB
references/rust-general.mdmarkdown8.2 KB
references/rust-general/rust-modern-code.mdmarkdown13.4 KB
references/rust-general/rust-verification-workflow.mdmarkdown5.5 KB
references/rust-general/rust-version-idioms.mdmarkdown7.0 KB
references/swift-general.mdmarkdown5.7 KB
references/swift-general/swift-patterns.mdmarkdown6.7 KB
references/swift-general/swift-security-testing.mdmarkdown6.6 KB
references/swift-general/swift-security.mdmarkdown13.3 KB
references/swift/preferred-patterns.mdmarkdown2.4 KB
references/swift/swift-testing.mdmarkdown6.6 KB
references/swift/task-patterns.mdmarkdown3.6 KB
references/typescript-debugging.mdmarkdown9.3 KB
references/typescript-debugging/debugging-workflows-async-memory.mdmarkdown5.8 KB
references/typescript-debugging/debugging-workflows.mdmarkdown5.6 KB
scripts/bench-compare.shscript7.1 KB
scripts/check-errors.shscript7.1 KB
scripts/check-interface-compliance.shscript6.4 KB
scripts/check-sapcc-auth-ordering.shscript5.5 KB
scripts/check-sapcc-httptest.shscript4.4 KB
scripts/check-sapcc-identify-endpoint.shscript5.8 KB
scripts/check-sapcc-json-strict.shscript4.9 KB
scripts/check-sapcc-time-now.shscript4.2 KB
scripts/check-sapcc-todo-format.shscript4.1 KB
scripts/gen-table-test.shscript4.2 KB
scripts/quality_checker.pyscript16.2 KB
scripts/sync-google-style-guide.pyscript2.5 KB
scripts/validate.pyscript6.3 KB

references/go/sapcc-conventions/review-standards.md

View on GitHub
# SAP CC Review Standards — Lead + Secondary

Two complementary review styles govern sapcc code review.

---

## Part 1: Lead Reviewer

**Style**: Directive — statements, not suggestions.
**Top themes**: Simplicity/anti-over-engineering (10/38 comments), API design (8), error handling (7).

### Rules (Synthesized from 21 Review Comments)

| # | Rule | One-Line Summary | Source |
|---|------|-----------------|--------|
| 1 | Simplicity over ceremony | Don't create throwaway struct types for one-off JSON marshaling. `fmt.Sprintf` + `json.Marshal`. | Comment 1 |
| 2 | Trust stdlib error messages | Don't re-wrap errors when `strconv`, constructors already provide good context. Use `must.Return()`. | Comments 5-6 |
| 3 | Use Cobra subcommands | Don't manually roll argument dispatch that Cobra handles. Change arg order if needed. | Comment 3 |
| 4 | CLI names: specific + extensible | `keppel test-driver storage`, not `keppel test`. Leave room for siblings. | Comment 2 |
| 5 | Explicit params over inference | When a known design change is coming, use explicit `--params <json>`, don't build smart inference. | Comment 4 |
| 6 | No hidden defaults for niche cases | If a default only applies to a subset, make the parameter required. | Comment 7 |
| 7 | Dismiss theoretical concerns | Key question: "Can you point to a concrete scenario where this fails?" If not, don't handle it. | Comments 8-10 |
| 8 | Use existing error utilities | `errext.ErrorSet` and `.Join()`, not manual string concatenation with trailing separators. | Comment 15 |
| 9 | Marshal structured data for errors | If you have `map[string]any`, `json.Marshal` it rather than manually formatting fields. | Comment 18 |
| 10 | Tests must verify behavior | Never silently remove assertions during refactoring. Counterintuitive results are red flags. | Comments 12-13 |
| 11 | Explain non-obvious test workarounds | Add comments when test setup diverges from production patterns. | Comment 16 |
| 12 | Documentation must stay qualified | When behavior changes conditionally, update docs to state the conditions. | Comment 11 |
| 13 | TODOs: what + starting-point link + why-not-now | Include all three, not just `// TODO: fix later`. | Comment 19 |
| 14 | Understand Go value semantics | Value receiver copies struct, but reference-type fields share data. | Comment 20 |
| 15 | Variable names must not mislead about consumers | Don't name script vars as if the application reads them. | Comment 21 |

### Verbatim Review Examples

**Comment 1 — Copilot suggestion overengineered** (`cmd/test/main.go`):
> "I agree in principle with Copilot, but I think their suggestion is overengineered."

```go
// Anti-pattern: creating struct types for one-off JSON
storageConfig = fmt.Sprintf(`{"type":"filesystem","params":{"path":%s}}`,
  must.Return(json.Marshal(filesystemPath)))
```

**Comment 5-6 — Trust strconv/constructor error messages** (`cmd/test/main.go`):
> "ParseUint is disciplined about providing good context in its input messages... So we can avoid boilerplate here."

```go
// Anti-pattern: redundant error wrapping when stdlib provides context
chunkNumber := must.Return(strconv.ParseUint(chunkNumberStr, 10, 32))
ad := must.Return(keppel.NewAuthDriver(cmd.Context(), authConfig, nil))
```

**Comment 8-10 — Dismiss theoretical concerns** (`cmd/test/storage.go`):
> "This is an irrelevant contrivance." (on defer-closing `io.NopCloser`)
> "I'm going to ignore this based purely on the fact that Copilot complains about `os.Stdout.Write()`, but not about the much more numerous instances of `fmt.Println`."

**Comment 15 — Use errext.ErrorSet** (`internal/client/auth_challenge.go`):
> "This produces an extra trailing `\"; \"` at the end. Please use `errext.ErrorSet` and then `errs.Join(\"; \")`."

**Comment 18 — Marshal structured data** (`internal/processor/manifests.go`):
> "I like that we're showing the same payload that is also relevant for the CEL expression, but I don't like that we're doing a bunch of manual footwork here... I suggest to just `json.Marshal()` that for the error message."

**Comment 19 — TODOs with context** (`internal/keppel/validation.go`):
> "Please add a TODO here that we should investigate how to declare the fields of `layers` correctly."

### Meta-Rules: How the Lead Reviewer Reviews

| # | Rule | Pattern |
|---|------|---------|
| M1 | Reads Copilot suggestions critically | Agrees with direction, proposes simpler 1-line alternative |
| M2 | Dismisses inconsistent AI suggestions | If tool flags X but not equivalent Y, concern is invalid |
| M3 | Thinks about forward compatibility | Names, params, and API shapes evaluated for extensibility |
| M4 | Values brevity when stdlib provides clarity | Removes wrappers that duplicate error info |
| M5 | Approves simple PRs quickly | Doesn't manufacture concerns. "Let's give it a shot." |
| M6 | Corrects technical misconceptions directly | "Incorrect. `d.Limits` is not overwritten..." |
| M7 | Pushes fixes when needed | Sometimes pushes commits directly to address concerns |

### Lead Reviewer Priority Summary

| Dimension | Position |
|-----------|----------|
| Complexity | Aggressively removes. "Irrelevant contrivance." |
| AI suggestions | Skeptical. Judges on merit. Often simplifies. |
| Error handling | Trust stdlib context. `must.Return()`. Less wrapping. |
| Testing | Tests MUST cover behavior. Never reduce coverage. |
| API surface | Plan extensibility. Immutable variables. |
| Go type system | Deep expertise. Cites spec. Understands value semantics. |
| Documentation | Qualified, precise. TODOs with context. Public methods need docstrings. |
| Dependencies | Minimize. Move utilities to `internal` to avoid transitive dep pollution. |

### go-bits Review Patterns (Cross-Repository)

- **API surface protection**: No global mutable variables. Use `func ForeachX[T](action func(any) T) []T` instead.
- **Dependency graph minimization**: Move functions to `internal` to avoid pulling transitive deps.
- **Correct technical reasoning**: "We cannot change DeepEqual to use `==`. Most types are not within the `comparable` interface."
- **Spec-faithful programming**: Handle ambiguous spec behavior by making both branches behave the same.
- **Status code range check**: `respondwith.CustomStatus` panics on non-error status codes (only 400-599).
- **Public API documentation**: Exported methods must have docstrings. Return `bool` not `string` when the type fits.
- **Test exhaustiveness**: "This should recurse through each request and response payload type."

### PRs with No Comments (Silent Approvals)

Simple, low-risk PRs get clean approvals: lint fixes, dependency bumps, codeowner updates, small bug fixes, config changes. Detailed review is reserved for new architecture, CLI commands, or API surfaces.

---

## Part 2: Secondary Reviewer

**Style**: Inquisitive — questions where lead review makes statements.
**Top themes**: Error handling/migration safety (4/18 comments), testing (4), code style (3).

### Rules (Synthesized from 18 Review Comments)

| # | Rule | One-Line Summary | Source |
|---|------|-----------------|--------|
| 1 | Error messages must be actionable | "Internal Server Error" is unacceptable when the cause is knowable. | Authored PR |
| 2 | Know the spec, deviate pragmatically | Reference RFCs, but deviate when spec is impractical. | Authored PR |
| 3 | Guard against panics with clear errors | Check nil/empty before indexing. `fmt.Errorf("invalid: %q", val)`. | Authored PR |
| 4 | Strict configuration parsing | `DisallowUnknownFields()` on JSON decoders for config. | Comment 13 |
| 5 | Test ALL combinations | When changing logic with multiple inputs, test every meaningful combination. | Authored PR |
| 6 | Eliminate redundant code | "This check is now redundant?" / "This is already done above." | Comments 2-4, 10 |
| 7 | Comments explain WHY | "That should probably be a comment" — request WHY when non-obvious. | Comment 9 |
| 8 | Domain knowledge over theory | "Rate limit is not on a sub second basis." | Comment 1 |
| 9 | Smallest possible fix | 2-line PRs are fine. Keep changes focused. | Authored PR |
| 10 | Respect ownership hierarchy | "LGTM but lets wait for lead review, we are in no hurry here." | Comment 5 |
| 11 | Be honest about mistakes | Acknowledge errors quickly, propose fix direction. | Comment 6 |
| 12 | Validate migration paths | "Do we somehow check if this is still set and then abort?" | Comments 11-12 |
| 13 | Formatting: use GitHub suggestion blocks | One-click apply for small changes. | Comment 7 |
| 14 | Prefer simple over overengineered | Accept simpler alternatives when valid. | Comment 8 |

### Secondary Reviewer's Authored PR Patterns

- **Defensive testing**: Edge cases (account names starting with `-`, reserved names), regex validation
- **Spec awareness + pragmatic deviation**: References RFC drafts, deviates when impractical
- **Minimal pragmatic fixes**: 2-line changes with one-sentence PR bodies
- **Domain logic simplification**: Changed merge priority so Unsupported no longer overrides actual severity
- **Real-world error handling**: `TestReplicationFailingFromHarbor`, `TestReplicationFailingFromGHCR`
- **User-facing error quality**: Before: "500 Internal Server Error". After: actionable error with URL and cause
- **Defensive nil checks**: `if len(pathParts) < 1` before index access with clear error messages

### Lead vs Secondary: Key Differences

| Dimension | Lead | Secondary |
|-----------|------|-----------|
| Review style | Directive statements | Inquisitive questions |
| Complexity | Aggressively removes | Adds defensive checks |
| AI suggestions | Skeptical, simplifies | More accepting |
| Error handling | Trust stdlib, less wrapping | Validate inputs, more wrapping |
| Testing | Tests MUST cover behavior | Tests should not be redundant |
| Defense in depth | Handle ambiguity silently | Make problems visible |
| Focus areas | Architecture, simplicity, API design | Migration safety, config, UX |
| Dismissal style | Principled ("irrelevant contrivance") | Domain-based ("not on sub-second basis") |

### Secondary Reviewer's Key Contributions

1. Error message quality — messages must be actionable, not just technically correct
2. Migration safety — removed env vars must still be validated
3. Configuration strictness — `DisallowUnknownFields()` catches typos
4. Real-world testing — test against actual production failure modes (Harbor, ghcr.io)
5. Spec awareness — reference RFCs, link magic numbers to specs
6. Defensive programming — guard against panics with clear errors
7. Small focused PRs — 2-line fixes are fine
8. Exhaustive combinations — when changing logic, test every meaningful input pair
rea-changelog-updatemorluto/reaPrepare or rewrite REA release changelogs and GitHub release notes from pinned Git history, with verified contributor thanks and Release Please synchronization.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
academy-guideanthropics/skillsStop and check this skill before finishing any reply to a question about how to use Claude or a Claude product — it recommends matching courses, tutorials, and use cases from Claude Academy (academy.claude.com), Anthropic's learning hub. Trigger on: "how do I", "how can I", "getting started with", "what can Claude do", "teach me", "learn to use"; questions about artifacts, projects, skills, plugins, connectors, MCP; requests about rolling Claude out to a team, class, or organization; and any ask for training materials, onboarding content, or learning resources. Use it when the user is learning how to use a feature or product — not when they are mid-task and just want the task done. This skill composes with other skills: after consulting product documentation to answer how a Claude feature works, also check here for a matching course or tutorial — a docs-grounded answer and an Academy recommendation belong together. Only recommend on a strong match; never invent Academy content.Stars: 198kUpdated Claude CodeCodexVerifiedInstall
claude-apianthropics/skillsReference for the Claude API / Anthropic SDK — model ids, pricing, params, streaming, tool use, MCP, agents, caching, token counting, model migration. TRIGGER — read BEFORE opening the target file; don't skip because it "looks like a one-liner" — whenever: the prompt names Claude/Anthropic in any form (Claude, Anthropic, Fable, Opus, Sonnet, Haiku, `anthropic`, `@anthropic-ai`, `claude-*`, `us.anthropic.*`, `[1m]`); the user asks about an LLM (pricing/model choice/limits/caching) — never answer from memory; OR the task is LLM-shaped with provider unstated (agent/MCP/tool-definition/multi-agent/RAG/LLM-judge/computer-use; generate/summarize/extract/classify/rewrite/converse over NL; debugging refusals/cutoffs/streaming/tool-calls/tokens). SKIP only when another provider is being worked on (overrides all triggers): OpenAI/GPT/Gemini/Llama/Mistral/Cohere/Ollama named in the query; OR `grep -rE 'openai|langchain_openai|google.generativeai|genai|mistralai|cohere|ollama'` over the project hits (run this grep FIRST if no provider named — don't Read the file).Stars: 198kUpdated Claude CodeCodexUnverifiedInstall
doc-coauthoringanthropics/skillsGuide users through a structured workflow for co-authoring documentation. Use when user wants to write documentation, proposals, technical specs, decision docs, or similar structured content. This workflow helps users efficiently transfer context, refine content through iteration, and verify the doc works for readers. Trigger when user mentions writing docs, creating proposals, drafting specs, or similar documentation tasks.Stars: 198kUpdated Claude CodeCodexVerifiedInstall