notque/vexjoy-agent / skills/process/process
process
VerifiedProcess: retrospectives, session handoff, pair programming, subagent-driven development, condition-based waiting.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 7.9 KB |
| adr-reviewer-prompt.md | markdown | 6.3 KB |
| code-quality-reviewer-prompt.md | markdown | 4.9 KB |
| implementer-prompt.md | markdown | 5.8 KB |
| references/cbw-implementation-patterns.md | markdown | 14.7 KB |
| references/cbw-preferred-patterns.md | markdown | 8.2 KB |
| references/cbw-testing-patterns.md | markdown | 8.8 KB |
| scripts/tests/test_worktree_capacity.py | script | 3.1 KB |
| scripts/worktree_capacity.py | script | 4.8 KB |
code-quality-reviewer-prompt.md
View on GitHub# Code Quality Reviewer Subagent Prompt Template
Use this template when dispatching the code quality reviewer AFTER ADR compliance passes.
## Purpose
The code quality reviewer answers: **"Is this code well-built?"**
This is NOT an ADR compliance review. That already passed. This review checks:
- Is the code well-structured?
- Are tests meaningful?
- Is error handling appropriate?
- Are there obvious bugs?
## Template
```
You are reviewing code for QUALITY ONLY.
ADR compliance has already been verified. Your job is to ensure the code is well-built.
## Context
**Task {TASK_NUMBER}: {TASK_TITLE}**
Brief description: {TASK_SUMMARY}
**ADR compliance:** ✅ Already verified
## What to Review
Changes from:
```bash
git diff {BASE_SHA}..{HEAD_SHA}
```
Files changed:
{FILES_CHANGED}
## Quality Checklist
### Code Structure
- [ ] Functions/methods have single responsibility
- [ ] Naming is clear and consistent
- [ ] No unnecessary complexity
- [ ] Code is readable without excessive comments
### Testing
- [ ] Tests exist for new functionality
- [ ] Tests are meaningful (not just coverage)
- [ ] Edge cases are considered
- [ ] Tests are isolated (don't depend on order)
### Error Handling
- [ ] Errors are handled appropriately
- [ ] Error messages are helpful
- [ ] No silent failures
- [ ] Resources are cleaned up on error
### Common Issues
- [ ] No hardcoded values that should be constants
- [ ] No obvious security issues
- [ ] No performance red flags
- [ ] No race conditions (if concurrent)
## Severity Levels
**Critical** - Must fix before proceeding
- Security vulnerabilities
- Data loss potential
- Broken functionality
**Important** - Should fix
- Poor error handling
- Missing tests for core functionality
- Performance issues
**Minor** - Nice to fix
- Style inconsistencies
- Minor refactoring opportunities
- Documentation gaps
## Output Format
```markdown
## Code Quality Review
### Strengths
- [What was done well]
### Issues
**Critical:**
- [Must fix issues]
**Important:**
- [Should fix issues]
**Minor:**
- [Nice to fix issues]
### Verdict
[✅ APPROVED or ❌ NEEDS WORK]
[If needs work, list specific issues to fix]
```
Focus on QUALITY, not ADR compliance. ADR compliance was already verified.
```
## Placeholder Definitions
| Placeholder | Description |
|-------------|-------------|
| `{TASK_NUMBER}` | Task number |
| `{TASK_TITLE}` | Task title |
| `{TASK_SUMMARY}` | Brief description (1-2 sentences) |
| `{BASE_SHA}` | Git SHA before implementation |
| `{HEAD_SHA}` | Git SHA after implementation |
| `{FILES_CHANGED}` | List of files that changed |
## Example Filled Template
```
You are reviewing code for QUALITY ONLY.
ADR compliance has already been verified. Your job is to ensure the code is well-built.
## Context
**Task 1: Create database migration**
Brief description: Added migration for user_preferences table with theme and notification settings.
**ADR compliance:** ✅ Already verified
## What to Review
Changes from:
```bash
git diff a1b2c3d..e4f5g6h
```
Files changed:
- migrations/0045_add_user_preferences.py
- tests/test_migrations.py
## Quality Checklist
[Same as template above]
Focus on QUALITY, not ADR compliance. ADR compliance was already verified.
```
## Example Output
### Approved
```markdown
## Code Quality Review
### Strengths
- Clean migration structure
- Proper use of Django migration framework
- Good index on user_id for query performance
- Reversible migration with clear down() method
### Issues
**Critical:**
- None
**Important:**
- None
**Minor:**
- Consider adding a comment explaining why theme defaults to 'light'
### Verdict
✅ APPROVED
Code is well-structured and follows project conventions.
```
### Needs Work
```markdown
## Code Quality Review
### Strengths
- Clear column definitions
- Tests exist
### Issues
**Critical:**
- None
**Important:**
- Magic number 100 used for max theme length - should be a constant
- Test doesn't verify the unique constraint on user_id
**Minor:**
- Migration docstring could be more descriptive
### Verdict
❌ NEEDS WORK
**Required fixes:**
1. Extract theme length limit to a constant (e.g., `MAX_THEME_LENGTH = 100`)
2. Add test case that verifies unique constraint on user_id
```
## After Review
**If ✅ APPROVED:**
- Mark task complete
- Move to next task
**If ❌ NEEDS WORK:**
- Implementer fixes Critical and Important issues
- Minor issues are optional (implementer's choice)
- Quality reviewer reviews again
- Repeat until approved
## Quality vs ADR Compliance Review
| Aspect | ADR Compliance Review | Quality Review |
|--------|------------------------|----------------|
| Question | "Right thing?" | "Built right?" |
| Focus | Requirements match | Code craftsmanship |
| Checks | Features, behavior | Structure, testing |
| Precondition | Implementation done | ADR review passed |
| Failures | Wrong features | Technical debt |
Both reviews must pass. Order is: ADR compliance first, then Quality.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness. | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependencies | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is available | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |