Skip to content

nledford/engineering-review-board / skills/performance-review

performance-review

Verified

Review performance and scalability using workload, baseline, profiling, query-plan, rendering, concurrency, and resource evidence. Use for bottleneck audits, benchmark plans, capacity risks, or performance-sensitive changes; do not use for active unexplained regressions or implementation mechanics alone.

FileKindSize
SKILL.mdskill md4.0 KB
---
name: performance-review
description: Review performance and scalability using workload, baseline, profiling, query-plan, rendering, concurrency, and resource evidence. Use for bottleneck audits, benchmark plans, capacity risks, or performance-sensitive changes; do not use for active unexplained regressions or implementation mechanics alone.
---

# Performance Review

Use this skill as a cross-stack review lens. Always load
[`review-verification-protocol`](../review-verification-protocol/SKILL.md)
before reporting findings. For repository changes, also load
[`code-review`](../code-review/SKILL.md).

Use [`systematic-debugging`](../systematic-debugging/SKILL.md) first when an
active regression has not been reproduced or narrowed. Use language, runtime,
browser, and SQL skills for implementation mechanics. Use
[`observability-engineering`](../observability-engineering/SKILL.md) when the
work changes durable production signals, dashboards, alerts, or SLOs.

For photo/video DAM workloads, compose with
[`digital-asset-management`](../digital-asset-management/SKILL.md) to define
representative catalog sizes, media fixtures, rendition/cache states, and viewer
workflows before measuring performance.

## Local CPU Parallelism Routing

When a performance-sensitive implementation needs a new local CPU-bound data or
task decomposition, compose with
[`parallelism-engineering`](../parallelism-engineering/SKILL.md) and the matching
language owner. That skill owns partitioning, worker bounds, reductions,
cancellation, and nested-parallelism design; this skill evaluates the workload,
baseline, profiles, and resulting evidence.

Do not route a benchmark, profile, scalability audit, or other evidence-only
performance review to `parallelism-engineering`; it remains here unless an
implementation design actually changes. Routine async I/O, event-loop/runtime
concurrency, and Spark/PySpark execution likewise remain with their existing
runtime or data-platform owners rather than becoming local CPU-parallelism work.

When profiles, traces, logs, responses, or production evidence may expose
secrets, credentials, PII, tenant data, payloads, or private paths, also load
[`security-review`](../security-review/SKILL.md) and
[`security-review-evidence`](../security-review-evidence/SKILL.md). Keep raw
artifacts local and ignored; report sanitized measurements and summaries only.
This routing is unnecessary for non-sensitive evidence.

## Workflow

1. Define the supported workload, data size, traffic or concurrency shape,
   environment, user-visible impact, and target threshold.
2. Establish a representative baseline from benchmarks, profiles, traces,
   browser measurements, query plans, production-safe telemetry, or reproducible
   timing. Label estimates and missing measurements explicitly.
3. Identify the hot path and scaling variable before reviewing allocations,
   cloning, I/O, query count and shape, serialization, rendering, caching,
   contention, queueing, backpressure, and resource bounds.
4. Verify each finding against repository evidence and distinguish measured
   bottlenecks from plausible risks that still require an experiment.
5. Recommend the smallest change that addresses the demonstrated cause, plus the
   benchmark, load test, query-plan comparison, or runtime measurement that would
   prove the improvement and catch regressions.
6. Report environment limits, skipped measurements, assumptions, tradeoffs, and
   residual capacity risk.

## Output

Return prioritized findings with workload and baseline evidence, expected user
or operational impact, a concrete remedy, a measurement plan, skipped checks,
and residual risk. Do not claim an optimization without a way to compare before
and after behavior.

## Zod Hot-Path Evidence

Before `z.compile()` or `z.validate()`, benchmark representative valid, invalid-with-diagnostics, boolean-validation, construction/reuse, transform, depth, and async workloads. Load [`zod-engineering`](../zod-engineering/SKILL.md) for version-specific limits.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall