meirborowski/Lodestone / .claude/skills/ship-change
ship-change
VerifiedTake a finished Lodestone change from a branch to main - review, commit, push, open a pull request, get CI green and squash-merge. Use whenever work is ready to land.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 1.8 KB |
SKILL.md
View on GitHub---
name: ship-change
description: Take a finished Lodestone change from a branch to main - review, commit, push, open a pull request, get CI green and squash-merge. Use whenever work is ready to land.
---
# Ship a Change
main is protected and keeps a linear history: every change lands through a pull request, after CI passes, as a squash merge - the only merge method the repository allows (see `AGENTS.md` and `docs/Testing.md#ci`).
1. **Branch** - work on a descriptive branch (`milestone-2-window`, `fix-log-flush`), never on main.
2. **Verify locally** - follow the `build-and-test` skill: the debug, release and dist workflows, the format check and clang-tidy all pass.
3. **Update the docs** - `docs/Milestones.md` (tick finished items, update Current State), any new decision in `docs/Decisions/` (and its index), `AGENTS.md` and the skills if commands or layout changed, and `THIRD_PARTY_LICENSES.md` for new dependencies.
4. **Review** - review the full diff (`git diff main...HEAD`, plus uncommitted changes) with `/code-review`. Fix every real finding, and check the change against `docs/CodeStyle.md`.
5. **Commit** - a clear message explaining what changed and why. No AI attribution lines (no `Co-Authored-By: Claude`, no "Generated with Claude Code").
6. **Push and open the pull request** - `git push -u origin <branch>`, then `gh pr create --base main` with a summary of the change and how it was tested.
7. **CI** - wait for every job. The `CI passed` job sums them up. If a job fails, read its log (`gh run view <id> --log-failed`), fix the cause, and push again. A failed rendering test uploads its images as an artifact (`gh run download <id>`). Never weaken a test or a check to get green.
8. **Merge** - once CI is green: `gh pr merge <number> --squash --delete-branch`. Then update the local main: `git switch main && git pull`.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |