matthewwong525/WongStack / .agents/plugins/access
access
VerifiedSee who can sign in and what each person may use; add, change or remove a person.
screen/person-page.test.mjs
View on GitHub// @vitest-environment jsdom
import { afterEach, beforeEach, expect, it, vi } from 'vitest'
import { cleanup, fireEvent, render, screen, waitFor, within } from './test-dom.mjs'
import { PROJECT_REQUEST } from './status.mjs'
// A shop with three apps: Hello changes things with Stripe, Payroll with Bank, and the tip calculator uses no key.
const key = (id, title, changes = {}) => ({ id, title, levels: ['read', 'write'], saved: true, setup: false, alone: false, ...changes })
const built = (id, title) => ({ id, title, description: `${title} for the shop` })
const person = (email, changes = {}) => ({ email, status: 'active', settled: true, role: null, apps: [], keys: {}, ...changes })
const sales = () => ({ apps: ['hello', 'tips'], keys: { stripe: 'read' } })
const status = () => ({ ownerEmail: 'owner@shop.com', viewer: { email: 'owner@shop.com', owner: true }, environment: 'live', key: 'ready', started: true, imported: 0,
keysStarted: true, unticked: { people: [], roles: [] },
apps: [built('hello', 'Hello'), built('payroll', 'Payroll'), built('tips', 'Tip calculator')],
keys: [key('stripe', 'Stripe'), key('bank', 'Bank'),
key('cloudflare', 'Cloudflare', { levels: ['read'], setup: true, alone: true }), key('code', 'Project code', { levels: ['read', 'write'], alone: true })],
roles: [{ id: 'office', name: 'Office', apps: [], keys: {} }, { id: 'sales', name: 'Sales', ...sales() }, { id: 'support', name: 'Support', apps: ['hello'], keys: { stripe: 'read' } }],
// Kim has Hello, which changes things with Stripe, and holds Stripe at Read: the two are not tied to each other.
people: [person('gone@shop.com', { status: 'removed' }), person('kim@shop.com', { apps: ['hello'], keys: { stripe: 'read', cloudflare: 'read' } }),
person('lee@shop.com', { role: 'sales', ...sales() }), person('sam@shop.com', { role: 'sales', ...sales() })],
work: [], project: 'ready' })
let roster
let fetchMock
// The apps a person can open.
const screens = () => roster.apps.map(item => item.id)
beforeEach(() => {
roster = status()
fetchMock = vi.fn(async (url) => {
const path = url.replace('/api/access/', '')
// The owner, or an Admin: an employee who manages. The status names which in `viewer`.
if (path === 'apps') return Response.json({ state: 'current', role: roster.viewer.owner ? 'owner' : 'employee', manages: true, apps: ['access', ...screens()], revision: 1 })
if (path === 'setup') return Response.json({ role: 'owner', api: 'authenticated', identity: { email: 'owner@shop.com', subject: 'owner' }, apps: screens(),
repository: 'manual_provider_setup', memory: 'independent_operator_setup', prompt: { state: 'unavailable', message: 'Not on this preview' } })
return Response.json(roster)
})
vi.stubGlobal('fetch', fetchMock)
})
afterEach(() => { cleanup(); vi.unstubAllGlobals() })
const open = (path = '') => render(`/apps/access/${path}`)
const where = () => decodeURIComponent(window.location.pathname)
const click = (name) => fireEvent.click(screen.getByRole('button', { name }))
const posts = (path) => fetchMock.mock.calls.filter(([url, init]) => url.endsWith(path) && init?.method === 'POST')
const sent = (path) => posts(path).map(([, init]) => JSON.parse(init.body))
const checked = (inputs) => inputs.filter(input => (input).checked).map(input => input.parentElement .textContent)
// One person's row in the list, what its cells say and the role picked in it.
const row = async (email) => within((await screen.findByRole('link', { name: email })).closest('tr'))
const cells = async (email) => Array.from((await screen.findByRole('link', { name: email })).closest('tr') .querySelectorAll('td')).map(cell => cell.textContent)
const picked = (email) => (screen.getByRole('combobox', { name: `Role for ${email}` })).selectedOptions[0].textContent
const labels = (box) => box.queryAllByRole('listitem').map(item => item.textContent)
// The panel a person is opened in, by their email, and that none is open any more.
const panel = async (name) => within(await screen.findByRole('dialog', { name }))
const closed = () => waitFor(() => expect(screen.queryByRole('dialog')).toBeNull())
// Every tick in the panel by its words: each app, then the one that gives the project.
const ticks = () => checked(screen.queryAllByRole('checkbox'))
const boxes = () => screen.queryAllByRole('checkbox').map(input => input.parentElement .textContent)
// A named group: Apps, Keys or Project, or one key's level choice by the name its legend starts with,
// with the quiet lines under it.
const part = (name) => screen.getByRole('group', { name: new RegExp(`^${name}( · |$)`) })
const level = (name) => within(part(name))
const pick = (name, to) => fireEvent.click(level(name).getByRole('radio', { name: to }))
const note = (name) => Array.from(part(name).querySelectorAll('p')).map(line => line.textContent)
const follows = (first, second) => !!(part(first).compareDocumentPosition(part(second)) & Node.DOCUMENT_POSITION_FOLLOWING)
// Apps: a press on one app's tick, and the apps that are ticked.
const give = (name) => fireEvent.click(level('Apps').getByRole('checkbox', { name }))
const given = () => checked(level('Apps').queryAllByRole('checkbox'))
// Project code is no line in Keys but a tick in its own group; the step left sits under it until the project is ready.
const INSTALL = 'Can install the project'
const PUBLISH = 'Can publish'
const install = () => screen.getByRole('checkbox', { name: INSTALL })
const publish = () => screen.getByRole('checkbox', { name: PUBLISH })
const tick = () => fireEvent.click(install())
const project = () => level('Project')
const lacking = (step) => { roster.keys[3].saved = false; roster.project = step }
// Keys: every line with the level it shows, and the lines above None.
const lines = () => level('Keys').queryAllByRole('group')
const title = (line) => line.querySelector('legend') .firstChild .textContent
// The same line's whole legend: the key, then whether the app holds it.
const state = (line) => line.querySelector('legend') .textContent
const levels = () => Object.fromEntries(lines().map(line => [title(line), checked(within(line).getAllByRole('radio'))[0]]))
const held = () => Object.fromEntries(Object.entries(levels()).filter(([, at]) => at !== 'None'))
const role = () => screen.getByLabelText('Role')
// What an earlier Access said about an app and a key together: none of it shows any more.
const GONE = /Start from|Can reach|Can't yet|can't use|not change|what it needs|Look up|gap|!/
const NO_APPS = { hello: false, payroll: false, tips: false }
const NO_KEYS = { stripe: null, bank: null, cloudflare: null, code: null }
it('shows each person on one line with their role and counts, with nothing marked as missing, and opened, a role as labels with one link to it and no ticks', async () => {
await open(); const lee = await row('lee@shop.com')
expect(picked('lee@shop.com')).toBe('Sales'); expect(lee.getByText('Can sign in')).toBeTruthy()
// How many apps and keys, never their names: the list holds no label. Sales has Hello with Stripe at Read, unmarked.
expect([(await cells('lee@shop.com'))[3], labels(screen)]).toEqual(['2 apps, 1 key', []])
expect(picked('kim@shop.com')).toBe('Own set'); expect((await cells('kim@shop.com'))[3]).toBe('1 app, 2 keys')
expect(screen.getByRole('table', { name: 'People' }).textContent).not.toMatch(GONE)
// A removed person keeps the row's parts, with no role to pick and nothing counted.
const gone = await row('gone@shop.com')
expect((await cells('gone@shop.com')).slice(0, 4)).toEqual(['gone@shop.com', 'Removed', 'No role', 'No apps']); expect(gone.queryByRole('combobox')).toBeNull()
await fireEvent.click(lee.getByRole('link', { name: 'lee@shop.com' }))
const opened = await panel('lee@shop.com'); expect(where()).toBe('/apps/access/people/lee@shop.com')
// The list and the views stay in place beside the panel, with her row marked.
expect(screen.getByRole('table', { name: 'People' }).querySelector('tr[aria-current="true"] a') .textContent).toBe('lee@shop.com'); expect(screen.getByRole('navigation', { name: 'Access views' })).toBeTruthy()
expect(opened.getByText('Can sign in')).toBeTruthy()
expect(role().value).toBe('sales'); expect(screen.queryByLabelText('Email')).toBeNull()
// Opened, the names show: each kind of label is its own named list, an app by its title alone, a key with its level.
expect(screen.getByText('From the Sales role:')).toBeTruthy()
expect(labels(opened)).toEqual(['Hello', 'Tip calculator', 'Stripe Read'])
expect(opened.getAllByRole('list').map(list => list.getAttribute('aria-label'))).toEqual(['Apps', 'Keys'])
// A role is changed where the role is opened: no level and no tick.
expect(boxes()).toEqual([]); expect(screen.queryByRole('radio')).toBeNull(); expect(['Apps', 'Keys'].map(name => screen.queryByRole('group', { name }))).toEqual([null, null])
expect(screen.getByRole('link', { name: 'Edit the Sales role' }).getAttribute('href')).toBe('/apps/access/roles/sales')
await fireEvent.change(role(), { target: { value: 'support' } }); expect(screen.getByText('From the Support role:')).toBeTruthy()
expect(labels(opened)).toEqual(['Hello', 'Stripe Read']); expect(screen.getByRole('dialog', { name: 'lee@shop.com' }).textContent).not.toMatch(GONE)
// A role with nothing in it says so, and the save names the role alone.
await fireEvent.change(role(), { target: { value: 'office' } })
expect(labels(opened)).toEqual([]); expect(opened.getByText('No apps')).toBeTruthy(); expect(opened.queryAllByRole('list')).toEqual([])
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'lee@shop.com', removed: false, role: 'office' }]); expect(where()).toBe('/apps/access/')
// The role itself is one link from the person.
await fireEvent.click((await row('sam@shop.com')).getByRole('link', { name: 'sam@shop.com' }))
await fireEvent.click(await screen.findByRole('link', { name: 'Edit the Sales role' }))
expect((await screen.findByLabelText('Name')).value).toBe('Sales'); expect(where()).toBe('/apps/access/roles/sales')
})
it("an app is ticked or not, whatever the person's key levels: no Start from, Can reach or Can't yet shows, and nothing is marked as missing", async () => {
// Kim has Hello, which changes things with Stripe, and no level for Stripe at all.
roster.people[1] = person('kim@shop.com', { apps: ['hello'] })
await open(); expect((await cells('kim@shop.com'))[3]).toBe('1 app')
await fireEvent.click((await row('kim@shop.com')).getByText('1 app')); await panel('kim@shop.com')
expect([given(), held()]).toEqual([['Hello'], {}])
for (const name of ['Start from', 'Can reach', "Can't yet"]) expect(screen.queryByRole('group', { name }), name).toBeNull()
expect(screen.getByRole('dialog', { name: 'kim@shop.com' }).textContent).not.toMatch(GONE)
// The only buttons are the panel's own: nothing fills a set in, and nothing gives what an app needs.
expect(screen.getAllByRole('button').map(button => button.textContent).filter(text => /Hello|Give/.test(text))).toEqual([])
})
it('with their own set, the panel has two groups, a tick for every app and then a level for every key, and neither moves the other', async () => {
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect(role().value).toBe('')
expect(within(role()).getAllByRole('option').map(option => option.textContent)).toEqual(['Their own set', 'Office', 'Sales', 'Support'])
// Apps: a tick per app, in the order they are shown, with no level beside one. Then the project's two ticks.
expect(boxes()).toEqual(['Hello', 'Payroll', 'Tip calculator', INSTALL, PUBLISH]); expect([given(), level('Apps').queryAllByRole('radio'), ticks()]).toEqual([['Hello'], [], ['Hello']])
// Keys: every key but Project code, each with its level.
expect(lines().map(title)).toEqual(['Stripe', 'Bank', 'Cloudflare']); expect(levels()).toEqual({ Stripe: 'Read', Bank: 'None', Cloudflare: 'Read' })
// A key offers three levels, or two when it is Read only.
const offered = (name) => level(name).getAllByRole('radio').map(radio => radio.parentElement .textContent)
expect([offered('Bank'), offered('Cloudflare')]).toEqual([['None', 'Read', 'Read & write'], ['None', 'Read']])
// Under a key, what its level does with the key by itself, and never which apps use it.
expect([note('Stripe'), note('Bank'), note('Cloudflare')]).toEqual([[], [], []])
// Apps come first, then Keys, then the project, and no group is for managing.
expect([follows('Apps', 'Keys'), follows('Keys', 'Project'), screen.queryByRole('group', { name: 'Managing' })]).toEqual([true, true, null])
expect(screen.queryByText('Not saved yet')).toBeNull()
// A tick moves no key level: Payroll changes things with Bank, and Bank stays at None. Unticking Hello leaves Stripe.
await give('Payroll'); expect([given(), levels()]).toEqual([['Hello', 'Payroll'], { Stripe: 'Read', Bank: 'None', Cloudflare: 'Read' }]); expect(screen.getByText('Not saved yet')).toBeTruthy()
await give('Hello'); expect([given(), levels()]).toEqual([['Payroll'], { Stripe: 'Read', Bank: 'None', Cloudflare: 'Read' }])
// A level moves no tick.
await pick('Bank', 'Read & write'); await pick('Stripe', 'None'); expect([given(), held()]).toEqual([['Payroll'], { Bank: 'Read & write', Cloudflare: 'Read' }])
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'kim@shop.com', removed: false, role: null, apps: { hello: false, payroll: true, tips: false }, keys: { stripe: null, bank: 'write', cloudflare: 'read', code: null } }])
// A key whose service is set up says its level also reaches the service directly, with nothing to switch on;
// one that also works with no app says both, and one that offers Read alone names no change.
cleanup(); roster.keys[0] = { ...roster.keys[0], direct: true }; roster.keys[1] = { ...roster.keys[1], direct: false }
roster.keys[2] = { ...roster.keys[2], direct: true }
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect([note('Stripe'), note('Bank'), note('Cloudflare')]).toEqual([['Also reaches Stripe directly'], [], ['Also reaches Cloudflare directly']])
expect(screen.queryByText(/Direct use|Look-ups only|Key settings/)).toBeNull()
})
it('says beside each key whether the app holds it, with the step left under one it does not, and a level saves either way', async () => {
Object.defineProperty(navigator, 'clipboard', { configurable: true, value: { writeText: vi.fn(async () => {}) } })
const LINK = 'Ask your assistant for the key link.'
const said = (name) => note(name).filter(Boolean)
// A step with a request to copy folds the request under it, in a group of its own: only the keys' are read here.
const keys = () => lines().filter(line => line.tagName === 'FIELDSET')
roster.keys = [key('stripe', 'Stripe'), key('maps', 'Maps', { saved: false }), key('cloudflare', 'Cloudflare', { levels: ['read'], saved: false, setup: true, alone: true, liveOnly: true }),
key('code', 'Project code', { levels: ['read', 'write'], alone: true, liveOnly: true })]
await open('people/kim@shop.com'); await panel('kim@shop.com')
// The state sits in the key's own legend, in quiet words, so the name stays the first thing read.
expect(keys().map(state)).toEqual(['Stripe · Saved', 'Maps · Not saved yet', 'Cloudflare · One step left']); expect(keys().map(title)).toEqual(['Stripe', 'Maps', 'Cloudflare'])
expect(part('Maps').querySelector('legend span') .className).toMatch(/text-muted-foreground/)
// A saved key has no step. One that waits for its link says so; the key setup makes gives the owner the request.
expect([said('Stripe'), said('Maps')]).toEqual([[], [LINK]]); expect(level('Maps').queryByRole('button')).toBeNull()
expect(said('Cloudflare')).toEqual(['Look-ups need a read-only key. Ask your assistant: Finish Access setup'])
expect(level('Cloudflare').getByRole('button', { name: 'Copy that request' })).toBeTruthy()
// A level is set before the key arrives, and nothing here is a change until it is.
expect(screen.queryByText('Not saved yet')).toBeNull()
await pick('Maps', 'Read'); await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')[0].keys).toEqual({ stripe: 'read', maps: 'read', cloudflare: 'read', code: null })
// An Admin reads that the step is the owner's, with nothing to copy.
cleanup(); roster.viewer = { email: 'kim@shop.com', owner: false }; await open('people/new'); await panel('Add person')
expect(said('Cloudflare')).toEqual(['Look-ups need a read-only key. owner@shop.com finishes that in Access setup.'])
expect([level('Cloudflare').queryByRole('button'), said('Maps')]).toEqual([null, [LINK]])
// Only the live app may hold that key, so a preview names it so and no step; the project says the same.
cleanup(); roster.viewer = { email: 'owner@shop.com', owner: true }; roster.environment = 'practice'; roster.project = 'live'; await open('people/new'); await panel('Add person')
expect([state(part('Cloudflare')), said('Cloudflare'), state(part('Maps')), said('Maps')]).toEqual(['Cloudflare · Live app only', [], 'Maps · Not on previews yet', [LINK]])
expect(screen.getByText('Live app only.').closest('p') .textContent).toBe('Live app only. People install the project and save changes from the live app.')
})
it('a tick saves the app and no key level: every app is sent as given or not, and every key at the level it had', async () => {
roster.people.push(person('pat@shop.com'))
await open('people/pat@shop.com'); await panel('pat@shop.com')
expect([given(), held(), ticks()]).toEqual([[], {}, []]); expect(screen.queryByText('Not saved yet')).toBeNull()
// Hello changes things with Stripe. Ticked, it gives no Stripe level, and nothing is sent until the save.
await give('Hello'); expect([given(), held()]).toEqual([['Hello'], {}])
expect(screen.getByText('Not saved yet')).toBeTruthy(); expect(posts('people')).toHaveLength(0)
roster.people[4] = person('pat@shop.com', { apps: ['hello'] })
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'pat@shop.com', removed: false, role: null, apps: { ...NO_APPS, hello: true }, keys: NO_KEYS }])
// Saved, the row counts one app and no key, and opened again the tick is on.
await fireEvent.click(await screen.findByText('1 app')); await panel('pat@shop.com')
expect([given(), held()]).toEqual([['Hello'], {}])
})
it('moving from a role to their own set starts from what that role gave', async () => {
await open('people/sam@shop.com'); await fireEvent.change(await screen.findByLabelText('Role'), { target: { value: '' } })
expect([given(), held()]).toEqual([['Hello', 'Tip calculator'], { Stripe: 'Read' }])
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'sam@shop.com', removed: false, role: null, apps: { hello: true, payroll: false, tips: true }, keys: { ...NO_KEYS, stripe: 'read' } }])
cleanup()
// Kim has her own set: picking a role hides the two groups, and coming back starts from that role too.
await open('people/kim@shop.com'); await fireEvent.change(await screen.findByLabelText('Role'), { target: { value: 'sales' } })
expect(boxes()).toEqual([]); expect(screen.queryByRole('group', { name: 'Apps' })).toBeNull(); expect(screen.getByText('From the Sales role:')).toBeTruthy()
await fireEvent.change(role(), { target: { value: '' } })
expect([given(), held()]).toEqual([['Hello', 'Tip calculator'], { Stripe: 'Read' }])
})
it('adds a person with a role in one save, from the keyboard, with every control labelled', async () => {
await open(); await fireEvent.click(await screen.findByRole('link', { name: 'Add person' }))
const email = await screen.findByLabelText('Email'); expect(document.activeElement).toBe(email)
expect(where()).toBe('/apps/access/people/new'); expect(await panel('Add person')).toBeTruthy()
expect([given(), held(), ticks()]).toEqual([[], {}, []])
expect(screen.queryByText(/shared separately/)).toBeNull()
// The two groups and the project's tick are each a group under its own name.
expect(['Apps', 'Keys', 'Project'].map(name => part(name).tagName)).toEqual(Array(3).fill('FIELDSET'))
// An app is a real checkbox, named by the app.
expect(level('Apps').getAllByRole('checkbox').map(box => [(box).type, box.parentElement .textContent])).toEqual([['checkbox', 'Hello'], ['checkbox', 'Payroll'], ['checkbox', 'Tip calculator']])
// Each level choice is one radio group with its key as the legend: arrow keys move inside it, Tab moves to the next.
const groups = lines().map(line => new Set(within(line).getAllByRole('radio').map(radio => (radio).name)))
expect(groups.map(names => names.size)).toEqual(Array(3).fill(1)); expect(new Set(groups.flatMap(names => Array.from(names))).size).toBe(3)
// Two keys with three levels each and one that is Read only. Project code is a tick, adding none; no app has a level.
expect(level('Keys').getAllByRole('radio')).toHaveLength(8); expect(screen.getAllByRole('radio')).toHaveLength(8)
await fireEvent.change(email, { target: { value: 'new@shop.com' } }); await fireEvent.change(role(), { target: { value: 'sales' } })
// Enter in a field submits the form: no pointer is needed.
fireEvent.submit(email.closest('form')); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'new@shop.com', removed: false, role: 'sales' }])
})
it('holds every control while a save is on its way, and Cancel goes back without saving', async () => {
await open('people/kim@shop.com'); await screen.findByRole('button', { name: 'Save access' })
await click('Cancel'); await closed(); expect(where()).toBe('/apps/access/')
await fireEvent.click((await row('kim@shop.com')).getByRole('link', { name: 'kim@shop.com' })); expect(posts('people')).toHaveLength(0)
const save = await screen.findByRole('button', { name: 'Save access' })
let finish = () => {}
fetchMock.mockImplementationOnce(() => new Promise (resolve => { finish = resolve }))
await click('Save access'); expect(save.closest('fieldset') .disabled).toBe(true)
finish(Response.json(roster)); await screen.findByText('Saved.')
expect(posts('people')).toHaveLength(1)
})
it('says so when there is no app or key to give yet', async () => {
roster.apps = []; roster.keys = []
await open('people/new'); await screen.findByText('No apps built yet. Ask your assistant to make one.')
expect(screen.getByText('No keys saved yet.')).toBeTruthy(); expect(boxes()).toEqual([])
// An app that lists no Project code offers no tick for it.
expect([given(), lines(), screen.queryByRole('group', { name: 'Project' })]).toEqual([[], [], null])
await fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'new@shop.com' } }); await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'new@shop.com', removed: false, role: null, apps: {}, keys: {} }])
// With one app and Project code the only key, its ticks are all there is: no key is listed, and no line says so.
cleanup(); roster.apps = status().apps.slice(0, 1); roster.keys = status().keys.slice(3)
await open('people/new'); await panel('Add person')
expect([boxes(), lines()]).toEqual([['Hello', INSTALL, PUBLISH], []])
expect([screen.queryByText('No keys saved yet.'), screen.queryByText('No apps built yet. Ask your assistant to make one.')]).toEqual([null, null])
})
it('gives the project with two ticks, off for a new person, and asks for the GitHub key under it only while it is on', async () => {
lacking('key')
Object.defineProperty(navigator, 'clipboard', { configurable: true, value: { writeText: vi.fn(async () => {}) } })
await open('people/new'); await panel('Add person')
expect(install().checked).toBe(false); expect(checked(project().getAllByRole('checkbox'))).toEqual([])
// Each tick says what it gives, ticked or not; publishing waits for the install tick.
expect([project().getByText('They can save changes too.'), project().getByText('Their changes go live once the checks pass.')]).toBeTruthy()
expect(publish().disabled).toBe(true)
// The tick stands in for the level choice: Project code is no line among the keys.
expect(lines().map(title)).toEqual(['Stripe', 'Bank', 'Cloudflare']); expect(screen.queryByRole('group', { name: 'Project code' })).toBeNull()
// After the keys.
expect(follows('Keys', 'Project')).toBe(true)
// Off, nothing is asked. On, the step is right under the tick, with the words to say and the request to copy.
expect(project().queryByText(/One step first/)).toBeNull(); expect(screen.queryByRole('button', { name: /Copy/ })).toBeNull()
await tick()
expect(project().getByText('One step first.')).toBeTruthy(); expect(project().getByText(/The app needs a GitHub key to hand the project out\. Ask your assistant:/)).toBeTruthy()
expect(project().getByText('Let teammates install the project')).toBeTruthy()
await fireEvent.click(project().getByRole('button', { name: 'Copy that request' }))
await waitFor(() => expect(navigator.clipboard.writeText).toHaveBeenCalledWith(PROJECT_REQUEST))
await tick(); expect(project().queryByText(/One step first/)).toBeNull(); await tick()
// It saves before the key arrives, as Read on Project code, and ticks no app.
await fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'new@shop.com' } })
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'new@shop.com', removed: false, role: null, apps: NO_APPS, keys: { ...NO_KEYS, code: 'read' } }])
})
it('gives publishing as a second tick on top of the install tick, and unticking the install takes both', async () => {
roster.people[1].keys = { stripe: 'read', code: 'read' }
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect([install().checked, publish().checked, publish().disabled]).toEqual([true, false, false])
// Unticking publish keeps the install; unticking the install takes publishing too.
await fireEvent.click(publish()); await fireEvent.click(publish()); expect([install().checked, publish().checked]).toEqual([true, false])
await fireEvent.click(publish()); await tick(); expect([install().checked, publish().checked, publish().disabled]).toEqual([false, false, true])
await tick(); await fireEvent.click(publish()); await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')[0].keys).toEqual({ ...NO_KEYS, stripe: 'read', code: 'write' })
})
it('shows a saved tick as on, with no step under it once the app can hand the project out, and unticking saves none', async () => {
roster.people[1].keys = { stripe: 'read', code: 'read' }
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect(ticks()).toEqual(['Hello', INSTALL]); expect(project().queryByText(/One step first/)).toBeNull(); expect(project().queryByRole('button', { name: 'Copy that request' })).toBeNull()
await tick(); expect(install().checked).toBe(false)
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'kim@shop.com', removed: false, role: null, apps: { ...NO_APPS, hello: true }, keys: { ...NO_KEYS, stripe: 'read' } }])
// An install that hands the project out and can not save yet:
// the tick says saving needs one more step, and blocks nothing.
cleanup(); roster.projectSave = 'key'
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect(project().getByText('Saving needs one more step.')).toBeTruthy(); expect(project().getByText('Let teammates save changes')).toBeTruthy()
expect(install().checked).toBe(true); expect(project().queryByText(/One step first/)).toBeNull()
roster.projectSave = undefined
// An install that has no project recorded is sent to finish Access setup, not to make a GitHub key.
cleanup(); lacking('setup')
await open('people/kim@shop.com'); await panel('kim@shop.com')
expect(project().getByText('Finish Access setup')).toBeTruthy(); expect(project().queryByText(/GitHub/)).toBeNull()
// A role's set shows as labels, with no tick: the tick is on the role's own page.
await fireEvent.change(role(), { target: { value: 'sales' } }); expect(screen.queryByRole('group', { name: 'Project' })).toBeNull()
})
it("tells an Admin who ticks it that the key is the owner's step, with nothing to copy", async () => {
lacking('key'); roster.viewer = { email: 'kim@shop.com', owner: false }
await open('people/lee@shop.com'); await panel('lee@shop.com'); await fireEvent.change(role(), { target: { value: '' } })
expect(install().checked).toBe(false); expect(project().queryByText(/One step first/)).toBeNull()
await tick()
expect(project().getByText('One step first for the owner.').parentElement .textContent).toBe('One step first for the owner. owner@shop.com adds a GitHub key.')
expect(project().queryByRole('button', { name: /Copy/ })).toBeNull(); expect(screen.queryByText('Let teammates install the project')).toBeNull()
await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'lee@shop.com', removed: false, role: null, apps: { hello: true, payroll: false, tips: true }, keys: { ...NO_KEYS, stripe: 'read', code: 'read' } }])
})
// Admin, the role made for you, as the status sends it: every app, and each key at its highest level.
const ADMIN = { id: 'admin', name: 'Admin', builtIn: true, apps: ['hello', 'payroll', 'tips'], keys: { stripe: 'write', bank: 'write', cloudflare: 'read', code: 'write' } }
const admin = () => ({ role: 'admin', apps: [...ADMIN.apps], keys: { ...ADMIN.keys } })
const asking = (email) => within(screen.getByRole('alertdialog', { name: `Make ${email} an Admin?` }))
const answer = (email, name) => fireEvent.click(asking(email).getByRole('button', { name }))
it('the owner gives Admin as a role: the panel says it is everything and full trust, and a save that newly gives it asks first', async () => {
roster.roles = [{ ...ADMIN, apps: [...ADMIN.apps] }, ...roster.roles]
await open('people/kim@shop.com'); const opened = await panel('kim@shop.com')
expect(within(role()).getAllByRole('option').map(option => option.textContent)).toEqual(['Their own set', 'Admin', 'Office', 'Sales', 'Support'])
await fireEvent.change(role(), { target: { value: 'admin' } })
// Plain text at full weight, never muted: no label, no tick, and no link to change the role.
const trust = opened.getByText('Every app and key. Can manage Access. Full trust.')
expect([trust.tagName, trust.className, boxes(), labels(opened), screen.queryByRole('link', { name: /Edit the/ })]).toEqual(['P', '', [], [], null])
// The save asks first, and a no sends nothing and keeps the panel as it was.
await click('Save access')
expect(asking('kim@shop.com').getByText("Every app, every key, and can change anyone's access.")).toBeTruthy(); expect(posts('people')).toHaveLength(0)
await answer('kim@shop.com', 'Cancel'); expect(screen.queryByRole('alertdialog')).toBeNull(); expect([role().value, posts('people')]).toEqual(['admin', []])
roster.people[1] = person('kim@shop.com', admin())
await click('Save access'); await answer('kim@shop.com', 'Make Admin'); await screen.findByText('Saved.')
expect(sent('people')).toEqual([{ email: 'kim@shop.com', removed: false, role: 'admin' }])
// Admin gives the project too, so the message to send her opens.
await done()
// Her row says Admin and Everything, with no mark beside her email.
expect((await cells('kim@shop.com')).slice(0, 4)).toEqual(['kim@shop.com', 'Can sign in', 'Own setAdminOfficeSalesSupport', 'Everything']); expect(picked('kim@shop.com')).toBe('Admin')
// An Admin saved again is not asked about, and a new person picked as one is.
cleanup(); await open('people/kim@shop.com'); await panel('kim@shop.com')
expect(role().value).toBe('admin'); await click('Save access'); await screen.findByText('Saved.')
expect([screen.queryByRole('alertdialog'), sent('people')[1]]).toEqual([null, { email: 'kim@shop.com', removed: false, role: 'admin' }])
cleanup(); await open('people/new'); await fireEvent.change(await screen.findByLabelText('Email'), { target: { value: 'new@shop.com' } })
await fireEvent.change(role(), { target: { value: 'admin' } }); await click('Save access'); await answer('new@shop.com', 'Make Admin'); await screen.findByText('Saved.')
expect(sent('people')[2]).toEqual({ email: 'new@shop.com', removed: false, role: 'admin' })
// Taking Admin away to her own set starts from everything, for the owner to untick, and asks nothing.
cleanup(); await open('people/kim@shop.com'); await panel('kim@shop.com'); await fireEvent.change(role(), { target: { value: '' } })
expect([given(), held(), install().checked]).toEqual([['Hello', 'Payroll', 'Tip calculator'], { Stripe: 'Read & write', Bank: 'Read & write', Cloudflare: 'Read' }, true])
await give('Payroll'); await click('Save access'); await screen.findByText('Saved.')
expect([screen.queryByRole('alertdialog'), sent('people')[3]]).toEqual([null, { email: 'kim@shop.com', removed: false, role: null, apps: { hello: true, payroll: false, tips: true }, keys: ADMIN.keys }])
})
it('picking Admin in a row asks before it saves, and Undo puts the person back on their own set or their earlier role', async () => {
roster.roles = [{ ...ADMIN, apps: [...ADMIN.apps] }, ...roster.roles]
// The question hides the page behind it from a screen reader, so the row's picker is found by its label there.
const select = (email) => document.querySelector (`select[aria-label="Role for ${email}"]`)
const shown = (email) => select(email).selectedOptions[0].textContent
await open(); await row('kim@shop.com')
await fireEvent.change(select('kim@shop.com'), { target: { value: 'admin' } })
// Nothing is sent, and the row still shows what she has, until the owner says yes. A no leaves the list as it was.
expect(asking('kim@shop.com').getByText("Every app, every key, and can change anyone's access.")).toBeTruthy()
expect([shown('kim@shop.com'), posts('people'), where()]).toEqual(['Own set', [], '/apps/access/'])
await answer('kim@shop.com', 'Cancel'); expect([screen.queryByRole('alertdialog'), shown('kim@shop.com'), posts('people')]).toEqual([null, 'Own set', []])
await fireEvent.change(select('kim@shop.com'), { target: { value: 'admin' } }); await answer('kim@shop.com', 'Make Admin')
// Admin gives the project too, so the message to send her opens.
await screen.findByText('kim@shop.com now has Admin.'); await done()
await click('Undo'); await screen.findByText('Undone.')
expect(sent('people')).toEqual([{ email: 'kim@shop.com', removed: false, role: 'admin' },
{ email: 'kim@shop.com', removed: false, role: null, apps: { ...NO_APPS, hello: true }, keys: { ...NO_KEYS, stripe: 'read', cloudflare: 'read' } }])
// A person who had a role goes back to that role.
await fireEvent.change(select('lee@shop.com'), { target: { value: 'admin' } }); await answer('lee@shop.com', 'Make Admin')
await screen.findByText('lee@shop.com now has Admin.'); await done(); await click('Undo'); await screen.findByText('Undone.')
expect(sent('people').slice(2)).toEqual([{ email: 'lee@shop.com', removed: false, role: 'admin' }, { email: 'lee@shop.com', removed: false, role: 'sales' }])
})
it('an Admin is not offered Admin to give, and reads an Admin\'s role as plain words that only the owner changes', async () => {
roster.roles = [{ ...ADMIN, apps: [...ADMIN.apps] }, ...roster.roles]
roster.viewer = { email: 'kim@shop.com', owner: false }; roster.people[1] = person('kim@shop.com', admin())
// In the list: her own role is words, with nothing to pick, and nobody else's picker offers Admin.
await open(); const kim = await row('kim@shop.com')
expect([(await cells('kim@shop.com')).slice(2, 4), kim.queryByRole('combobox')]).toEqual([['Admin', 'Everything'], null])
expect(within(screen.getByRole('combobox', { name: 'Role for lee@shop.com' })).getAllByRole('option').map(option => option.textContent)).toEqual(['Own set', 'Office', 'Sales', 'Support'])
// Opened: a plain line where the role would be picked, then what Admin gives.
// Her save changes nothing and asks nothing.
await fireEvent.click(kim.getByRole('link', { name: 'kim@shop.com' })); const opened = await panel('kim@shop.com')
const said = opened.getByText('Admin · only the owner changes this')
expect(said.compareDocumentPosition(opened.getByText(/Full trust\./)) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy()
expect([screen.queryByLabelText('Role'), boxes(), screen.queryByRole('group', { name: 'Managing' })]).toEqual([null, [], null])
await click('Save access'); await screen.findByText('Saved.')
expect([screen.queryByRole('alertdialog'), sent('people')]).toEqual([null, [{ email: 'kim@shop.com', removed: false, role: 'admin' }]])
// Someone who is not an Admin has no such line, and neither they nor a new person can be picked as one.
for (const [path, wait] of [['people/lee@shop.com', 'lee@shop.com'], ['people/new', 'Add person']]) {
cleanup(); await open(path); await panel(wait)
expect(screen.queryByText(/only the owner changes this/), path).toBeNull()
expect(within(role()).getAllByRole('option').map(option => option.textContent), path).toEqual(['Their own set', 'Office', 'Sales', 'Support'])
}
await fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'new@shop.com' } }); await click('Save access'); await screen.findByText('Saved.')
expect(sent('people')[1]).toEqual({ email: 'new@shop.com', removed: false, role: null, apps: NO_APPS, keys: NO_KEYS })
})
// Done closes the popup a save opened.
const done = async () => {
await fireEvent.click(within(await screen.findByRole('alertdialog')).getByRole('button', { name: 'Done' }))
await waitFor(() => expect(screen.queryByRole('alertdialog')).toBeNull())
}
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| slack-gif-creatoranthropics/skillsKnowledge and utilities for creating animated GIFs optimized for Slack. Provides constraints, validation tools, and animation concepts. Use when users request animated GIFs for Slack like "make me a GIF of X doing Y for Slack." | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |
| ponytailDietrichGebert/ponytailLazy senior dev mode for any coding task: the smallest change that fully solves it, and a reply a busy human understands in one read. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-debtDietrichGebert/ponytailHarvest every shortcut: comment into one debt ledger, so deferrals get tracked instead of forgotten. One-shot report. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-debtDietrichGebert/ponytailList every `shortcut:` comment (and older `ponytail:` ones) as a debt ledger. One-shot report, changes nothing. Use for "ponytail debt", "what did ponytail defer", "list the shortcuts", /ponytail-debt. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |