liferay/liferay-portal / .claude/skills/pr-check
pr-check
VerifiedCheck that a PR is ready to be sent for review.
validations/portal/portlet-title.md
View on GitHub# Portlet Title
A new portlet needs a matching `jakarta.portlet.title.<portlet name>` language key. A missing key fails `PortletTitleTest`, which lives in a test module the pull request never touches, so nothing else here catches it.
## Match
`(^|/)[^/]+Portlet\.java$`
## Command
This check is static and needs no build. List the added `jakarta.portlet.name=` lines:
```bash
bash "${SKILL_DIR}/select_paths.sh" "${MERGE_BASE}" "${VALIDATION_FILE}" \
| xargs git diff "${MERGE_BASE}...HEAD" --
```
For each line, work out the portlet name from a string literal or from the value of a referenced `*PortletKeys` constant, reading that constant and joining its string fragments when needed. Then confirm that a `jakarta.portlet.title.<name>=` line exists in the global `portal-language-lang` `Language.properties` or in the module's own `content/Language.properties`, and report any missing key as a FAIL.
Like `PortletTitleTest`, skip `ObjectDefinitionsPortlet` names, whose title comes from the object definition rather than a key.
## Time Estimate
~10-30 sec (static; no build).Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 323k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 323k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 323k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 323k | Updated | Claude CodeCodex | Verified | Install |