Skip to content

liferay/liferay-portal / .claude/skills/pr-check

pr-check

Verified

Check that a PR is ready to be sent for review.

FileKindSize
SKILL.mdskill md36.5 KB
find_modules.shexecutablescript1.4 KB
references/testing.mdmarkdown5.4 KB
select_paths.shexecutablescript2.2 KB
select_validations.shexecutablescript1.1 KB
validations/branch/bean-param-util-getter.mdmarkdown6.6 KB
validations/branch/bnd-content.mdmarkdown15.2 KB
validations/branch/bnd-dsannotations-options.mdmarkdown9.1 KB
validations/branch/cache-field-usage.mdmarkdown13.9 KB
validations/branch/concurrent-mapper-hash-map-usage.mdmarkdown7.5 KB
validations/branch/html-escaping.mdmarkdown2.6 KB
validations/branch/pr-reviewer.mdmarkdown6.6 KB
validations/branch/redundant-assert-message.mdmarkdown13.5 KB
validations/branch/required-configuration-policy.mdmarkdown7.9 KB
validations/branch/service-holder-usage.mdmarkdown8.3 KB
validations/branch/service-registration.mdmarkdown3.7 KB
validations/branch/source-format.mdmarkdown4.1 KB
validations/branch/startup-sync-usage.mdmarkdown10.6 KB
validations/branch/transaction-usage.mdmarkdown4.0 KB
validations/branch/unused-project-dependencies.mdmarkdown18.5 KB
validations/portal/baseline.mdmarkdown14.0 KB
validations/portal/cross-module-compile.mdmarkdown7.9 KB
validations/portal/full-portal-build.mdmarkdown1.4 KB
validations/portal/go-generate.mdmarkdown2.8 KB
validations/portal/go-source-format.mdmarkdown1.9 KB
validations/portal/helm-unit-test-order.mdmarkdown1.4 KB
validations/portal/instance-wrapper-build.mdmarkdown656 B
validations/portal/java-unit-test.mdmarkdown6.7 KB
validations/portal/javascript-unit-test.mdmarkdown7.7 KB
validations/portal/module-registration.mdmarkdown7.8 KB
validations/portal/per-module-compile.mdmarkdown10.4 KB
validations/portal/portlet-title.mdmarkdown1.1 KB
validations/portal/poshi-syntax.mdmarkdown336 B
validations/portal/pql-validation.mdmarkdown516 B
validations/portal/rest-builder.mdmarkdown938 B
validations/portal/service-builder.mdmarkdown1.6 KB
validations/portal/structural-smoke.mdmarkdown3.9 KB
validations/portal/theme-build.mdmarkdown2.0 KB
validations/workspaces/generated-file.mdmarkdown2.5 KB
validations/workspaces/source-format.mdmarkdown2.0 KB
validations/workspaces/workspace-compile.mdmarkdown1.8 KB
validations/workspaces/workspace-java-unit-test.mdmarkdown1.7 KB
validations/workspaces/workspace-javascript-unit-test.mdmarkdown1.9 KB

find_modules.sh

View on GitHub
#!/usr/bin/env bash

function main {
	cd "$(git rev-parse --show-toplevel)" || exit 1

	local path

	while IFS= read -r path
	do
		local marker_files="bnd.bnd build.xml gulpfile.js src/main/resources/application.properties"
		local themes=true

		if echo "${path}" | grep --extended-regexp "^workspaces/[^/]+-workspace/" > /dev/null
		then
			marker_files="bnd.bnd client-extension.yaml"
			themes=false
		fi

		local dir
		local module=-

		dir=$(dirname "${path}")

		while [[ ${dir} != . ]] &&
			  [[ ${dir} != / ]]
		do
			if _has_marker_file "${dir}" "${marker_files}" "${1}" ||
			   { [[ ${themes} == true ]] && _is_theme "${dir}" "${1}"; }
			then
				module=${dir}
			fi

			dir=$(dirname "${dir}")
		done

		echo "${module} ${path}"
	done
}

function _has_marker_file {
	if [[ ${1} == modules ]]
	then
		return 1
	fi

	local marker_file

	for marker_file in ${2}
	do
		if [[ -e ${1}/${marker_file} ]]
		then
			return 0
		fi
	done

	if [[ -d ${1} ]]
	then
		return 1
	fi

	for marker_file in ${2}
	do
		if git cat-file -e "${3}:${1}/${marker_file}" 2> /dev/null
		then
			return 0
		fi
	done

	return 1
}

function _is_theme {
	if [[ ${1} == modules ]]
	then
		return 1
	fi

	if [[ -d ${1} ]]
	then
		grep --quiet '"liferayTheme"' "${1}/package.json" 2> /dev/null

		return
	fi

	git show "${2}:${1}/package.json" 2> /dev/null | grep --quiet '"liferayTheme"'
}

main "${@}"
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 322kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 322kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 322kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 322kUpdated Claude CodeCodexVerifiedInstall