JPeetz/agent-skills / skills/development/mattpocock-dev-workflows
mattpocock-dev-workflows
VerifiedUse when you need Matt Pocock's engineering workflow patterns: spec synthesis, deep-module design, domain modeling, two-axis code review, or disciplined bug diagnosis. A meta-skill covering five complementary sub-patterns for real engineering — not vibe coding.
| File | Kind | Size |
|---|---|---|
| CHANGELOG.md | markdown | 2.0 KB |
| LICENSE | other | 1.1 KB |
| SKILL.md | skill md | 20.6 KB |
| evals/evals.json | config | 5.2 KB |
| references/adr-format.md | markdown | 2.7 KB |
| references/code-review-smell-baseline.md | markdown | 2.2 KB |
| references/codebase-design-glossary.md | markdown | 2.7 KB |
| references/context-format.md | markdown | 2.3 KB |
| references/deepening.md | markdown | 2.5 KB |
| references/design-it-twice.md | markdown | 2.6 KB |
| references/diagnosing-bugs-phases.md | markdown | 7.2 KB |
| references/to-spec-template.md | markdown | 1.6 KB |
references/code-review-smell-baseline.md
View on GitHub# Code Review Smell Baseline
These are the Fowler code smells from *Refactoring* (ch.3) that apply in
every code review, even when the repo documents no coding standards.
## Rules
- **The repo overrides.** A documented repo standard always wins; where it
endorses something the baseline would flag, suppress the smell.
- **Always a judgement call.** Each smell is a labelled heuristic ("possible
Feature Envy"), never a hard violation.
- **Skip anything tooling already enforces** (linters, formatters, type
checkers).
## The Smells
### Mysterious Name
A function, variable, or type whose name doesn't reveal what it does or
holds. → Rename it; if no honest name comes, the design's murky.
### Duplicated Code
The same logic shape appears in more than one hunk or file in the change.
→ Extract the shared shape, call it from both.
### Feature Envy
A method that reaches into another object's data more than its own.
→ Move the method onto the data it envies.
### Data Clumps
The same few fields or params keep travelling together (a type wanting to
be born). → Bundle them into one type, pass that.
### Primitive Obsession
A primitive or string standing in for a domain concept that deserves its
own type. → Give the concept its own small type.
### Repeated Switches
The same `switch`/`if`-cascade on the same type recurs across the change.
→ Replace with polymorphism, or one map both sites share.
### Shotgun Surgery
One logical change forces scattered edits across many files in the diff.
→ Gather what changes together into one module.
### Divergent Change
One file or module is edited for several unrelated reasons.
→ Split so each module changes for one reason.
### Speculative Generality
Abstraction, parameters, or hooks added for needs the spec doesn't have.
→ Delete it; inline back until a real need shows.
### Message Chains
Long `a.b().c().d()` navigation the caller shouldn't depend on.
→ Hide the walk behind one method on the first object.
### Middle Man
A class or function that mostly just delegates onward.
→ Cut it, call the real target direct.
### Refused Bequest
A subclass or implementer that ignores or overrides most of what it
inherits. → Drop the inheritance, use composition.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| brainstormingobra/superpowersYou MUST use this before any creative work - creating features, building components, adding functionality, modifying behavior, or planning anything new, in software or out of it (a talk, a business, a renovation). | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| brand-guidelinesanthropics/skillsApplies Anthropic's official brand colors and typography to any sort of artifact that may benefit from having Anthropic's look-and-feel. Use it when brand colors or style guidelines, visual formatting, or company design standards apply. | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |
| frontend-designanthropics/skillsGuidance for distinctive, intentional visual design when building new UI or reshaping an existing one. Helps with aesthetic direction, typography, and making choices that don't read as templated defaults. | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |
| mcp-builderanthropics/skillsGuide for creating high-quality MCP (Model Context Protocol) servers that enable LLMs to interact with external services through well-designed tools. Use when building MCP servers to integrate external APIs or services, whether in Python (FastMCP) or Node/TypeScript (MCP SDK). | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |