Skip to content

JetBrains/thinkrail / packages/pi-thinkrail-workflow/skills/shipping-a-pr

shipping-a-pr

Verified

Use when finished work needs to ship as a pull request, or when creating, syncing, updating metadata, checking status, monitoring CI, or addressing review comments on a PR. Not for reviewing a PR you are not shipping.

FileKindSize
SKILL.mdskill md4.2 KB
body.mdmarkdown1.3 KB
checks.mdmarkdown3.9 KB
creating.mdmarkdown4.7 KB
review-comments.mdmarkdown1.7 KB
screenshots.mdmarkdown2.8 KB
syncing.mdmarkdown1.6 KB

review-comments.md

View on GitHub
# review-comments.md — address comments, never blindly

Entry: an open PR has review comments to address. Saves nothing. Snapshot mode is the default whether
or not an accepted fix is pushed. Preserve wait mode only when selected by the spine's explicit
remote-completion rule.

1. **Whole-PR read first.** Fetch every comment thread and the full diff (`gh pr view <n>
   --comments`, `gh api repos/<owner>/<repo>/pulls/<n>/comments --paginate`), then re-read the PR's changes
   end to end. Each comment is judged against the whole change, not just its quoted lines.
2. **Verdict per comment, before touching code**: *apply* (it's right), *push back* (it's wrong or
   misreads the design — say why, citing the spec or design), or *clarify* (genuinely ambiguous —
   ask the reviewer or the user). Batch the verdicts; surface them to the user whenever any verdict
   is push-back.
3. Apply the accepted ones as proper changes, then apply the spine's final-tree verification rule.
   Commit everything and repeat that rule if verification causes another fix; push only when evidence
   covers the clean final tree. **Reply to every thread** only after the push lands: what changed and
   where (naming the commit), or the push-back rationale. Resolve only threads actually addressed.

Red flags:

- Patching exactly the quoted line without reading the surrounding design — "do not fix them
  blindly" is this doc's founding requirement.
- Replying "done" without a pushed commit that shows it.
- Silently skipping a comment — every thread gets an answer.

## Next

Read and follow `checks.md` in the selected completion mode, including snapshot mode after an ordinary
pushed fix.
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 322kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 322kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 322kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 322kUpdated Claude CodeCodexVerifiedInstall