jaktestowac/awesome-copilot-for-testers / plugins/code-review-advanced/skills/code-review-advanced
code-review-advanced
VerifiedPerforms evidence-driven code review for pull requests, legacy modules, and quality-critical changes. Use when reviewing complex or multi-file changes, test automation suites, architectural refactors, or hot paths that need analysis of correctness, maintainability, security, performance, test quality, and operability risks. Provides structured feedback with severity-ranked findings, actionable recommendations, and clear rationale. For a fast sanity check of a small diff or single file, use the code-review skill instead.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 8.8 KB |
| resources/example-review.md | markdown | 5.4 KB |
| resources/review-checklist.md | markdown | 4.7 KB |
| resources/review-report-template.md | markdown | 2.2 KB |
| resources/test-automation-review-lens.md | markdown | 2.9 KB |
resources/example-review.md
View on GitHub# Example Advanced Review
## Review Metadata
- **Scope:** `tests/auth/login.spec.ts`, `src/pages/LoginPage.ts`, `src/fixtures/user.ts`
- **Review goal:** `merge readiness, test quality, and maintainability`
- **Change type:** `feature + test automation`
- **Assumptions / missing context:** `No linked ticket was provided, so expected rate-limiting behavior and analytics requirements are inferred from the code.`
## Executive Summary
This change improves login coverage and introduces a reusable page object, which is a solid direction. The main concerns are not about syntax but about confidence: the tests rely on hard waits, the negative-path assertion is too weak, and the page object now mixes navigation, state setup, and assertions. The feature looks close, but I would not approve it yet because the current tests could still pass while the login flow regresses under timing or error conditions.
## Recommendation
**Status:** `request changes`
**Why:**
- The suite uses fixed waits instead of web-first synchronization, which is a direct flakiness risk.
- The negative login test verifies only that an error element exists, not that the application stays unauthenticated.
- The page object is taking on multiple responsibilities, which will make future auth flows harder to extend safely.
## What Looks Strong
- The author extracted selectors into a page object instead of duplicating them across tests.
- The tests cover both a successful and unsuccessful login path.
- Fixture-based test data is clearer than inline credentials scattered across the spec.
## Findings Overview
| Severity | Area | Summary | Evidence | Suggested action |
| -------- | --------------- | -------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------- | --------------------------------------------------------------------------------------- |
| High | Testing | Hard waits make the new login tests timing-sensitive and likely flaky in CI. | `tests/auth/login.spec.ts` uses `waitForTimeout(3000)` after submit. | Replace fixed waits with assertions on visible post-login state or response completion. |
| High | Correctness | The invalid-login test does not prove the user remains unauthenticated. | The test checks only that `.error-message` is visible. | Assert the protected landing page is not reachable and auth state remains unchanged. |
| Medium | Maintainability | `LoginPage` mixes navigation, form actions, and business assertions. | `src/pages/LoginPage.ts` includes `goto`, `loginAs`, and `expectLoggedIn`. | Split action methods from verification helpers or keep assertions in the spec layer. |
| Low | Security | Test fixture naming suggests real-looking credentials that could be mistaken for reusable secrets. | `src/fixtures/user.ts` contains `admin@company.com` style values. | Switch to clearly fake identities to reduce confusion and accidental reuse. |
## Detailed Findings
### 1. Hard waits in the happy-path test
- **Severity:** `High`
- **Area:** `Testing`
- **Evidence:** The success scenario waits for a fixed 3000 ms after clicking submit instead of waiting on a user-visible success condition.
- **Risk:** This creates a classic CI flake: the test is slower than necessary when the app is fast and still unstable when the app is slow.
- **Recommendation:** Wait for a deterministic signal such as dashboard heading visibility, redirected URL, or authenticated API response completion.
### 2. Weak negative-path assertion
- **Severity:** `High`
- **Area:** `Correctness`
- **Evidence:** The failing-login test checks that an error banner appears, but it does not verify that the app stayed on the login page or that authenticated UI remains inaccessible.
- **Risk:** A partially broken auth flow could still pass this test if the banner renders while session state changes incorrectly.
- **Recommendation:** Add assertions that the protected route is not entered and that authenticated-only controls remain hidden.
### 3. Page object owns too much behavior
- **Severity:** `Medium`
- **Area:** `Maintainability`
- **Evidence:** `LoginPage` currently navigates, fills the form, submits, and performs business-level assertions.
- **Risk:** This will make the page object harder to reuse for other auth variants like SSO, MFA, or password reset because state checks are tightly bundled with actions.
- **Recommendation:** Keep reusable interaction methods in the page object and leave scenario-specific assertions in tests or dedicated helper methods.
## Missing or Weak Coverage
- No assertion for the preserved unauthenticated state after invalid credentials.
- No coverage for server-side auth failure or retry behavior.
- No verification that session-related UI is restored after refresh.
## Follow-up Suggestions
- Add one focused regression test for repeated failed logins if rate-limiting or lockout is expected behavior.
- Consider a shared auth helper only if multiple specs repeat the same flow after the page object responsibilities are clarified.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |