Skip to content

huangjia2019/claude-code-engineering / 04-Skills/projects/00-basic-skill

code-reviewing

Verified

Review code for quality, security, and best practices. Use when the user asks for code review, wants feedback on their code, mentions reviewing changes, or asks about code quality.

FileKindSize
README.mdmarkdown1.6 KB
SKILL.mdskill md1.9 KB
src/auth.jsscript2.3 KB

src/auth.js

View on GitHub
/**
 * 认证模块 - 故意包含安全问题供审查练习
 * WARNING: 这是教学示例,不要用于生产环境!
 */

// 问题 1: 硬编码的密钥
const SECRET_KEY = 'super-secret-key-12345';
const API_KEY = 'sk-live-abcdef123456';

// 问题 2: 弱密码验证
function validatePassword(password) {
  // 只检查长度,没有复杂度要求
  return password.length >= 6;
}

// 问题 3: 不安全的 token 生成
function generateToken(userId) {
  // 使用可预测的方式生成 token
  const timestamp = Date.now();
  return Buffer.from(`${userId}:${timestamp}`).toString('base64');
}

// 问题 4: 明文存储密码比较
function checkPassword(inputPassword, storedPassword) {
  // 应该使用 bcrypt 等哈希比较
  return inputPassword === storedPassword;
}

// 问题 5: 信息泄露的错误消息
function login(username, password) {
  const user = findUserByUsername(username);

  if (!user) {
    // 泄露用户是否存在
    throw new Error(`User '${username}' not found`);
  }

  if (!checkPassword(password, user.password)) {
    // 应该使用统一的错误消息
    throw new Error('Invalid password');
  }

  return {
    token: generateToken(user.id),
    // 问题 6: 返回过多用户信息
    user: {
      id: user.id,
      username: user.username,
      email: user.email,
      password: user.password,  // 不应该返回密码!
      role: user.role,
      internalNotes: user.internalNotes  // 内部信息泄露
    }
  };
}

// 问题 7: 无会话过期
function verifyToken(token) {
  const decoded = Buffer.from(token, 'base64').toString();
  const [userId, timestamp] = decoded.split(':');
  // 没有检查 token 是否过期
  return { userId, timestamp };
}

// 问题 8: eval 使用
function processUserConfig(configString) {
  // 危险!允许代码注入
  return eval('(' + configString + ')');
}

// 模拟函数
function findUserByUsername(username) {
  const users = {
    'admin': {
      id: 1,
      username: 'admin',
      password: 'admin123',  // 弱密码
      email: 'admin@example.com',
      role: 'admin',
      internalNotes: 'Super user with all permissions'
    }
  };
  return users[username];
}

module.exports = {
  validatePassword,
  generateToken,
  checkPassword,
  login,
  verifyToken,
  processUserConfig,
  SECRET_KEY,
  API_KEY
};
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 467kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 467kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 467kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 193kUpdated Claude CodeCodexVerifiedInstall