GravionLabs/elysion / .agents/skills/code-review
code-review
VerifiedReview a diff against acceptance criteria and language rules; blocking findings versus notes. Use for "review this code".
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 2.9 KB |
| references/governance.md | markdown | 1.5 KB |
| references/reviewer-contract.md | markdown | 3.1 KB |
| schema/review.schema.json | config | 794 B |
| scripts/ConvertTo-Findings.ps1 | script | 2.8 KB |
| scripts/Get-GovernanceMatches.ps1 | script | 4.1 KB |
references/reviewer-contract.md
View on GitHub# Reviewer contract
How `code-review` behaves as the reviewer role when a runner (such as `deliver`) or a caller starts it. Interactive use is the same review; only the output differs.
## Input
- the diff under review (`git diff <base>...HEAD`)
- the acceptance criteria of the issue or PBI
- the role `review` (the default); `SKILL.md` step 3 passes it to `Get-Lessons.ps1 -Role`
- the `## Review rules` of the `<lang>-implementation` skills from `detect-techstack`
- the `## Review rules` of the `<lang>-test` skills from `detect-techstack`, applied to the test files of the diff; a skill without that section is skipped
## Blocking
A finding is **blocking** when it breaks an acceptance criterion or is a correctness or security defect. Everything else is a note: style, naming, performance without a measured problem, API taste, refactors.
Security is part of every review: injection, unvalidated input, secrets in code or logs, broken authorization, unsafe deserialization, path traversal. A confirmed defect is blocking; a doubt goes into `notes`.
A missing or weak test for changed behavior is blocking only when a criterion requires that behavior to be tested or the untested path is itself a correctness defect.
## Result
Print one JSON object that validates against `schema/review.schema.json`, nothing else.
| Property | Meaning |
| ---------- | ------------------------------------------------------------------------------------------- |
| `blocking` | findings that must be fixed before merge; empty when none |
| `file` | path relative to the repository root |
| `line` | 1-based line in the new version of the file |
| `title` | the defect in one line |
| `why` | which criterion or defect class it breaks, and the fix direction |
| `rule` | optional on a blocking item: `adr-missing` or `spec-drift`, from `references/governance.md` |
| `notes` | non-blocking observations, one string each |
```json
{
"blocking": [
{
"file": "src/parse.ts",
"line": 42,
"title": "Empty input throws instead of returning []",
"why": "Criterion 2 requires [] for empty input; guard before the split."
}
],
"notes": ["`parseAll` could reuse `parse`"]
}
```
## Output form `findings`
On request (`form: findings`) print the result in the findings format of poimen instead (`{ version, sha, source, findings[] }`, schema `findings.schema.json` in the docs of GravionLabs/poimen), to stdout only: `code-review` stays read-only and the caller saves the file. The mapping lives in `pwsh scripts/ConvertTo-Findings.ps1 -Review <result.json> -Sha <reviewed commit>`: `blocking[]` keeps `file`, `line`, `title`, `why`, `rule` with severity `blocking`; `unmet[]` is `blocking` without location; `notes[]` is `note` without location.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |