Skip to content

gracefullight/pkgs / .agents/skills/oma-qa

oma-qa

Verified

Review changes for correctness, security, accessibility, and performance. Use for scoped quality reviews or verification plans; bug fixes use oma-debug.

resources/verify-ship-protocol.md

View on GitHub
# VERIFY/SHIP Phase Protocol

Execution guide for VERIFY Phase (Steps 6-8) and SHIP Phase (Steps 14-17) in ultrawork workflow.

---

## VERIFY Phase (Steps 6-8)

### Step 6: Alignment Review

**Review Question**: "Did we build what was requested?"

- [ ] Plan vs implementation 1:1 comparison
- [ ] Misalignments documented
- [ ] No missing features

---

### Step 7: Security/Bug Review

**Review Question**: "Is there anything dangerous?"

**Automated Tools:**
- `npm audit` (Node.js)
- `bandit` (Python)
- `lighthouse` (web performance)

**OWASP Top 10 Check:**
- [ ] No injection vulnerabilities
- [ ] No authentication flaws
- [ ] No sensitive data exposure
- [ ] No XXE vulnerabilities
- [ ] No access control flaws

**Finding Format:**
- File:line
- Description
- Severity (CRITICAL/HIGH/MEDIUM/LOW)
- Fix suggestion

---

### Step 8: Improvement Review

**Review Question**: "Did improvements break anything?"

- [ ] Affected regression checks pass; broaden only for identified impact
- [ ] Existing features work normally
- [ ] New code matches existing patterns

---

### VERIFY_GATE Checklist

- [ ] Implementation = Requirements
- [ ] CRITICAL issues: 0
- [ ] HIGH issues: 0
- [ ] No regressions

**Gate failure → Return to Step 5 (fix implementation)**

---

## SHIP Phase (Steps 14-17)

### Step 14: Code Quality Review

**Review Question**: "Does it meet quality standards?"

- [ ] lint passes
- [ ] type check passes
- [ ] applicable project or task-defined coverage target met, or alternative verification recorded
- [ ] Applicable cross-domain checks from `_shared/core/common-checklist.md` pass

---

### Step 15: UX Flow Verification

- [ ] End-to-end user journey test
- [ ] Error states verified
- [ ] Loading states verified
- [ ] Accessibility compliance (WCAG 2.2 AA)

---

### Step 16: Related Issues Review

**Review Question**: "Did we break anything elsewhere?"

- [ ] Issues discovered during review checked
- [ ] Related areas not broken
- [ ] Deferred items documented (next sprint)

---

### Step 17: Deployment Readiness Review

**Review Question**: "Is this ready to deploy?"

- [ ] No hardcoded secrets
- [ ] Environment variables documented
- [ ] Migrations safe
- [ ] Rollback possible
- [ ] Monitoring ready

---

### SHIP_GATE Checklist

- [ ] All quality checks pass
- [ ] UX verified
- [ ] Related issues resolved
- [ ] Deployment checklist complete
- [ ] Scope and any external action are authorized under the shared execution policy; reuse existing authorization

**Gate failure → Return to appropriate phase based on failure type**
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall