existential-birds/beagle / plugins/beagle-elixir/skills/phoenix-code-review
phoenix-code-review
VerifiedReviews Phoenix code for controller patterns, context boundaries, routing, and plugs. Use when reviewing Phoenix apps, checking controllers, routers, or context modules.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 3.4 KB |
| references/contexts.md | markdown | 2.6 KB |
| references/controllers.md | markdown | 2.6 KB |
| references/plugs.md | markdown | 3.0 KB |
| references/routing.md | markdown | 2.3 KB |
references/routing.md
View on GitHub# Phoenix Routing
## Verified Routes
### Use ~p Sigil
```elixir
# GOOD - verified at compile time
~p"/users/#{user.id}"
~p"/users/#{user}/edit"
# BAD - string interpolation (no compile-time check)
"/users/#{user.id}"
"/users/#{user.id}/edit"
```
### In Templates
```heex
<%# GOOD %>
<.link navigate={~p"/users/#{@user}"}>Profile</.link>
<%# BAD %>
<.link navigate={"/users/#{@user.id}"}>Profile</.link>
```
## Pipelines
### Group Related Plugs
```elixir
pipeline :browser do
plug :accepts, ["html"]
plug :fetch_session
plug :fetch_live_flash
plug :put_root_layout, html: {MyAppWeb.Layouts, :root}
plug :protect_from_forgery
plug :put_secure_browser_headers
end
pipeline :api do
plug :accepts, ["json"]
end
pipeline :authenticated do
plug MyAppWeb.Plugs.RequireAuth
plug MyAppWeb.Plugs.LoadCurrentUser
end
```
### Compose Pipelines
```elixir
scope "/", MyAppWeb do
pipe_through [:browser, :authenticated]
resources "/settings", SettingsController, only: [:edit, :update]
end
scope "/admin", MyAppWeb.Admin do
pipe_through [:browser, :authenticated, :require_admin]
resources "/users", UserController
end
```
## Resources
### Limit Actions
```elixir
# GOOD - only needed actions
resources "/users", UserController, only: [:index, :show, :create]
resources "/sessions", SessionController, only: [:new, :create, :delete]
# BAD - all actions when not needed
resources "/users", UserController # Generates 7 routes
```
### Nested Resources
```elixir
# GOOD - shallow nesting
resources "/posts", PostController do
resources "/comments", CommentController, only: [:create]
end
resources "/comments", CommentController, only: [:show, :update, :delete]
# BAD - deep nesting
resources "/users", UserController do
resources "/posts", PostController do
resources "/comments", CommentController # Too deep!
end
end
```
## Scopes
```elixir
# API versioning
scope "/api", MyAppWeb.API do
scope "/v1", V1 do
pipe_through :api
resources "/users", UserController
end
scope "/v2", V2 do
pipe_through [:api, :v2_transforms]
resources "/users", UserController
end
end
```
## Review Questions
1. Are verified routes (~p) used instead of string paths?
2. Are pipelines composed for authentication/authorization?
3. Do resources specify only needed actions?
4. Is nesting kept shallow (max 1 level)?
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |