existential-birds/beagle / plugins/beagle-elixir/skills/phoenix-code-review
phoenix-code-review
VerifiedReviews Phoenix code for controller patterns, context boundaries, routing, and plugs. Use when reviewing Phoenix apps, checking controllers, routers, or context modules.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 3.4 KB |
| references/contexts.md | markdown | 2.6 KB |
| references/controllers.md | markdown | 2.6 KB |
| references/plugs.md | markdown | 3.0 KB |
| references/routing.md | markdown | 2.3 KB |
references/controllers.md
View on GitHub# Phoenix Controllers
## Action Structure
### Keep Controllers Thin
```elixir
# GOOD - delegates to context
defmodule MyAppWeb.UserController do
use MyAppWeb, :controller
alias MyApp.Accounts
def create(conn, %{"user" => user_params}) do
case Accounts.register_user(user_params) do
{:ok, user} ->
conn
|> put_status(:created)
|> render(:show, user: user)
{:error, changeset} ->
conn
|> put_status(:unprocessable_entity)
|> render(:error, changeset: changeset)
end
end
end
# BAD - business logic in controller
defmodule MyAppWeb.UserController do
def create(conn, %{"user" => params}) do
changeset = User.changeset(%User{}, params)
if changeset.valid? do
# Validation logic here...
# Email verification logic here...
# Password hashing here...
end
end
end
```
### Action Fallback
```elixir
defmodule MyAppWeb.UserController do
use MyAppWeb, :controller
action_fallback MyAppWeb.FallbackController
def show(conn, %{"id" => id}) do
with {:ok, user} <- Accounts.get_user(id) do
render(conn, :show, user: user)
end
end
end
defmodule MyAppWeb.FallbackController do
use MyAppWeb, :controller
def call(conn, {:error, :not_found}) do
conn
|> put_status(:not_found)
|> put_view(MyAppWeb.ErrorJSON)
|> render(:"404")
end
def call(conn, {:error, %Ecto.Changeset{} = changeset}) do
conn
|> put_status(:unprocessable_entity)
|> put_view(MyAppWeb.ChangesetJSON)
|> render(:error, changeset: changeset)
end
end
```
## Parameter Handling
### Pattern Match in Function Head
```elixir
# GOOD - pattern match expected params
def update(conn, %{"id" => id, "user" => user_params}) do
# ...
end
# GOOD - handle missing params explicitly
def update(conn, %{"id" => id}) do
conn
|> put_status(:bad_request)
|> json(%{error: "Missing user params"})
end
```
### Strong Parameters via Changesets
```elixir
# Changeset controls which fields are accepted
def registration_changeset(user, attrs) do
user
|> cast(attrs, [:email, :password, :name]) # Only these fields
|> validate_required([:email, :password])
end
```
## HTTP Status Codes
| Action | Success | Common Errors |
|--------|---------|---------------|
| create | 201 Created | 422 Unprocessable |
| show | 200 OK | 404 Not Found |
| update | 200 OK | 404, 422 |
| delete | 204 No Content | 404 |
| index | 200 OK | - |
## Review Questions
1. Is business logic delegated to contexts?
2. Do actions use appropriate HTTP status codes?
3. Is action_fallback used for consistent error handling?
4. Are parameters validated via changesets?
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |