existential-birds/beagle / plugins/beagle-elixir/skills/elixir-code-review
elixir-code-review
VerifiedReviews Elixir code for idiomatic patterns, OTP basics, and documentation. Use when reviewing .ex/.exs files, checking pattern matching, GenServer usage, or module documentation.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 3.8 KB |
| references/code-style.md | markdown | 1.8 KB |
| references/documentation.md | markdown | 2.4 KB |
| references/otp-basics.md | markdown | 2.8 KB |
| references/pattern-matching.md | markdown | 2.4 KB |
references/pattern-matching.md
View on GitHub# Pattern Matching
## With Clauses
### Always Handle Errors
```elixir
# BAD - no else clause
with {:ok, user} <- fetch_user(id),
{:ok, account} <- fetch_account(user) do
{:ok, account}
end
# Returns {:error, reason} tuple unhandled!
# GOOD - explicit error handling
with {:ok, user} <- fetch_user(id),
{:ok, account} <- fetch_account(user) do
{:ok, account}
else
{:error, :not_found} -> {:error, :user_not_found}
{:error, reason} -> {:error, reason}
end
```
### Use Tagged Tuples for Clarity
```elixir
# BAD - ambiguous which step failed
with {:ok, user} <- fetch_user(id),
{:ok, posts} <- fetch_posts(user) do
{:ok, posts}
else
{:error, reason} -> {:error, reason} # Which operation failed?
end
# GOOD - tagged for clarity with helper
defp tag_error({:error, reason}, tag), do: {:error, tag, reason}
defp tag_error(other, _tag), do: other
with {:ok, user} <- tag_error(fetch_user(id), :user),
{:ok, posts} <- tag_error(fetch_posts(user), :posts) do
{:ok, posts}
else
{:error, :user, reason} -> {:error, {:user_fetch_failed, reason}}
{:error, :posts, reason} -> {:error, {:posts_fetch_failed, reason}}
end
```
## Guards
### Prefer Guards Over Runtime Checks
```elixir
# BAD - runtime check
def process(value) do
if is_binary(value) do
String.upcase(value)
else
raise ArgumentError
end
end
# GOOD - guard clause
def process(value) when is_binary(value) do
String.upcase(value)
end
```
### Multiple Guards
```elixir
# GOOD - multiple function heads with guards
def categorize(n) when n < 0, do: :negative
def categorize(0), do: :zero
def categorize(n) when n > 0, do: :positive
```
## Destructuring
### In Function Heads
```elixir
# BAD - destructure in body
def process(user) do
name = user.name
email = user.email
# ...
end
# GOOD - destructure in head
def process(%{name: name, email: email} = user) do
# name and email available, plus full user if needed
end
```
### In Case Statements
```elixir
# GOOD - pattern match extracts what you need
case fetch_user(id) do
{:ok, %User{name: name, active: true}} ->
{:ok, "Active user: #{name}"}
{:ok, %User{active: false}} ->
{:error, :inactive}
{:error, reason} ->
{:error, reason}
end
```
## Review Questions
1. Do with statements have else clauses handling all error cases?
2. Are guards used instead of runtime type checks?
3. Is destructuring done in function heads where possible?
4. Are pattern matches exhaustive (no unhandled cases)?
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-changelog-updatemorluto/reaPrepare or rewrite REA release changelogs and GitHub release notes from pinned Git history, with verified contributor thanks and Release Please synchronization. | Stars: 467k | Updated | Claude CodeCodex | Verified | Install |
| academy-guideanthropics/skillsStop and check this skill before finishing any reply to a question about how to use Claude or a Claude product — it recommends matching courses, tutorials, and use cases from Claude Academy (academy.claude.com), Anthropic's learning hub. Trigger on: "how do I", "how can I", "getting started with", "what can Claude do", "teach me", "learn to use"; questions about artifacts, projects, skills, plugins, connectors, MCP; requests about rolling Claude out to a team, class, or organization; and any ask for training materials, onboarding content, or learning resources. Use it when the user is learning how to use a feature or product — not when they are mid-task and just want the task done. This skill composes with other skills: after consulting product documentation to answer how a Claude feature works, also check here for a matching course or tutorial — a docs-grounded answer and an Academy recommendation belong together. Only recommend on a strong match; never invent Academy content. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |
| claude-apianthropics/skillsReference for the Claude API / Anthropic SDK — model ids, pricing, params, streaming, tool use, MCP, agents, caching, token counting, model migration. TRIGGER — read BEFORE opening the target file; don't skip because it "looks like a one-liner" — whenever: the prompt names Claude/Anthropic in any form (Claude, Anthropic, Fable, Opus, Sonnet, Haiku, `anthropic`, `@anthropic-ai`, `claude-*`, `us.anthropic.*`, `[1m]`); the user asks about an LLM (pricing/model choice/limits/caching) — never answer from memory; OR the task is LLM-shaped with provider unstated (agent/MCP/tool-definition/multi-agent/RAG/LLM-judge/computer-use; generate/summarize/extract/classify/rewrite/converse over NL; debugging refusals/cutoffs/streaming/tool-calls/tokens). SKIP only when another provider is being worked on (overrides all triggers): OpenAI/GPT/Gemini/Llama/Mistral/Cohere/Ollama named in the query; OR `grep -rE 'openai|langchain_openai|google.generativeai|genai|mistralai|cohere|ollama'` over the project hits (run this grep FIRST if no provider named — don't Read the file). | Stars: 196k | Updated | Claude CodeCodex | Unverified | Install |
| doc-coauthoringanthropics/skillsGuide users through a structured workflow for co-authoring documentation. Use when user wants to write documentation, proposals, technical specs, decision docs, or similar structured content. This workflow helps users efficiently transfer context, refine content through iteration, and verify the doc works for readers. Trigger when user mentions writing docs, creating proposals, drafting specs, or similar documentation tasks. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |