existential-birds/beagle / plugins/beagle-elixir/skills/elixir-code-review
elixir-code-review
VerifiedReviews Elixir code for idiomatic patterns, OTP basics, and documentation. Use when reviewing .ex/.exs files, checking pattern matching, GenServer usage, or module documentation.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 3.8 KB |
| references/code-style.md | markdown | 1.8 KB |
| references/documentation.md | markdown | 2.4 KB |
| references/otp-basics.md | markdown | 2.8 KB |
| references/pattern-matching.md | markdown | 2.4 KB |
references/otp-basics.md
View on GitHub# OTP Basics
## GenServer
### Use handle_continue for Expensive Init
```elixir
# BAD - blocks supervisor during init
def init(args) do
data = expensive_operation() # Blocks!
{:ok, data}
end
# GOOD - defers expensive work
def init(args) do
{:ok, %{data: nil}, {:continue, :load_data}}
end
@impl true
def handle_continue(:load_data, state) do
data = expensive_operation()
{:noreply, %{state | data: data}}
end
```
### Call vs Cast
```elixir
# call - synchronous, returns result
def get_value(pid) do
GenServer.call(pid, :get_value)
end
# cast - asynchronous, fire-and-forget
def increment(pid) do
GenServer.cast(pid, :increment)
end
```
**When to use each:**
- `call` - Need the result, need confirmation, queries
- `cast` - Fire-and-forget, notifications, can't block caller
### Timeouts
```elixir
# Always consider timeouts for calls
def fetch_data(pid) do
GenServer.call(pid, :fetch_data, 10_000) # 10 second timeout
end
# Handle timeout in caller
case GenServer.call(pid, :fetch, 5_000) do
{:ok, data} -> data
{:error, reason} -> handle_error(reason)
rescue
exit -> {:error, :timeout}
end
```
## Supervisor
### Restart Strategies
| Strategy | When to Use |
|----------|-------------|
| `:one_for_one` | Children are independent |
| `:one_for_all` | Children are interdependent |
| `:rest_for_one` | Later children depend on earlier |
### Child Specs
```elixir
# GOOD - explicit child spec
children = [
{MyWorker, [name: :worker, arg: value]},
{DynamicSupervisor, name: MyApp.DynamicSup, strategy: :one_for_one}
]
Supervisor.init(children, strategy: :one_for_one)
```
## Common Anti-Patterns
### Blocking in Callbacks
```elixir
# BAD - blocks the GenServer
@impl true
def handle_call(:fetch_external, _from, state) do
result = HTTPClient.get!(url) # Blocks all other messages!
{:reply, result, state}
end
# GOOD - use Task for async work
@impl true
def handle_call(:fetch_external, from, state) do
Task.async(fn -> HTTPClient.get!(url) end)
{:noreply, %{state | pending: from}}
end
@impl true
def handle_info({ref, result}, %{pending: from} = state) do
GenServer.reply(from, result)
{:noreply, %{state | pending: nil}}
end
```
### Single Process Bottleneck
```elixir
# BAD - all requests through one GenServer
defmodule Cache do
use GenServer
def get(key), do: GenServer.call(__MODULE__, {:get, key})
def put(key, val), do: GenServer.call(__MODULE__, {:put, key, val})
end
# GOOD - use ETS for read-heavy workloads
defmodule Cache do
def get(key), do: :ets.lookup(:cache, key)
def put(key, val), do: :ets.insert(:cache, {key, val})
end
```
## Review Questions
1. Does GenServer init do expensive work synchronously?
2. Are call/cast used appropriately (sync vs async)?
3. Is there a single GenServer becoming a bottleneck?
4. Do supervisors use appropriate restart strategies?
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-changelog-updatemorluto/reaPrepare or rewrite REA release changelogs and GitHub release notes from pinned Git history, with verified contributor thanks and Release Please synchronization. | Stars: 470k | Updated | Claude CodeCodex | Verified | Install |
| academy-guideanthropics/skillsStop and check this skill before finishing any reply to a question about how to use Claude or a Claude product — it recommends matching courses, tutorials, and use cases from Claude Academy (academy.claude.com), Anthropic's learning hub. Trigger on: "how do I", "how can I", "getting started with", "what can Claude do", "teach me", "learn to use"; questions about artifacts, projects, skills, plugins, connectors, MCP; requests about rolling Claude out to a team, class, or organization; and any ask for training materials, onboarding content, or learning resources. Use it when the user is learning how to use a feature or product — not when they are mid-task and just want the task done. This skill composes with other skills: after consulting product documentation to answer how a Claude feature works, also check here for a matching course or tutorial — a docs-grounded answer and an Academy recommendation belong together. Only recommend on a strong match; never invent Academy content. | Stars: 197k | Updated | Claude CodeCodex | Verified | Install |
| claude-apianthropics/skillsReference for the Claude API / Anthropic SDK — model ids, pricing, params, streaming, tool use, MCP, agents, caching, token counting, model migration. TRIGGER — read BEFORE opening the target file; don't skip because it "looks like a one-liner" — whenever: the prompt names Claude/Anthropic in any form (Claude, Anthropic, Fable, Opus, Sonnet, Haiku, `anthropic`, `@anthropic-ai`, `claude-*`, `us.anthropic.*`, `[1m]`); the user asks about an LLM (pricing/model choice/limits/caching) — never answer from memory; OR the task is LLM-shaped with provider unstated (agent/MCP/tool-definition/multi-agent/RAG/LLM-judge/computer-use; generate/summarize/extract/classify/rewrite/converse over NL; debugging refusals/cutoffs/streaming/tool-calls/tokens). SKIP only when another provider is being worked on (overrides all triggers): OpenAI/GPT/Gemini/Llama/Mistral/Cohere/Ollama named in the query; OR `grep -rE 'openai|langchain_openai|google.generativeai|genai|mistralai|cohere|ollama'` over the project hits (run this grep FIRST if no provider named — don't Read the file). | Stars: 197k | Updated | Claude CodeCodex | Unverified | Install |
| doc-coauthoringanthropics/skillsGuide users through a structured workflow for co-authoring documentation. Use when user wants to write documentation, proposals, technical specs, decision docs, or similar structured content. This workflow helps users efficiently transfer context, refine content through iteration, and verify the doc works for readers. Trigger when user mentions writing docs, creating proposals, drafting specs, or similar documentation tasks. | Stars: 197k | Updated | Claude CodeCodex | Verified | Install |