Skip to content

ericrisco/rsc-harness / skills/review

review

Verified

Use when a diff needs adversarial judgment in rsc ASDD — per task inside implement's loop (depth set by `rsc risk`: none, one fresh-context reviewer, or the three-refuter panel) or as the closing review of the whole branch against the spec — keyed to the spec/plan/constitution in 02-DOCS/wiki/sdd/ and the project's REVIEW.md; or receive a review and verify each comment before agreeing. Converges via `rsc review ledger` (max 3 rounds, no repeated finding). NOT running lint/type/tests (that is `verify`), NOT the spec-less standalone pass (that is `code-review`), NOT merging (that is `ship`).

FileKindSize
SKILL.mdskill md27.7 KB
evals/README.mdmarkdown3.9 KB
evals/cases.yamlconfig6.0 KB

evals/cases.yaml

View on GitHub
skill: review

should_trigger:
  - prompt: "Can you review this PR before I merge it? It refactors the order-total calculation and adds a discount field."
    why: "Explicit 'review this PR before merge' — the flagship giving-a-review trigger, on a correctness-sensitive money path. Squarely the review phase."
  - prompt: "Revisa este diff y dime qué está mal antes de hacer ship."
    why: "Spanish 'review this diff, tell me what's wrong, before ship' — same trigger in the user's other language, and explicitly the gate that sits before ship."
  - prompt: "The reviewer left a comment saying my function can NPE if the user is null. Do I actually have to change it?"
    why: "Non-obvious RECEIVING-side trigger: the user is processing incoming feedback and is unsure whether to comply. The skill's verify-before-acting half owns exactly this."
  - prompt: "A bot left like twelve comments on my PR. Most look like nitpicks. Which ones should I actually act on?"
    why: "Receiving a machine review and needing to triage real findings from noise — the gate (restate/verify/classify/act) and the nit-vs-blocker ranking are the core capability."
  - prompt: "Tear this change apart for me — I want the harshest review you can give before it goes out."
    why: "Adversarial framing with no literal 'review the PR' phrasing ('tear this apart', 'harshest'). This is the giving-a-review role at full rigor."
  - prompt: "My teammate said I should rewrite this whole module, but I think the current code already handles the case they're worried about. What do I do?"
    why: "Receiving a review that may be a false finding; the user wants to push back with evidence rather than blindly comply. The skill's pushback-with-a-trace discipline applies."
  - prompt: "Critique my implementation against the spec — did I actually build what we specified or did I drift?"
    why: "Spec-fidelity pass (pass 1) explicitly invoked: checking the diff against 02-DOCS/wiki/sdd specs for scope drift. A giving-a-review trigger keyed to the SDD artifacts."

should_not_trigger:
  - prompt: "Run lint, type-check and the test suite on my branch and tell me if it's green."
    route_to: "verify"
    why: "Running the gates to green is the verify phase, not review — the verify skill owns exactly 'lint/type/test before merge', 'run the checks', 'are we green'. Review judges an already-green diff; this routes out to verify."
  - prompt: "The code's been reviewed and approved. Open the PR and merge it into main."
    route_to: "ship"
    why: "Closing the branch / opening the PR / merge with Eric-only authorship is the ship phase — the ship skill owns 'open the PR', 'merge into main', 'close the branch'. It is post-review, not review, so it routes out to ship."
  - prompt: "Do a security threat-model of this endpoint that fetches a user-supplied URL — what's the SSRF risk?"
    route_to: "security-audit"
    why: "A deep OWASP/SSRF threat-model is owned by security-audit. Review folds its findings in but defers the dedicated security pass; this is explicitly routed out in 'When NOT to use'."
  - prompt: "Is this the idiomatic way to write a Server Component data fetch in Next.js 15?"
    route_to: "nextjs"
    why: "A pure 'is this framework-idiomatic' question with no diff to judge belongs to the stack skill that owns the idiom, not the adversarial review gate."
  - prompt: "Write me a Postgres query for the top 5 customers by monthly order value."
    route_to: "postgresdb"
    why: "Authoring new SQL from scratch — there is no existing change to review. Query design is owned by the postgresdb skill."
  - prompt: "Rename this Go helper and split the formatting logic out — no behavior change, just tidy it up."
    route_to: "go"
    why: "A trivial mechanical refactor the author is performing themselves, not a review of someone's change. Routes to the Go skill for the idiom; nothing to review adversarially."

capability:
  - scenario: "Receiving review: a reviewer commented 'this can throw NPE if `user` is null' on the line `return user.documents.filter(owner=user.id)`. Two lines up, `user = require_auth(request)`. require_auth raises 401 on a null/absent session. Decide what to do."
    must_include:
      - "Runs the receiving gate: restates the claim, then VERIFIES it against the code instead of immediately editing."
      - "Traces that require_auth raises 401 before the flagged line, so `user` cannot be null there — classifies the finding as FALSE."
      - "Declines to change the working code (no performative 'good catch' edit)."
      - "Replies to the reviewer with the evidence/trace (require_auth raises 401), not just an assertion of disagreement."
      - "Adds or proposes a regression test (e.g. unauthenticated request asserts 401) so the guarantee stays true, strengthening the diff while declining the change."
      - "Logs the declined finding + reasoning to 02-DOCS/wiki/sdd/decisions.md."
  - scenario: "Giving review: review this diff before ship — `@router.get('/invoices/{invoice_id}') def get(invoice_id: int, db=Depends(get_db)): return db.get(Invoice, invoice_id)`, behind login. Spec said 'a user can view their own invoices'."
    must_include:
      - "Flags a [blocker]: authenticated != authorized — any logged-in user reads any invoice by id (IDOR / broken access control), and ties it to the spec ('their OWN invoices') as a fidelity failure."
      - "Provides evidence/repro (GET another user's invoice_id with a valid session returns 200 + body), not a vague 'consider authorizing'."
      - "Gives a concrete fix: scope the query by owner (WHERE id == invoice_id AND owner_id == current_user.id) and return 404 (not 403) on miss to avoid leaking existence."
      - "Ranks findings by severity (blocker vs nit) rather than an unranked list of opinions."
      - "Ends with an explicit verdict — CHANGES REQUESTED — and states exactly what unblocks the merge."
      - "Points to the next phase (ship) only once the blocker is resolved; routes the deep security angle to security-audit if a fuller pass is wanted."
finishing-a-development-branchobra/superpowersUse when implementation is complete, all tests pass, and you need to decide how to integrate the workStars: 322kUpdated Claude CodeCodexVerifiedInstall
systematic-debuggingobra/superpowersUse when encountering any bug, test failure, or unexpected behavior, before proposing fixesStars: 322kUpdated Claude CodeCodexVerifiedInstall
test-driven-developmentobra/superpowersUse when implementing any feature or bugfix, before writing implementation codeStars: 322kUpdated Claude CodeCodexVerifiedInstall
skill-creatoranthropics/skillsCreate new skills, modify and improve existing skills, and measure skill performance. Use when users want to create a skill from scratch, edit, or optimize an existing skill, run evals to test a skill, benchmark skill performance with variance analysis, or optimize a skill's description for better triggering accuracy.Stars: 198kUpdated Claude CodeCodexVerifiedInstall