Skip to content

ericrisco/rsc-harness / skills/code-review

code-review

Verified

Use to judge a concrete diff, branch, or GitHub PR on its own merits with no rsc-SDD spec/plan chain to key off — the spec-less giving pass behind /code-review: only findings you can defend, one verdict, read-only unless --comment or --fix. NOT the SDD gate keyed to 02-DOCS/wiki/sdd/ that also processes incoming review comments (that is `review`).

FileKindSize
SKILL.mdskill md9.4 KB
evals/README.mdmarkdown952 B
evals/cases.yamlconfig3.6 KB
references/pr-workflow.mdmarkdown3.5 KB

references/pr-workflow.md

View on GitHub
# PR review workflow — `gh` mechanics

Tooling depth for fetching a diff and posting review feedback end to end. Nothing here is posted or applied unless the user passed `--comment` or `--fix`. The body's pass order and confidence floor still govern *what* you report; this file is only *how*.

## Fetch the diff

```bash
# By PR number in the current repo
gh pr diff 1432
gh pr view 1432 --json title,body,files,additions,deletions,baseRefName,headRefName

# A PR in another repo (e.g. an OSS contribution you're reviewing)
gh pr diff 1432 --repo owner/name

# Fork PRs: the head branch lives on the contributor's fork. `gh pr diff`
# resolves it for you — no manual remote add needed. To check out locally:
gh pr checkout 1432

# A local branch with no PR yet
git diff main...HEAD          # everything since the branch diverged
git diff --stat main...HEAD   # blast radius first
```

Read the whole touched file, not just the hunk. `gh pr diff` shows only changed lines; open the file when a hunk's correctness depends on surrounding code.

## Post the verdict (summary review)

```bash
gh pr review 1432 --request-changes -b "CHANGES REQUESTED — 1 blocker, 2 should-fix. See inline."
gh pr review 1432 --approve        -b "APPROVE — correctness, contracts and security boundary clean."
gh pr review 1432 --comment        -b "APPROVE WITH NITS — non-blocking; see inline nits."
```

Pick exactly one of `--approve` / `--request-changes` / `--comment` to match the body's verdict. Note: you cannot `--approve` your own PR; on your own branch use `--comment`.

## Post inline line-anchored comments

Inline (line-anchored) comments beat PR-level prose for actionable feedback — they land on the exact line. The GitHub REST API takes one comment per call:

```bash
gh api repos/{owner}/{repo}/pulls/1432/comments \
  -f body='[should-fix] re-implements `cart.compute_subtotal()` and drops per-item discounts. Call the helper instead.' \
  -f commit_id="$(gh pr view 1432 --json headRefOid -q .headRefOid)" \
  -f path='api/orders.py' \
  -F line=88 \
  -f side='RIGHT'
```

- `path` is the file path as it appears in the diff.
- `line` is the line number in the file at `commit_id`.
- `side`: `RIGHT` for the new version (additions/context), `LEFT` for the old.
- Multi-line span: add `-F start_line=85 -f start_side='RIGHT'`.

To batch several inline comments into one pending review with a single verdict, use `POST /pulls/{n}/reviews` with a `comments[]` array and an `event` of `REQUEST_CHANGES` / `APPROVE` / `COMMENT` — see the GitHub "Create a review for a pull request" API. Otherwise individual `pulls/{n}/comments` calls post immediately and unbatched.

## Large-diff strategy

When the diff is too big to hold in one pass:

1. `git diff --stat` (or the `files` array from `gh pr view`) to rank files by churn.
2. Review by file or by commit (`gh pr diff` per commit SHA), hot paths first — auth, money, data migrations, anything user-input-facing.
3. Generated/vendored files (lockfiles, snapshots, `dist/`) get a structural skim for surprises, not a line-by-line read.
4. Carry findings across files: a contract change in one file is only a finding if a caller in another file breaks — confirm the caller.

## Read-only default

The review itself touches nothing. Posting (`--comment`) and editing (`--fix`) are explicit opt-ins. With `--fix`, branch first if you are on the default branch, apply only the agreed findings, and commit/push only when the user asks. Git authorship is Eric — no Claude co-author or generated footer on any commit or PR body.
rea-changelog-updatemorluto/reaPrepare or rewrite REA release changelogs and GitHub release notes from pinned Git history, with verified contributor thanks and Release Please synchronization.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
academy-guideanthropics/skillsStop and check this skill before finishing any reply to a question about how to use Claude or a Claude product — it recommends matching courses, tutorials, and use cases from Claude Academy (academy.claude.com), Anthropic's learning hub. Trigger on: "how do I", "how can I", "getting started with", "what can Claude do", "teach me", "learn to use"; questions about artifacts, projects, skills, plugins, connectors, MCP; requests about rolling Claude out to a team, class, or organization; and any ask for training materials, onboarding content, or learning resources. Use it when the user is learning how to use a feature or product — not when they are mid-task and just want the task done. This skill composes with other skills: after consulting product documentation to answer how a Claude feature works, also check here for a matching course or tutorial — a docs-grounded answer and an Academy recommendation belong together. Only recommend on a strong match; never invent Academy content.Stars: 198kUpdated Claude CodeCodexVerifiedInstall
claude-apianthropics/skillsReference for the Claude API / Anthropic SDK — model ids, pricing, params, streaming, tool use, MCP, agents, caching, token counting, model migration. TRIGGER — read BEFORE opening the target file; don't skip because it "looks like a one-liner" — whenever: the prompt names Claude/Anthropic in any form (Claude, Anthropic, Fable, Opus, Sonnet, Haiku, `anthropic`, `@anthropic-ai`, `claude-*`, `us.anthropic.*`, `[1m]`); the user asks about an LLM (pricing/model choice/limits/caching) — never answer from memory; OR the task is LLM-shaped with provider unstated (agent/MCP/tool-definition/multi-agent/RAG/LLM-judge/computer-use; generate/summarize/extract/classify/rewrite/converse over NL; debugging refusals/cutoffs/streaming/tool-calls/tokens). SKIP only when another provider is being worked on (overrides all triggers): OpenAI/GPT/Gemini/Llama/Mistral/Cohere/Ollama named in the query; OR `grep -rE 'openai|langchain_openai|google.generativeai|genai|mistralai|cohere|ollama'` over the project hits (run this grep FIRST if no provider named — don't Read the file).Stars: 198kUpdated Claude CodeCodexUnverifiedInstall
doc-coauthoringanthropics/skillsGuide users through a structured workflow for co-authoring documentation. Use when user wants to write documentation, proposals, technical specs, decision docs, or similar structured content. This workflow helps users efficiently transfer context, refine content through iteration, and verify the doc works for readers. Trigger when user mentions writing docs, creating proposals, drafting specs, or similar documentation tasks.Stars: 198kUpdated Claude CodeCodexVerifiedInstall