ericrisco/rsc-harness / skills/code-review
code-review
VerifiedUse to judge a concrete diff, branch, or GitHub PR on its own merits with no rsc-SDD spec/plan chain to key off — the spec-less giving pass behind /code-review: only findings you can defend, one verdict, read-only unless --comment or --fix. NOT the SDD gate keyed to 02-DOCS/wiki/sdd/ that also processes incoming review comments (that is `review`).
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 9.4 KB |
| evals/README.md | markdown | 952 B |
| evals/cases.yaml | config | 3.6 KB |
| references/pr-workflow.md | markdown | 3.5 KB |
evals/cases.yaml
View on GitHubskill: code-review
should_trigger:
- prompt: "review this PR before I merge it"
why: Core diff/PR review on its own merits with no SDD spec/plan chain — the spec-less giving pass.
- prompt: "revisa este diff, ¿está bien?"
why: Spanish phrasing for a standalone diff judgment with no project artifact chain.
- prompt: "què està malament en aquest canvi?"
why: Catalan phrasing — judge a concrete change for defects, no spec required.
- prompt: "is this dependency bump safe to merge?"
why: Non-obvious — a diff with almost no code still needs supply-chain/transitive review; this is the giving pass on a bump.
- prompt: "a contractor pushed a branch, tear it apart"
why: Inbound external change where you have only the diff + stated intent, no rsc-SDD artifacts to key off.
- prompt: "/code-review --comment 1432"
why: Running the executable discipline by hand, in comment-posting mode.
- prompt: "give me a high-signal review of this change, no nitpicks"
why: Names the signal-to-noise north star directly — exactly this skill's defining trait.
should_not_trigger:
- prompt: "the reviewer left comments — do I have to make these changes?"
route_to: review
why: That is the receiving loop keyed to the SDD review gate, which review owns; code-review is giving-only.
- prompt: "run the lint, type-check and test gate and make it green"
route_to: verify
why: Running the gates to prove green is the verify phase; code-review judges whether green is correct.
- prompt: "threat-model this upload endpoint for OWASP issues with fixed diffs"
route_to: security-audit
why: A deep STRIDE/OWASP exploitability pass with vulnerable→fixed diffs is security-audit; code-review does only a boundary pass.
- prompt: "this test is flaky, find the root cause"
route_to: debug
why: Root-causing one confirmed failure is debug; code-review surveys a change for latent defects.
- prompt: "open the PR and merge it now that it's approved"
route_to: ship
why: PR/merge/close after approval is ship; code-review only produces the verdict ship consumes.
- prompt: "cross-check the spec, plan and tasks before we write any code"
route_to: analyze
why: Pre-code consistency across SDD artifacts is analyze; code-review reads the diff after code exists.
capability:
- scenario: |
Review a PR diff for a checkout service that contains TWO things:
(a) a real correctness bug — the new code re-implements an existing
`cart.compute_subtotal()` helper inline as `sum(i.price * i.qty ...)`,
silently dropping the per-item discount the helper applies; and
(b) a planted non-bug — a call that interpolates a value into a SQL
string and *looks* like injection, but the value is a server-derived
enum already validated upstream in the same function (guarded upstream).
The user asked for a review and did NOT pass --comment or --fix.
must_include:
- Flags the duplicated/discount-dropping logic as [blocking] or [should-fix] with where/why/repro/fix.
- Does NOT flag the guarded SQL call as a blocker — either omits it or labels it [question] only after stating it traced the value to an upstream validation (signal-to-noise discipline).
- Emits exactly one verdict — APPROVE, APPROVE WITH NITS, or CHANGES REQUESTED.
- Ranks findings by blast radius × reachability with no severity inflation.
- Stays read-only — posts no PR comment and applies no fix, since neither --comment nor --fix was requested.
- States the assumed intent when reasoning about the change.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-changelog-updatemorluto/reaPrepare or rewrite REA release changelogs and GitHub release notes from pinned Git history, with verified contributor thanks and Release Please synchronization. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| academy-guideanthropics/skillsStop and check this skill before finishing any reply to a question about how to use Claude or a Claude product — it recommends matching courses, tutorials, and use cases from Claude Academy (academy.claude.com), Anthropic's learning hub. Trigger on: "how do I", "how can I", "getting started with", "what can Claude do", "teach me", "learn to use"; questions about artifacts, projects, skills, plugins, connectors, MCP; requests about rolling Claude out to a team, class, or organization; and any ask for training materials, onboarding content, or learning resources. Use it when the user is learning how to use a feature or product — not when they are mid-task and just want the task done. This skill composes with other skills: after consulting product documentation to answer how a Claude feature works, also check here for a matching course or tutorial — a docs-grounded answer and an Academy recommendation belong together. Only recommend on a strong match; never invent Academy content. | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |
| claude-apianthropics/skillsReference for the Claude API / Anthropic SDK — model ids, pricing, params, streaming, tool use, MCP, agents, caching, token counting, model migration. TRIGGER — read BEFORE opening the target file; don't skip because it "looks like a one-liner" — whenever: the prompt names Claude/Anthropic in any form (Claude, Anthropic, Fable, Opus, Sonnet, Haiku, `anthropic`, `@anthropic-ai`, `claude-*`, `us.anthropic.*`, `[1m]`); the user asks about an LLM (pricing/model choice/limits/caching) — never answer from memory; OR the task is LLM-shaped with provider unstated (agent/MCP/tool-definition/multi-agent/RAG/LLM-judge/computer-use; generate/summarize/extract/classify/rewrite/converse over NL; debugging refusals/cutoffs/streaming/tool-calls/tokens). SKIP only when another provider is being worked on (overrides all triggers): OpenAI/GPT/Gemini/Llama/Mistral/Cohere/Ollama named in the query; OR `grep -rE 'openai|langchain_openai|google.generativeai|genai|mistralai|cohere|ollama'` over the project hits (run this grep FIRST if no provider named — don't Read the file). | Stars: 198k | Updated | Claude CodeCodex | Unverified | Install |
| doc-coauthoringanthropics/skillsGuide users through a structured workflow for co-authoring documentation. Use when user wants to write documentation, proposals, technical specs, decision docs, or similar structured content. This workflow helps users efficiently transfer context, refine content through iteration, and verify the doc works for readers. Trigger when user mentions writing docs, creating proposals, drafting specs, or similar documentation tasks. | Stars: 198k | Updated | Claude CodeCodex | Verified | Install |