ederfmatos/claude-voice-bridge / .claude/skills/cy-review-round
cy-review-round
VerifiedPerforms a comprehensive code review of a PRD implementation and generates a review round directory with issue files compatible with cy-fix-reviews. Use when reviewing implemented PRD tasks, creating a manual review round without an external provider, or performing a quality audit of code changes. Do not use for fetching reviews from external providers, fixing existing review issues, executing PRD tasks, or editing source code.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 9.2 KB |
| references/issue-template.md | markdown | 1.9 KB |
| references/review-criteria.md | markdown | 4.4 KB |
references/review-criteria.md
View on GitHub# Review Criteria
## Severity Levels
### critical
Security flaws, crashes, data loss, undefined behavior, or race conditions.
Issues that could cause production incidents or compromise user data.
Examples: authentication bypass, SQL/command injection, nil pointer dereference
on a hot path, unbounded goroutine leak, writing sensitive data to logs.
### high
Bugs affecting correctness, performance bottlenecks visible to users, or
anti-patterns that significantly impair scalability, reliability, or usability.
These need fixing before merge.
Examples: logic error returning wrong results, O(n^2) loop over unbounded
input, missing transaction rollback, error silently swallowed in a critical
path, missing input validation at a system boundary.
### medium
Maintainability concerns, code smells, test coverage gaps, or non-idiomatic
patterns that degrade long-term health. Not blocking but should be addressed.
Examples: duplicated logic across packages, function exceeding 80 lines with
deep nesting, missing test for an error branch, context.Background() used
outside main, interface accepted but only one implementation exists.
### low
Minor improvements, documentation gaps, or naming suggestions. Optional
enhancements that improve clarity.
Examples: unclear variable name, missing godoc on an exported function,
redundant type conversion, slightly misleading comment.
## Evaluation Areas
### 1. Security
- Authentication and authorization flaws.
- Input validation gaps (injection, path traversal, XSS).
- Hardcoded secrets, tokens, or credentials.
- Cryptography misuse or insecure storage.
- Sensitive data exposure in logs or error messages.
### 2. Correctness
- Logic errors producing wrong results.
- Off-by-one and boundary condition bugs.
- Nil or null pointer dereferences.
- Unhandled error paths leading to silent failures.
- Incorrect type assertions or conversions.
### 3. Concurrency
- Race conditions and missing synchronization.
- Goroutine leaks (no shutdown path or context cancellation).
- Deadlock potential from lock ordering.
- Channel misuse (send on closed, unbuffered blocking).
- Missing `sync.WaitGroup` tracking for spawned goroutines.
### 4. Performance and Scalability
- Algorithmic complexity issues (O(n^2) where O(n) suffices).
- Resource leaks (file handles, HTTP bodies, database connections).
- Unbounded growth in slices, maps, or channels.
- Missing caching for repeated expensive operations.
- Blocking I/O on critical paths without timeout.
### 5. Error Handling
- Swallowed errors (assigned to `_` without justification).
- Missing error context (`fmt.Errorf("context: %w", err)`).
- `panic()` or `log.Fatal()` in library or handler code.
- Broad catch-all error handling masking specific failures.
- Incorrect use of `errors.Is()` or `errors.As()`.
### 6. Code Quality and Maintainability
- Readability issues (unclear naming, deeply nested logic).
- Code duplication across functions or packages.
- Overly complex functions that should be decomposed.
- Dead code or unused exports.
- Violations of project coding conventions.
### 7. Testing
- Missing tests for critical code paths.
- Tests that verify mocks instead of behavior.
- Flaky test patterns (time-dependent, order-dependent).
- Inadequate edge case and error path coverage.
- Missing `t.Parallel()` for independent subtests.
### 8. Architecture
- Circular dependencies between packages.
- Layer violations (e.g., CLI package importing internal runtime details).
- Leaky abstractions exposing implementation details.
- Tight coupling that prevents independent testing.
- Inconsistent patterns within the same codebase area.
### 9. Operations
- Missing or insufficient structured logging (`slog`).
- Missing error context for production debugging.
- Configuration values hardcoded instead of parameterized.
- Missing graceful shutdown handling for long-running processes.
- Observability gaps (no metrics or tracing on critical operations).
## Review Approach
- Read the PRD and TechSpec before reviewing code to understand intent.
- Review in severity order: critical first, low last.
- Focus on issues that matter. Skip style issues already caught by linters.
- Provide actionable suggestions: state the problem and what the fix looks like.
- Assign severity based on actual impact, not theoretical concern.
- Create one issue per file per distinct problem.
- If one problem spans multiple files, create one issue per affected file.
- Acknowledge well-implemented patterns; do not create issues for them.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 196k | Updated | Claude CodeCodex | Verified | Install |