DexForce/EmbodiChain / .agents/skills/review-pr
review-pr
VerifiedReview EmbodiChain pull requests, branches, commits, patches, or working-tree diffs for correctness regressions, architecture-contract violations, compatibility risks, unsafe resource behavior, and test coverage or necessity issues. Use when asked to review, audit, inspect, assess, or approve an EmbodiChain change; coordinate independent expert reviewers when subagents are available, and produce prioritized, evidence-backed findings without modifying the change unless the user explicitly asks for fixes.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 20.3 KB |
| agents/openai.yaml | config | 393 B |
| references/expert-protocol.md | markdown | 6.4 KB |
| references/review-matrix.md | markdown | 14.7 KB |
| references/reviewer-perspectives.md | markdown | 4.7 KB |
references/expert-protocol.md
View on GitHub# Expert review protocol
## Lead preparation and dispatch
1. Pin the review target: repository, base/head commits (or a local diff
snapshot including untracked files), changed-file inventory, and intended
behavior. All reviewers must use the same delta. Read PR files at the pinned
head, not an unrelated working tree. If the target changes, reconcile the
affected passes before calling the review complete.
2. Select relevant role IDs using `reviewer-perspectives.md`. Usually two to
four roles suffice for a substantive change; a narrow change may need only
one. This is not a quota: cover every affected contract, with bounded scopes
and intentional overlap at integration boundaries.
3. When subagents are available and permitted, dispatch independent selected
passes using the host's subagent tool (for example `spawn_agent`). Respect
concurrency limits, queue remaining roles, and keep the lead working on
uncovered files and integration while experts run. Do not substitute
user-owned tasks/threads for subagents. Tool availability alone does not
override host restrictions or a user's request for single-agent review.
4. Give each expert the packet below. Prefer a fresh context containing raw
artifacts rather than the lead's candidate findings or another expert's
conclusions. Independent first passes reduce anchoring; exchange evidence
later when resolving a concrete disagreement. An expert may inspect contract
neighbors beyond its initial file list when needed to establish reachability.
Use a task packet with these fields (Markdown is sufficient):
For a dedicated supplemental pass, use the `reliability` or `verification`
role ID and responsibilities defined in SKILL.md consistently in the packet,
result, candidate IDs, and role-coverage row. If the lens is included in an
existing expert's assignment, retain that expert's role ID and name the lens
in its scope, returned coverage, and coverage-table evidence. For example, an
`engine` reviewer covering `reliability` returns `engine-*` candidates under
the `engine` row; a dedicated `reliability` reviewer returns `reliability-*`
candidates under its own row. Do not count an embedded lens as an independent
reviewer or add a second completed role row for it.
```text
Assignment: delegated expert pass; do not delegate further.
Role: <stable role ID and its responsibilities from SKILL.md>
Target: <repository; base/head SHA or snapshot; diff access>
Scope: <changed files/contracts; questions to investigate, without predicted answers>
Context: <applicable AGENTS.md; canonical skill directory; matched context paths>
Constraints: read-only review; no Git mutation, edits, or remote publication;
follow the skill's proportional validation limits.
Return: the expert result contract below, including zero findings and limitations.
```
An expert loads its assigned role, applicable review contract, matrix sections,
and evidence standard from the canonical skill; it must not restart the lead's
dispatch workflow. The lead alone owns the final report. Remote publication,
when separately requested, remains governed by SKILL.md.
## Expert result contract
Every selected role returns a result, even when it finds no actionable defect:
- **Identity and target:** role ID, actual agent ID when available, reviewed
base/head or snapshot identifier.
- **Coverage and status:** `complete` or `partial` for the assigned scope;
inspected changed files and important callers/contracts; explicit omissions.
- **Candidates:** use stable local IDs such as `robotics-1`. For each, give
proposed priority, smallest changed location, reachable input/state, violated
contract, observable impact, and supporting code or reproduction. Explain
guards/tests checked, how behavior differs from the base, and a correction
direction when useful. Return `none` rather than inventing a finding.
- **Validation and limitations:** actual commands/results, checks not run,
unresolved questions, and unavailable runtime or dependency surfaces.
This is an evidence summary, not a request to expose private reasoning. Do not
require one defect per expert. A complete static pass may still disclose that
GPU/hardware execution was not tested; distinguish that limit from files or
contracts the expert could not inspect.
## Lead verification and synthesis
Wait for every dispatched result, or record its failure and missing scope.
Check that each result used the pinned target and covers the assigned contract;
request a focused follow-up for an omitted scope or unsupported claim. Do not
label a launched, timed-out, or missing reviewer as complete.
For each candidate, the lead independently checks the cited code and reachable
scenario under SKILL.md's proof standard. Agreement between experts is not
proof, and a minority finding may still be correct. Deduplicate by root cause,
retain contributing candidate IDs, and assign final priority by demonstrated
impact. Record each candidate as accepted, merged into another candidate,
rejected with a short evidence-based reason, or unresolved. Unresolved claims
belong in open questions or residual risks, not confirmed findings.
The lead checks the full changed-file inventory against expert and lead
coverage, reviews remaining integration gaps, then produces the findings,
findings-summary, review-summary, and role-coverage tables from SKILL.md.
The coverage table records actual executors, results, and candidate dispositions;
it must not imply that naming a role proves an independent review occurred.
## Fallback and interrupted work
If subagent tools are unavailable, prohibited, explicitly disabled by the user,
or fail, disclose the specific reason. Execute each remaining selected role as
a separate lead pass with the same result contract and explicit role scope.
Label this `single-agent fallback`; if any independent expert results were
also used, label the overall run `mixed`. Do not claim independent contexts
or fabricate agent IDs for lead passes.
Temporary capacity limits normally require queuing, not silent fallback.
After a dispatch or worker failure, one bounded retry is reasonable; otherwise
complete the missing scope locally or report it as incomplete. Preserve valid
results and rerun only missing coverage. If the task ends with an unreviewed
scope, report `partial`/`unavailable` and the reason, and apply SKILL.md's
incomplete-review assessment. Never translate an unavailable expert into
"no findings" or an approval recommendation.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics. | Stars: 471k | Updated | Claude CodeCodex | Verified | Install |
| ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first. | Stars: 194k | Updated | Claude CodeCodex | Verified | Install |