Skip to content

bruce48x/Lakona / .agents/skills/lakona-architecture-review

lakona-architecture-review

Verified

Perform an explicitly requested, read-only Lakona architecture and framework-health review; honor any specified reduced scope.

references/micro-code-smells.md

View on GitHub
# 2. Micro Code Smells

Review every maintained handwritten source, project, test, workflow, and script
file in the inventory. Inspect neighboring callers and tests when a smell
depends on usage. Look for small but real friction, including:

- strange branches, impossible states, ineffective guards, and silent fallback
- unused state, parameters, abstractions, options, and configuration
- one-line forwarding types, single-use helpers, and test-only production seams
- duplicate registration, conversion, validation, or cleanup logic
- stringly dispatch or reflection where typed information already exists
- nullable or boolean flags that hide lifecycle states
- unnecessary public surface and friend declarations
- dependencies constructed or resolved in surprising places
- ownership split between a method and its callers
- cancellation, disposal, async, and error handling that is correct only by
  convention
- names or indirection that force maintainers to jump between files to
  understand one concept

Do not report formatting preferences or generic style advice. A micro finding
must identify a concrete maintenance cost, failure risk, misleading contract,
or unnecessary concept. Keep its local scope visible instead of inflating it
into a broad architecture claim.

A documented repository standard is never generic style. When a finding is a
breach of a rule in `CONTRIBUTING.md`, `docs/contributing/engineering.md`, or
`docs/contributing/testing.md`, report it under Pass 8 with the rule cited.
Pass 2 reports design judgement; rule conformance belongs to Pass 8.
receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementationStars: 322kUpdated Claude CodeCodexVerifiedInstall
requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirementsStars: 322kUpdated Claude CodeCodexVerifiedInstall
using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallbackStars: 322kUpdated Claude CodeCodexVerifiedInstall
verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions alwaysStars: 322kUpdated Claude CodeCodexVerifiedInstall