borghei/Claude-Skills / engineering/pr-description-writer
pr-description-writer
VerifiedWrite PR descriptions with evidence, verification steps and a one-way/two-way merge-risk call. Use when opening a PR, when asked to write or fix a PR body, or when checking a description before requesting review.
| File | Kind | Size |
|---|---|---|
| SKILL.md | skill md | 12.7 KB |
| assets/pr-body-template.md | markdown | 1.3 KB |
| assets/sample_changed_files.json | config | 419 B |
| assets/sample_migration.diff | other | 990 B |
| assets/sample_pr_body_flawed.md | markdown | 604 B |
| assets/sample_pr_body_good.md | markdown | 2.3 KB |
| references/merge-risk-classification.md | markdown | 6.7 KB |
| references/pr-body-anatomy.md | markdown | 6.3 KB |
| scripts/pr_body_lint.pyexecutable | script | 12.3 KB |
| scripts/risk_classifier.pyexecutable | script | 12.1 KB |
assets/sample_pr_body_good.md
View on GitHub## Summary
Split `customers.full_name` into `given_name` and `family_name` (expand phase only). The API returns all three fields; nothing reads the new columns yet.
```diff
Customer
id
full_name # still written and returned
+ given_name # new, nullable, backfilled
+ family_name # new, nullable, backfilled
```
## Why
Invoices for customers in Hungary and Japan print names in the wrong order because we guess the split at render time. Billing asked for stored, editable name parts (BILL-412). This PR adds the columns and backfills them; switching reads happens in a follow-up.
## Evidence
**Before:** invoice preview for customer `c_8812` renders "Tanaka Yuki" as "Yuki Tanaka".
**After:** the backfill stores `given_name=Yuki`, `family_name=Tanaka`; the preview is unchanged because reads still use `full_name`.
```text
$ pytest tests/customers/test_name_split.py -q
........ [100%]
8 passed in 0.41s
$ python manage.py migrate --plan
db/migrations/20261102_split_customer_name (add 2 nullable columns, backfill 41,203 rows in batches of 5,000)
```
Staging run: https://ci.example.com/actions/runs/88123 (migration 38 s, no lock waits over 200 ms).
## How to verify
1. `make db-reset && python manage.py migrate` on a local database seeded with `make seed-customers`.
2. `psql -c "select count(*) from customers where given_name is null and full_name <> ''"` returns 0.
3. `curl -s localhost:8000/api/customers/c_8812 | jq '.given_name, .family_name, .full_name'` prints all three.
4. Run the suite: `pytest tests/customers -q`.
## Merge risk
**Classification:** One-way door. The migration adds and backfills columns; reverting the code leaves the columns in place.
**Blast radius:** the `customers` table (41k rows) and the public `Customer` schema in `api/openapi.yaml`. Clients ignoring unknown fields are unaffected.
**Rollback plan:** the columns are additive and nullable, so the safe rollback is to revert the application code and leave the schema; nothing reads the new columns yet. If the backfill itself misbehaves, the on-call engineer runs `python manage.py migrate customers 0047` (down-migration drops both columns, about 2 s on staging). `full_name` is never modified, so no data is lost either way.
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| receiving-code-reviewobra/superpowersUse when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| requesting-code-reviewobra/superpowersUse when completing tasks, implementing major features, or before merging to verify work meets requirements | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| using-git-worktreesobra/superpowersUse when starting feature work that needs isolation from current workspace or before executing implementation plans - ensures an isolated workspace exists via native tools or git worktree fallback | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| verification-before-completionobra/superpowersUse when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |