Skip to content

aiskillstore/marketplace / skills/89jobrien/code-review

code-review

Verified

Expert code review specialist for quality, security, and maintainability. Use when reviewing code changes, ensuring high development standards, or conducting security audits. Provides actionable feedback organized by priority.

FileKindSize
SKILL.mdskill md7.2 KB
references/code-analysis.template.mdmarkdown3.7 KB
references/review-checklist.mdmarkdown4.2 KB
skill-report.jsonconfig36.3 KB

references/review-checklist.md

View on GitHub
---
author: Joseph OBrien
status: unpublished
updated: '2025-12-23'
version: 1.0.1
tag: skill
type: reference
parent: code-review
---

# Code Review Checklist

Comprehensive checklist for conducting thorough code reviews across different aspects of code quality.

## Security Checklist

### Authentication & Authorization

- [ ] Proper authentication implemented
- [ ] Authorization checks on all protected routes
- [ ] Role-based access control (RBAC) implemented correctly
- [ ] Session management secure
- [ ] Token expiration handled
- [ ] Password hashing used (bcrypt, argon2, etc.)
- [ ] No hardcoded credentials

### Input Validation

- [ ] All user inputs validated
- [ ] SQL injection prevention (parameterized queries)
- [ ] XSS prevention (output encoding)
- [ ] CSRF protection implemented
- [ ] File upload validation (type, size, content)
- [ ] Path traversal prevention
- [ ] Input sanitization applied

### Data Protection

- [ ] Sensitive data encrypted at rest
- [ ] Sensitive data encrypted in transit (HTTPS)
- [ ] No secrets in code or config files
- [ ] Environment variables used for secrets
- [ ] API keys properly secured
- [ ] Database credentials secure
- [ ] Logs don't contain sensitive information

### Security Headers

- [ ] Security headers configured (CSP, HSTS, etc.)
- [ ] CORS properly configured
- [ ] Content Security Policy set
- [ ] X-Frame-Options set
- [ ] X-Content-Type-Options set

## Code Quality Checklist

### Readability

- [ ] Code is clear and self-documenting
- [ ] Variable names are descriptive
- [ ] Function names describe what they do
- [ ] Comments explain why, not what
- [ ] Code follows project style guide
- [ ] Consistent formatting

### Structure

- [ ] Functions do one thing
- [ ] Functions are appropriately sized (< 50 lines ideal)
- [ ] No code duplication (DRY principle)
- [ ] Proper separation of concerns
- [ ] Logical code organization
- [ ] Appropriate use of design patterns

### Error Handling

- [ ] Errors handled appropriately
- [ ] Error messages are helpful
- [ ] No silent failures
- [ ] Proper exception types used
- [ ] Error logging implemented
- [ ] Graceful degradation

## Performance Checklist

### Algorithm Efficiency

- [ ] Appropriate data structures used
- [ ] Algorithms are efficient (O(n) vs O(n²))
- [ ] No unnecessary loops
- [ ] Early returns used when possible
- [ ] Lazy loading implemented where appropriate

### Database

- [ ] Queries are optimized
- [ ] Appropriate indexes exist
- [ ] No N+1 query problems
- [ ] Connection pooling used
- [ ] Query result caching implemented
- [ ] Batch operations used when possible

### Resource Management

- [ ] Memory leaks prevented
- [ ] Resources properly closed/released
- [ ] Connection pooling implemented
- [ ] File handles closed
- [ ] Event listeners cleaned up
- [ ] Timers/intervals cleared

## Testing Checklist

### Test Coverage

- [ ] Unit tests for new code
- [ ] Integration tests for critical paths
- [ ] Edge cases tested
- [ ] Error cases tested
- [ ] Test coverage meets threshold

### Test Quality

- [ ] Tests are independent
- [ ] Tests are deterministic
- [ ] Tests have clear names
- [ ] Tests follow AAA pattern (Arrange, Act, Assert)
- [ ] Mocks used appropriately
- [ ] Test data factories used

## Documentation Checklist

### Code Documentation

- [ ] Public APIs documented
- [ ] Complex logic explained
- [ ] Function parameters documented
- [ ] Return values documented
- [ ] Examples provided for complex functions

### Project Documentation

- [ ] README updated if needed
- [ ] API documentation updated
- [ ] Architecture docs updated
- [ ] Changelog updated
- [ ] Migration guides if breaking changes

## Best Practices Checklist

### Language-Specific

- [ ] Follows language best practices
- [ ] Uses modern language features appropriately
- [ ] Avoids deprecated patterns
- [ ] Type safety (TypeScript, etc.)

### Framework-Specific

- [ ] Follows framework conventions
- [ ] Uses framework features correctly
- [ ] No anti-patterns
- [ ] Performance best practices followed

### General

- [ ] No magic numbers (use constants)
- [ ] No hardcoded values
- [ ] Configuration externalized
- [ ] Logging implemented appropriately
- [ ] Monitoring/metrics added
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 472kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall