Skip to content

ahstn/oceans-llm / actions/review-agent/skills/code-review

code-review

Verified

Review GitHub pull requests across correctness, maintainability, architecture, security, and performance, with verified findings submitted as GitHub comments.

references/axes/architecture.md

View on GitHub
# Design & Architecture Axis

Focus on system fit.

Look for:

- violations of module boundaries or ownership
- dependency direction problems or new coupling across layers
- duplication that should be shared, or premature sharing that should stay local
- new patterns that diverge from the codebase without strong reason
- abstractions that are too broad, too leaky, or too generic for the actual need

Do not rewrite the architecture in your head. Judge the actual change in context.

## Canonical ownership and proportionate restructuring

Be ambitious about a simpler design within the changed behavior. The instruction above rejects speculative redesign, not evidence-backed restructuring. Identify existing extension points and utilities before proposing a new runtime, policy layer, or parallel implementation.

Trace dependency direction, state ownership, and the sites that must change together. Look for feature checks spread through unrelated shared flows, duplicated policy, and implementation details exposed in public contracts. Show a concrete maintenance cost and a feasible ownership or state-model change that removes it.

Prefer fewer concepts over more files. Keep tightly coupled logic together when extraction would force readers through helpers meaningful only in sequence. Share a canonical invariant when independent copies can drift; retain local duplication when the contracts differ. Respect staged migrations, compatibility, and rollback needs.

Review rollout order, in-flight state, old/new schema compatibility, and removed entry points when the diff changes them. These are investigation questions, not a quota for broad concerns. Put an issue in `findings` only when its path and line identify a changed RIGHT-side line. Put supported cross-file or deletion-only concerns with no valid anchor in `summary`; never invent an anchor.
rea-analysis-optimizationmorluto/reaOptimize REA providers and shared analysis workflows for agent context, latency, CPU, and memory while preserving correctness and Evidence. Use for analysis bottlenecks and cache or query design; CI/test-suite optimization belongs to rea-ci-tests-audit.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-ci-tests-auditmorluto/reaAudit REA CI and test suites for correctness, fixture drift, false passes, and measured performance; use for suite or workflow investigations and efficiency changes, rather than ordinary feature testing or a single test failure.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
rea-tool-designmorluto/reaAudit, investigate, design, or change REA investigation tools, CLI/MCP contracts, provider capabilities, and Evidence semantics.Stars: 471kUpdated Claude CodeCodexVerifiedInstall
ponytail-auditDietrichGebert/ponytailQuality audit of the whole repo: bugs, security, real load, missing tests, speed, and what to delete. Most important first.Stars: 194kUpdated Claude CodeCodexVerifiedInstall