Adonis0123/adonis-skills / skills/agentic-review-handoff
agentic-review-handoff
VerifiedValidate pasted review findings before fixes; run same-session automatic Git review-fix-re-review with a headless Reviewer and no redundant confirmation; start fresh-eyes Git diff Review Intake; resume review-loop sessions or packets; get a DecisionConsult from another AI; or run first-principles/DDD/high-cohesion review. Requires Git and review/consult intent; ordinary implementation or commit-only requests do not start a review loop.
scripts/test/cli-help.test.mjs
View on GitHub/** CLI help must return before command handlers, repository writes or workers. */
import { afterEach, describe, it } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { spawnSync } from "node:child_process";
const cli = fileURLToPath(new URL("../review-loop.mjs", import.meta.url));
const cleanup = [];
afterEach(() => {
for (const root of cleanup.splice(0))
fs.rmSync(root, { recursive: true, force: true });
});
function guardedProcess(args, script = cli) {
const root = fs.mkdtempSync(path.join(os.tmpdir(), "review-help-"));
cleanup.push(root);
const cwd = path.join(root, "workspace");
fs.mkdirSync(cwd);
const guard = path.join(root, "guard.cjs");
// Block before any external process or file mutation. Even the old CLI cannot
// reach a real Git/model process. The guard lives outside the checked cwd.
fs.writeFileSync(
guard,
`
const fs = require('node:fs');
const cp = require('node:child_process');
const block = name => () => { process.stderr.write('HELP_SIDE_EFFECT_BLOCKED:' + name + String.fromCharCode(10)); throw new Error('HELP_SIDE_EFFECT_BLOCKED:' + name); };
for (const name of ['spawn', 'spawnSync', 'exec', 'execSync', 'execFile', 'execFileSync', 'fork']) cp[name] = block(name);
for (const name of ['writeFile', 'appendFile', 'mkdir', 'mkdtemp', 'rename', 'unlink', 'rm', 'rmdir', 'copyFile', 'cp', 'symlink', 'link', 'chmod', 'chown', 'truncate', 'utimes']) {
if (fs[name]) fs[name] = block(name);
if (fs[name + 'Sync']) fs[name + 'Sync'] = block(name + 'Sync');
if (fs.promises[name]) fs.promises[name] = block('promises.' + name);
}
fs.createWriteStream = block('createWriteStream');
require('node:module').syncBuiltinESMExports();
`,
);
const result = spawnSync(
process.execPath,
["--require", guard, script, ...args],
{
cwd,
encoding: "utf8",
timeout: 10000,
},
);
assert.deepEqual(
fs.readdirSync(cwd),
[],
"CLI must leave the workspace empty",
);
return result;
}
describe("side-effect-free CLI help", () => {
for (const args of [
[],
["help"],
["--help"],
["-h"],
...[
"run",
"fix-completion",
"close",
"evidence",
"consult",
"sessions",
].flatMap((command) => [
[command, "--help"],
[command, "-h"],
]),
["run", "--continue", "--repo=/does-not-exist", "--help"],
["consult", "--peer=codex", "-h"],
]) {
it(`prints help without writes or child processes: ${args.join(" ") || "(empty)"}`, () => {
const result = guardedProcess(args);
assert.equal(result.error, undefined);
assert.equal(result.status, 0, result.stdout + result.stderr);
assert.doesNotMatch(
result.stdout + result.stderr,
/HELP_SIDE_EFFECT_BLOCKED/,
);
const help = JSON.parse(result.stdout);
assert.equal(help.ok, true);
assert.equal(help.mode, "auto-loop");
assert.ok(help.usage.some((line) => line.startsWith("review-loop run ")));
});
}
it("keeps unknown command errors when help is absent", () => {
const result = guardedProcess(["not-a-command"]);
assert.equal(result.status, 1);
assert.match(JSON.parse(result.stdout).error, /Unknown command/);
});
it("guard intercepts normal run before any real child process", () => {
const result = guardedProcess(["run"]);
assert.notEqual(result.status, 0);
assert.match(result.stdout + result.stderr, /HELP_SIDE_EFFECT_BLOCKED/);
});
});
Related skills
| Skill | Stars | Updated | Works with | Status | Install |
|---|---|---|---|---|---|
| reverse-engineer-anythingmorluto/reaReverse engineer native, managed, Electron/JavaScript, packaged, firmware, and browser targets with REA, and build agent environments (AgentEnv bundles) of web applications from a live instance or a capture, and of Linux desktop apps with a task from a request. Use shipped-artifact or requested runtime evidence to explain features, compare versions, decompile code, or guide a reconstruction. Skip REA for ordinary source-repository architecture analysis. | Stars: 472k | Updated | Claude CodeCodex | Verified | Install |
| diagnosing-superpowersobra/superpowersUse when a superpowers session went wrong and your human partner wants to know why — repeated work, ignored plans, stumbles, poor results, a skill that didn't fire, "it took too long", "why is it so expensive", "what is it doing" — or wants to build a bug report for the superpowers maintainers, for the current session or a past one identified by id or path, on any harness. | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| dispatching-parallel-agentsobra/superpowersUse when facing 2+ independent tasks that can be worked on without shared state or sequential dependencies | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |
| executing-plansobra/superpowersUse when executing an implementation plan in the current session as the implementer yourself — your human partner chose inline execution, or no subagent tool is available | Stars: 322k | Updated | Claude CodeCodex | Verified | Install |